From: Joey Lu <a0987203069@gmail.com>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: airlied@gmail.com, simona@ffwll.ch,
maarten.lankhorst@linux.intel.com, mripard@kernel.org,
tzimmermann@suse.de, robh@kernel.org, krzk+dt@kernel.org,
conor+dt@kernel.org, ychuang3@nuvoton.com, schung@nuvoton.com,
yclu4@nuvoton.com, linux-arm-kernel@lists.infradead.org,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/3] arm64: dts: nuvoton: ma35d1: add display controller support
Date: Fri, 6 Feb 2026 15:12:57 +0800 [thread overview]
Message-ID: <a0910eb7-4597-45a7-b538-f2feb021f389@gmail.com> (raw)
In-Reply-To: <20260205-tactful-warm-chicken-50bdc8@quoll>
On 2/5/2026 9:23 PM, Krzysztof Kozlowski wrote:
> On Thu, Jan 29, 2026 at 12:05:31PM +0800, Joey Lu wrote:
>> &uart0 {
>> @@ -129,3 +165,23 @@ &uart16 {
>> pinctrl-0 = <&pinctrl_uart16>;
>> status = "okay";
>> };
>> +
>> +&panel {
>> + port {
>> + panel_in: endpoint@0 {
>> + remote-endpoint = <&dpi_out>;
>> + };
>> + };
>> +};
>> +
>> +&display {
> What sort of ordering rule is followed in Nuvoton? Why is it different
> than DTS coding style? Why do you choose other style?
>
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&pinctrl_display>;
>> + status = "okay";
>> +
>> + port {
>> + dpi_out: endpoint@0 {
>> + remote-endpoint = <&panel_in>;
>> + };
>> + };
>> +};
>> diff --git a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
>> index e51b98f5bdce..7d9d077f12b2 100644
>> --- a/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
>> +++ b/arch/arm64/boot/dts/nuvoton/ma35d1.dtsi
>> @@ -379,5 +379,19 @@ uart16: serial@40880000 {
>> clocks = <&clk UART16_GATE>;
>> status = "disabled";
>> };
>> +
>> + panel: panel {
> No, there is no way your SoC has a panel.
>
> Don't add fake stuff to your DTS.
>
> Best regards,
> Krzysztof
I'll move panel nodes out of dtsi into board dts.
Joey
next prev parent reply other threads:[~2026-02-06 7:13 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-29 4:05 [PATCH v2 0/3] drm: nuvoton: Add MA35D1 display controller support Joey Lu
2026-01-29 4:05 ` [PATCH v2 1/3] dt-bindings: display: nuvoton: add MA35D1 DCU binding Joey Lu
2026-02-05 13:18 ` Krzysztof Kozlowski
2026-02-06 7:05 ` Joey Lu
2026-01-29 4:05 ` [PATCH v2 2/3] arm64: dts: nuvoton: ma35d1: add display controller support Joey Lu
2026-02-05 13:23 ` Krzysztof Kozlowski
2026-02-06 7:12 ` Joey Lu [this message]
2026-02-06 8:56 ` Krzysztof Kozlowski
2026-02-06 9:21 ` Joey Lu
2026-01-29 4:05 ` [PATCH v2 3/3] drm/nuvoton: add MA35D1 display controller driver Joey Lu
2026-02-05 13:22 ` Krzysztof Kozlowski
2026-02-06 7:23 ` Joey Lu
2026-02-06 15:09 ` Icenowy Zheng
2026-02-09 8:45 ` Joey Lu
2026-02-10 12:02 ` Icenowy Zheng
2026-03-03 8:15 ` Joey Lu
2026-03-08 15:20 ` Icenowy Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0910eb7-4597-45a7-b538-f2feb021f389@gmail.com \
--to=a0987203069@gmail.com \
--cc=airlied@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=robh@kernel.org \
--cc=schung@nuvoton.com \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
--cc=ychuang3@nuvoton.com \
--cc=yclu4@nuvoton.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox