From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A713BC433B4 for ; Tue, 18 May 2021 18:33:25 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 337C761261 for ; Tue, 18 May 2021 18:33:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 337C761261 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=S1Y4YdRrLODdVRUgJuLZFIJ5IFQkChOPavlXxYGyycA=; b=R35izKk4PkWz/wPsr8SQt3Slq dpTNwA7vRy2MUkh0FHAmaMHyLIfcMI2XaEPJVpqQ7RwW+DirfjMGmctEH8Fzf4aNeimKzpMOsm5I8 yKUjig7RJIY+9cBptFnJLerkGrq6vl3JYoAoANB5+mhqlgY/t42woJ9yF/8Qt29EJWFBd6dIi7F7r R5QOi5pbkwoAxNlBvtMtlCgqljwkmiY7askeKVjAbLvqA7CQb+eOqrATuE6FJaiB/G1UcCH3OavNq Spm3w/7dvOZZD1N+Xre/zBiKI+BQInXaXbcBq/D1gTWVzS2WzrOj6NNSvOSUy65nR1hCoiLMTHOEZ lxboMbtpw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj4V9-001byV-Ad; Tue, 18 May 2021 18:31:31 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj4V5-001by6-1q for linux-arm-kernel@desiato.infradead.org; Tue, 18 May 2021 18:31:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:Cc:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=rkrv6JzgCxpvZGfSB1L7vBcPRZh36ZLwSkD7N1m5DAQ=; b=i2+bMbCYTSwHZX1uF97peJLx1F TOYjFBCMH4uxpsCKAr0J6lgo/zHjKzTNjKES+pk5CBbrTVqVFf3CMXCBZFeDVaXFfrZwm15kJq7I3 /qySFpF0y9G+9GHcYzOg3c8hqRGoDpPV3UIRGNvx2i4Jea7bgTkL1W+qQLNYQwcKp3Jq38bo0X5Zh FskYwmxEatVAp8EsyDMvabrbcgQ1ggDmAA8eXOFhK6PRD/GM84cRMfMI6hqrzZ2gTpU4qA2MUMJbE PAg+7qty8z2LU+9H4KDwCsTL2klO3ZwKOpW6c1RzXh/IiRq+Qcgjcq4tyghi9uq/Z3eOptIW3Zrqj QFCe9jhw==; Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj4V1-00EsnK-PB for linux-arm-kernel@lists.infradead.org; Tue, 18 May 2021 18:31:25 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5A9EA101E; Tue, 18 May 2021 11:31:18 -0700 (PDT) Received: from [10.57.36.146] (unknown [10.57.36.146]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 7A16E3F719; Tue, 18 May 2021 11:31:17 -0700 (PDT) Subject: Re: [RFC PATCH 0/8] coresight: syscfg: dynamic load, resource management To: Mike Leach , coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org, mathieu.poirier@linaro.org, leo.yan@linaro.org References: <20210512211752.4103-1-mike.leach@linaro.org> From: Suzuki K Poulose Message-ID: Date: Tue, 18 May 2021 19:31:15 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210512211752.4103-1-mike.leach@linaro.org> Content-Language: en-GB X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_113123_967792_D14A7E70 X-CRM114-Status: GOOD ( 26.60 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Mike On 12/05/2021 22:17, Mike Leach wrote: > This patchset represents the second phase of CoreSight configuration > management. Thanks for the series. > > 1) API updated to allow dynamic load and unload of configurations and > features. Dependency management between loaded sets is added. > > 2) New configuration and feature sets can be added using a loadable module. > An example in /samples/coresight is provided to demonstrate this. Is it possible to do this at runtime configfs ? I thought we tied this to configfs for this feautre. While the module approach works, I feel is a hinderance for wider adoption and is something that doesn't allow for use on production systems. > > 3) Resource management API is added. This allows the system to ensure that > loaded configurations and features are only loaded onto devices that can > support them. > > Further - it ensures that configurations with multiple features cannot over > allocate resources. > > 4) configfs can be used to activate a configuration which will then be used > when controlling tracing using sysfs. > > 5) Resource management is added to ETMv4 configurations. This allows current > and future features and configurations to be defined in terms of resources > used as well as registers to be programmed. > > Defining features in this way allows the resource management to operate > correctly. > > The perf event parsing is also adjusted to allow the ETM resources requested > on the command line (e.g. address filters, etc) to be correctly handled > using resoruce management alongside the complex configurations such as > autofdo. > > Applies to coresight/next - which is 5.13-rc1 + initial Coresight configuration > patchset. > > To follow in future revisions / sets:- > a) load of additional config and features by configfs Is this something that implements what I requested above ? Then I don't see how the module approach will be used once that is in place and we will be left with something to maintain forever. Suzuki > b) ECT and CTI and other Coresight components support for configuration and > features. > > > Mike Leach (8): > coresight: syscfg: Update API to allow dynamic load and unload > coresight: syscfg: Update load API for config loadable modules > coresight: syscfg: Example CoreSight configuration loadable module > coresight: configfs: Allow configfs to activate configuration. > coresight: syscfg: Add API to check and validate device resources. > coresight: etm4x: syscfg: Add resource management to etm4x. > coresight: etm4x: Update perf event resource handling. > coresight: etm4x: Update configuration example. > > MAINTAINERS | 1 + > .../hwtracing/coresight/coresight-cfg-afdo.c | 38 +- > .../coresight/coresight-cfg-preload.c | 9 +- > .../hwtracing/coresight/coresight-config.c | 71 ++- > .../hwtracing/coresight/coresight-config.h | 45 +- > .../hwtracing/coresight/coresight-etm4x-cfg.c | 533 ++++++++++++++++++ > .../hwtracing/coresight/coresight-etm4x-cfg.h | 196 ++++++- > .../coresight/coresight-etm4x-core.c | 250 +++----- > .../coresight/coresight-syscfg-configfs.c | 87 +++ > .../coresight/coresight-syscfg-configfs.h | 4 + > .../hwtracing/coresight/coresight-syscfg.c | 390 +++++++++++-- > .../hwtracing/coresight/coresight-syscfg.h | 38 +- > include/linux/coresight.h | 2 + > samples/Kconfig | 9 + > samples/Makefile | 1 + > samples/coresight/Makefile | 4 + > samples/coresight/coresight-cfg-sample.c | 73 +++ > 17 files changed, 1511 insertions(+), 240 deletions(-) > create mode 100644 samples/coresight/Makefile > create mode 100644 samples/coresight/coresight-cfg-sample.c > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel