From: elfring@users.sourceforge.net (SF Markus Elfring)
To: linux-arm-kernel@lists.infradead.org
Subject: ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show()
Date: Mon, 17 Oct 2016 13:30:59 +0200 [thread overview]
Message-ID: <a09542e6-9851-45ef-583d-338205217cfc@users.sourceforge.net> (raw)
In-Reply-To: <20161017105605.GB29095@leverpostej>
>> Some data were printed into a sequence by six separate function calls.
>> Print the same data by a single function call instead.
>
> ... why?
>
> Beyond simply having fewer function calls, is there an upside?
Will it matter to improve run time characteristics at this source code place?
> This makes it harder to see the relationship between the format strings
> and their associated data, and makes the code longer.
Do you prefer an other layout for the passed data so that the increase
of line count in my update suggestion would look differently?
Regards,
Markus
next prev parent reply other threads:[~2016-10-17 11:30 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-16 19:03 [PATCH] ARM64-cpuinfo: Combine six calls for sequence output into one seq_printf() call in c_show() SF Markus Elfring
2016-10-17 9:37 ` Matthias Brugger
2016-10-17 10:56 ` Mark Rutland
2016-10-17 11:30 ` SF Markus Elfring [this message]
2016-10-17 12:37 ` Mark Rutland
2016-10-17 12:50 ` SF Markus Elfring
2016-10-17 13:10 ` Mark Rutland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a09542e6-9851-45ef-583d-338205217cfc@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).