From: Marc Zyngier <maz@kernel.org>
To: Biwen Li <biwen.li@oss.nxp.com>
Cc: mark.rutland@arm.com, Biwen Li <biwen.li@nxp.com>,
jason@lakedaemon.net, linux-kernel@vger.kernel.org,
leoyang.li@nxp.com, tglx@linutronix.de, ran.wang_1@nxp.com,
jiafei.pan@nxp.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace
Date: Wed, 27 Jan 2021 11:38:21 +0000 [thread overview]
Message-ID: <a0c0cdaee31d49848525332deec6eb75@kernel.org> (raw)
In-Reply-To: <20210127085818.23742-1-biwen.li@oss.nxp.com>
On 2021-01-27 08:58, Biwen Li wrote:
> From: Biwen Li <biwen.li@nxp.com>
>
> Add flag IRQCHIP_SKIP_SET_WAKE to remove call trace as follow,
> ...
> [ 45.605239] Unbalanced IRQ 120 wake disable
> [ 45.609445] WARNING: CPU: 0 PID: 1124 at kernel/irq/manage.c:800
> irq_set_irq_wake+0x154/0x1a0
> ...
> [ 45.645141] pstate: 60000085 (nZCv daIf -PAN -UAO -TCO BTYPE=--)
> [ 45.651144] pc : irq_set_irq_wake+0x154/0x1a0
> [ 45.655497] lr : irq_set_irq_wake+0x154/0x1a0
> ...
> [ 45.742825] Call trace:
> [ 45.745268] irq_set_irq_wake+0x154/0x1a0
> [ 45.749278] ds3232_resume+0x38/0x50
>
> On ls2088ardb:
> In suspend progress(# echo mem > /sys/power/state),
> pm_suspend()->suspend_devices_and_enter()->dpm_suspend()->device_suspend()
> ->ds3232_suspend()->enable_irq_wake()->irq_set_irq_wake()
> ->set_irq_wake_real(), return -ENXIO, there get
> "Cannot set wakeup source" in ds3232_suspend().
>
> In resume progress(wakeup by flextimer)
> dpm_resume_end()->dpm_resume()
> ->device_resume()->ds3232_resume()
> ->disable_irq_wake()->irq_set_irq_wake()
> ->set_irq_wake_real(), there get
> kernel call trace(Unbalanced IRQ 120 wake
> disable)
This is again paraphrasing the stack trace instead of explaining
the problem it fixes. How about:
"The ls-extirq driver doesn't implement the irq_set_wake()
callback, while being wake-up capable. This results in
ugly behaviours across suspend/resume cycles.
Advertise this by adding IRQCHIP_SKIP_SET_WAKE to the irqchip
flags"
The subject line should be fixed along the same lines, and
a Fixes: tag added.
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-01-27 11:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-27 8:58 [v2] irqchip: ls-extirq: add flag IRQCHIP_SKIP_SET_WAKE to remove call trace Biwen Li
2021-01-27 11:38 ` Marc Zyngier [this message]
2021-01-28 2:37 ` Biwen Li (OSS)
2021-01-28 9:02 ` Marc Zyngier
2021-01-29 2:55 ` Biwen Li (OSS)
2021-01-29 8:54 ` Marc Zyngier
2021-01-29 9:44 ` Biwen Li (OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a0c0cdaee31d49848525332deec6eb75@kernel.org \
--to=maz@kernel.org \
--cc=biwen.li@nxp.com \
--cc=biwen.li@oss.nxp.com \
--cc=jason@lakedaemon.net \
--cc=jiafei.pan@nxp.com \
--cc=leoyang.li@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ran.wang_1@nxp.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).