From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51D2AC04E53 for ; Wed, 15 May 2019 10:10:49 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 25A9F2084A for ; Wed, 15 May 2019 10:10:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rxHEBLHT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 25A9F2084A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BXlPIgYX7gr1praQ1GlT3InK9dcLhTWeaG6KacyRyOY=; b=rxHEBLHTIuHwUi +6ShOhIqFzjQv9g+D8/l/7+6mtJExQUnR4fanwDe3e+cfCwuJlARpGZIk6planyf8skM9rApXec5V APQRkTnbkIjToAI1sbZUmCkmfiqsizwyAow2xKmk6gg83uQX3i9iRFxViNGT4b3xid4ZEyCLE5cmc DZ0YrTbF5Ug7lhPM+mh9h4XFbmvTCR2NkerZsv6XPgZPD5Ph90EOLEK1VEbewbZF8LUVUlJI4yZ06 G+edpMVpxRLu+d9YdO+VfX/+TzPKXQ7skJwaXtXg9gPLbxqs62u+6/i4EMLNwrkojZhpNe4kvmcgH 6QT5V3JjWFTQXQ1l4YvQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQqrz-0005yX-Kt; Wed, 15 May 2019 10:10:43 +0000 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70] helo=foss.arm.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hQqrw-0005yE-AW for linux-arm-kernel@lists.infradead.org; Wed, 15 May 2019 10:10:41 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id A5D0280D; Wed, 15 May 2019 03:10:38 -0700 (PDT) Received: from [10.163.1.137] (unknown [10.163.1.137]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 143C63F703; Wed, 15 May 2019 03:10:32 -0700 (PDT) Subject: Re: [PATCH V4] mm/ioremap: Check virtual address alignment while creating huge mappings To: Will Deacon References: <1557887716-17918-1-git-send-email-anshuman.khandual@arm.com> <20190515094655.GB24357@fuggles.cambridge.arm.com> From: Anshuman Khandual Message-ID: Date: Wed, 15 May 2019 15:40:40 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190515094655.GB24357@fuggles.cambridge.arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190515_031040_371395_B6DD9111 X-CRM114-Status: GOOD ( 18.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Toshi Kani , Catalin Marinas , linux-mm@kvack.org, Chintan Pandya , Andrew Morton , Thomas Gleixner , linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 05/15/2019 03:16 PM, Will Deacon wrote: > On Wed, May 15, 2019 at 08:05:16AM +0530, Anshuman Khandual wrote: >> Virtual address alignment is essential in ensuring correct clearing for all >> intermediate level pgtable entries and freeing associated pgtable pages. An >> unaligned address can end up randomly freeing pgtable page that potentially >> still contains valid mappings. Hence also check it's alignment along with >> existing phys_addr check. >> >> Signed-off-by: Anshuman Khandual >> Cc: Toshi Kani >> Cc: Andrew Morton >> Cc: Will Deacon >> Cc: Chintan Pandya >> Cc: Thomas Gleixner >> Cc: Catalin Marinas >> --- >> Changes in V4: >> >> - Added similar check for ioremap_try_huge_p4d() as per Toshi Kani > > Sorry to be a pain, but in future please can you just resend the entire > series as a v4 (after giving it a few days for any other comments to come > in) if you make an update? It's a bit fiddly tracking which replies to which > individual patches need to be picked up, although I'm sure this varies > between maintainers. I wondered for some time about both the ways before landing on this side as it was pretty minor change. I understand the concern and will follow the suggestion next time around. If this one requires further update, will make it V5 and carry the change logs from here. > > No need to do anything this time, but just a small ask for future patches. Sure will do. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel