From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33EAACD1284 for ; Thu, 4 Apr 2024 10:16:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:CC:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RGLmOsIBYKqjMOYIK1dr1CeMBsLjwsAAU+LKVfwRwvM=; b=hEzbunqqct6tfM knx6SJ2kfYRxWRyLzmJR0Q8YqYs3+bfpAIdYZPrPR+8VH4O9NDxs6fqwBPaifUM8sQU/F+PxyHdp6 /78I2MoBL+oNhWtcLllnp0u0RQ+6pWCP6UxQdeI1UL5kjImXemOZlV49RcBd4JBhqe6pJGgJ2Ijxa ujeyD7Z4gnnCyrpSvfNlHTQeSQuJ9J1F3uxkmNTpcTh+l7gf/shgveIVYOvt7dOzk58srOaFIhq4q HkMcmfU0AGSxUtfGSv13A+v+3yh3DkCI/G611XSn6kT/Ca8jThMt36eGOVYu+h0vck5cyOMY46hUN zm6dsUtyHk9GwF44bVew==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsK8x-000000029U5-3J2i; Thu, 04 Apr 2024 10:16:27 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rsK8t-000000029T6-46Bg for linux-arm-kernel@lists.infradead.org; Thu, 04 Apr 2024 10:16:25 +0000 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 434AGHZo010046; Thu, 4 Apr 2024 05:16:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1712225777; bh=K09Az5yAkNL2uNDRy1cAcJwTnDrohVX6gc31VbDkJ0w=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=OkfKZM0teHraQX1K4KT5Dy2ROUID1ILnzShDL+cq2R9c1ReuRwsKy7frbA8y/F3xt ix5b8sftVgFrSztj8VyqrRTnnDU2Oq5FTUBNqdPldnh0BAya3lXnLo/BRusHHOYSsV +SWzn5FQx7ZojMTmQYCAb9otNj56ZbdTBsPfBF2A= Received: from DFLE115.ent.ti.com (dfle115.ent.ti.com [10.64.6.36]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 434AGHON026933 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 4 Apr 2024 05:16:17 -0500 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE115.ent.ti.com (10.64.6.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Thu, 4 Apr 2024 05:16:17 -0500 Received: from lelvsmtp6.itg.ti.com (10.180.75.249) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via Frontend Transport; Thu, 4 Apr 2024 05:16:17 -0500 Received: from localhost (uda0492258.dhcp.ti.com [172.24.227.9]) by lelvsmtp6.itg.ti.com (8.15.2/8.15.2) with ESMTP id 434AGGXY060696; Thu, 4 Apr 2024 05:16:17 -0500 Date: Thu, 4 Apr 2024 15:46:16 +0530 From: Siddharth Vadapalli To: Krzysztof Kozlowski CC: Siddharth Vadapalli , , , , , , , , , , , Subject: Re: [PATCH v2] arm64: dts: ti: k3-am62p: use eFuse MAC Address for CPSW3G Port 1 Message-ID: References: <20240404081845.622707-1-s-vadapalli@ti.com> <18eb0e55-38ad-44f9-90b7-1917d8c0d5bb@linaro.org> <75b53dda-23aa-4915-944a-4d9a619bd165@ti.com> <903ad855-ab26-4ef3-80bd-249917056188@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <903ad855-ab26-4ef3-80bd-249917056188@linaro.org> X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240404_031624_214794_DFE34094 X-CRM114-Status: GOOD ( 24.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Apr 04, 2024 at 12:00:09PM +0200, Krzysztof Kozlowski wrote: > On 04/04/2024 11:12, Siddharth Vadapalli wrote: > > On Thu, Apr 04, 2024 at 10:43:04AM +0200, Krzysztof Kozlowski wrote: > >> On 04/04/2024 10:18, Siddharth Vadapalli wrote: > >>> Add the "cpsw-mac-efuse" node within "wkup_conf" node corresponding to the > >>> CTRLMMR_MAC_IDx registers within the CTRL_MMR space. Assign the compatible > >>> "ti,am62p-cpsw-mac-efuse" to enable "syscon_regmap" operations on these > >>> registers. The MAC Address programmed in the eFuse is accessible through > >>> the CTRLMMR_MAC_IDx registers. The "ti,syscon-efuse" device-tree property > >>> points to the CTRLMMR_MAC_IDx registers, allowing the CPSW driver to fetch > >>> the MAC Address and assign it to the network interface associated with > >>> CPSW3G MAC Port 1. > >>> > >>> Signed-off-by: Siddharth Vadapalli > >>> --- > >>> ... > > > > >> > >>> }; > >>> > >>> cpsw_port2: port@2 { > >>> diff --git a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > >>> index a84756c336d0..df9d40f64e3b 100644 > >>> --- a/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > >>> +++ b/arch/arm64/boot/dts/ti/k3-am62p-wakeup.dtsi > >>> @@ -18,6 +18,11 @@ chipid: chipid@14 { > >>> reg = <0x14 0x4>; > >>> bootph-all; > >>> }; > >>> + > >>> + cpsw_mac_efuse: cpsw-mac-efuse@200 { > >> > >> Node names should be generic. See also an explanation and list of > >> examples (not exhaustive) in DT specification: > >> https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation > > > > I was following the convention that other mfd-syscon compatible nodes > > seemed to be using: > > https://github.com/torvalds/linux/blob/41bccc98fb7931d63d03f326a746ac4d429c1dd3/arch/arm64/boot/dts/ti/k3-am65-main.dtsi#L502 > > The node is: > > dss_oldi_io_ctrl: dss-oldi-io-ctrl@41e0 > > corresponding to the compatible: > > "ti,am654-dss-oldi-io-ctrl" > > which was added by commit: > > https://github.com/torvalds/linux/commit/cb523495ee2a5938fbdd30b8a35094d386c55c12 > > So if that one was wrong, then what? I don't know really what type of > device is it, but just because one contributor called it that way, does > not mean you should keep going. Maybe investigate why that contributor > did not decide to follow Devicetree spec recommendation? Yes, it doesn't justify the convention. I seem to have picked a wrong example when figuring out the convention for naming the node. I plan to name it as: ethernet-mac-efuse while retaining the label "cpsw_mac_efuse" since CPSW is the name of the Ethernet Switch on the SoC. Please let me know if it is acceptable. I will post the v3 patch based on your feedback. Regards, Siddharth. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel