From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78485C3DA7F for ; Wed, 7 Aug 2024 17:25:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=U7AsICvb8jzWyYjh82OBEPCykHI3UCx9QM0GMfljvRI=; b=YkD+qSqBDvffItrs5W5Gq8qMBr gbp0bWZDKSsJH3kcpX2pSMaFGBg4b79QzZLzc4YeXP1XAFBYL2b/9utaTh43srd8VwXwL/kYGev1h RwHIgjTDcdlS4JcyBYS7J02fRQeztEEwDf6dEcNUjI8MPMIdn3s5/6Ma3bCAt+vlJQ0KwwDt3bEQ3 5gK4Wa+Q17Y8mPZm/DAS883bJKrXuJlj7x5VJehvMIJKgW8AOr1kntCkhrOV284WC2nrSIhQ/rF6I 6FhNRMYPJoLx+nzkQjLQgHeWpWAUTrshu0K8M13YgHqraJCBh7K7f4UmRPFLfRrWnXcGYQf2ExUSd nzuHhPSw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbkPI-00000005oY6-2Nwd; Wed, 07 Aug 2024 17:25:04 +0000 Received: from mail.manjaro.org ([2a01:4f8:c0c:51f3::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sbkOj-00000005oTF-3Jlk; Wed, 07 Aug 2024 17:24:31 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1723051467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U7AsICvb8jzWyYjh82OBEPCykHI3UCx9QM0GMfljvRI=; b=tXv2DMGvES825b2rtkMZ/s/4HtH9DrdIz2cxxB4Rf4XzSO/sBpWrk3F6b9Sw2Fi4hsV416 MX2J6xtIdvz/reBdnGechtP/vib/HzzW8fXNdECHJHzrspsvr+mRwJ8pw73lhzxY+ZNN61 nJ4p/sH9CHdXbF0C9mE9K4tVgO/VYBR9EvKX+W6xumeAZrfAbrFyajJ6TE5l/FUMiX08Pd VdCSgO+ncyfRSiiUkm68YCrXi86iNxdhge6LtP3QxgdosA1lI6g+9RUTRgPFag+QzuewdZ t6YhqPibMeo2YaGHtd8q4DyIl9luqnjgt4AJdypEV21iaiTdZlBUQmhg5AIE2w== Date: Wed, 07 Aug 2024 19:24:27 +0200 From: Dragan Simic To: Florian Klink Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Sebastian Reichel , Kever Yang , Muhammed Efe Cetin , FUKAUMI Naoki , =?UTF-8?Q?Tam=C3=A1s_Sz=C5=B1cs?= , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: dts: rockchip: add rfkill node for M.2 E wifi on orangepi-5-plus In-Reply-To: <20240807170030.1747381-1-flokli@flokli.de> References: <20240807162001.1737829-1-flokli@flokli.de> <20240807170030.1747381-1-flokli@flokli.de> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240807_102430_039882_02467C23 X-CRM114-Status: GOOD ( 14.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2024-08-07 19:00, Florian Klink wrote: > This follows the same logic as 82d40b141a4c ("arm64: dts: rockchip: add > rfkill node for M.2 Key E WiFi on rock-5b"). > > On the orangepi-5-plus, there's also a GPIO pin connecting the WiFi > enable signal inside the M.2 Key E slot. > > The exact GPIO PIN can be validated in the Armbian rk-5.10-rkr4 kernel > rk3588-orangepi-5-plus.dtsi file [1], which contains a `wifi_disable` > node referencing RK_PC4 on &gpio0. > > Signed-off-by: Florian Klink > Tested-by: Florian Klink I forgot to mention that providing a Tested-by tag is redundant when there's already a Signed-off-by tag, because the latter already implies the former. > Link: > https://github.com/armbian/linux-rockchip/blob/9fbe23c9da24f236c6009f42d3f02c1ffb84c169/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > [1] > --- > arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > index e74871491ef5..c3a6812cc93a 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588-orangepi-5-plus.dts > @@ -105,6 +105,13 @@ led { > }; > }; > > + rfkill { > + compatible = "rfkill-gpio"; > + label = "rfkill-pcie-wlan"; > + radio-type = "wlan"; > + shutdown-gpios = <&gpio0 RK_PC4 GPIO_ACTIVE_HIGH>; > + }; > + > sound { > compatible = "simple-audio-card"; > pinctrl-names = "default";