From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 20655C3F6B0 for ; Tue, 16 Aug 2022 07:54:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EyG4Y5Q2tj2OIWFZwS+Xl2DwH4Nkg1lsMw5yKidWHjg=; b=AKZaPhQ9J46t7L fpP0K11YI/TZAH+IvlthNSWZr0dUZCkwmmX1bt9fcTEoSaw0dwWUg6zYobRM+XRIt25/1ALUtXtXW 5nBJZcMRKlmVig2WNW8cR8/Vuw++nX4eukvVASh8wEPOuJ1Is0Uw9LM9nFFx1EtNYgLI3P6q95FtS bwJTni1X6jr4Yf0P4W6xJ/aAtut1KKm1PE6KYaQ5SIGlcd6BCiUdqNpxazuvmg57HK26bYf794RNF OG0Hnt1Pvg0mFv97uwVpgHxiEJoZTK/xp++/KwHlHb3p8Y0z0ZJPpdnCGx0rLXdvAfDJi5QQnbzc2 p7TMJrjsb8utvCOrcM4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNrNi-00Fp7N-Al; Tue, 16 Aug 2022 07:52:59 +0000 Received: from mail-lj1-x230.google.com ([2a00:1450:4864:20::230]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oNrMr-00FoDM-NQ for linux-arm-kernel@lists.infradead.org; Tue, 16 Aug 2022 07:52:09 +0000 Received: by mail-lj1-x230.google.com with SMTP id u6so9859424ljk.8 for ; Tue, 16 Aug 2022 00:52:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=Zo8H3uzErLP1wNsnlXwUezo5M3r0n38M91eeu4OULT8=; b=jYUghN9OlERJWRrLTTvraX96AytkJohc0st+7N7n7OB4ZSPw8KZwEmt2cFt0sxN3Tk PGpXWGU/W/VXC2vX9FtohU70nERi3HQZPDO5ttWiI+7lZuCvZiNJ8KkssrR55EBvxTvN WyumD4f2peQ9blnK5oI0sH9qiHpPEQXlG0YKYhkbTRy3lkPgZhq7aFhIr+S8BA5YAQI1 BQ7ie9FMwQ7JCMwe1Rgb/uGycDcD72o+idkASf6Yxl/sz/zUvkKik3IEvp1bIRhzAzOl pLfa9syB+HQCp5lGEVj1hJfg2FNfAq6GBQt4eek0mX77L/9olL5guGe+TeR24sozxguA O3Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=Zo8H3uzErLP1wNsnlXwUezo5M3r0n38M91eeu4OULT8=; b=bvAukKsuFNbNz2mgys0r9VR5STg/vlK55Rmgj+uy/msGK5YHkvAwmLRRHw142ORQnt xbvdXTwfnwDcTfDCz2mf3cvMjjhaQfBExgnFdivFZcYK/vf5K/54Q+8XklYWbIsuMyyj aso+nDWQRrC0TqgIqe4+u2mExT7roQ+dTlpkKQeX6+9n/FXnqBbdGQIfEP6Jab4g0nhh RSRbmhDvy4eJnOyLhOIAdjGrY8RmzlG7jsEu/FD3D7SCb/XxH5cLwKhsdAB3HtPNU1aq Lkk9z+0twI12O9I98jV3aFmIXSAs4D+UR1X0jc2dlH4AFwzbEGdj49Q8OFxXY9KO+olX iimQ== X-Gm-Message-State: ACgBeo12tx8608sOfZGqkadEnIkfxy8GXS/T+lrpvJWSLnBV84kCIn2/ amw1hJ5J3JPvlpWZfm+I+PqJTA== X-Google-Smtp-Source: AA6agR6+SnVBnZcM+MorC2B6pGea+5Cy8dza4nJPUFRgbZ+cRDJR1xIU0DuzrV6wJ5MeUlQmtuJ8xA== X-Received: by 2002:a05:651c:2212:b0:25e:cc38:a1dc with SMTP id y18-20020a05651c221200b0025ecc38a1dcmr6509948ljq.359.1660636323001; Tue, 16 Aug 2022 00:52:03 -0700 (PDT) Received: from ?IPV6:2001:14bb:ae:539c:1782:dd68:b0c1:c1a4? (d15l54g8c71znbtrbzt-4.rev.dnainternet.fi. [2001:14bb:ae:539c:1782:dd68:b0c1:c1a4]) by smtp.gmail.com with ESMTPSA id p4-20020a19f004000000b0048a98b7bad3sm1302318lfc.197.2022.08.16.00.52.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Aug 2022 00:52:02 -0700 (PDT) Message-ID: Date: Tue, 16 Aug 2022 10:52:01 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH v3 2/2] arm64: dts: rockchip: Add initial support for Pine64 PinePhone Pro Content-Language: en-US To: Tom Fitzhenry , robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, heiko@sntech.de Cc: martijn@brixit.nl, ayufan@ayufan.eu, megi@xff.cz, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, phone-devel@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220815123004.252014-1-tom@tom-fitzhenry.me.uk> <20220815123004.252014-3-tom@tom-fitzhenry.me.uk> From: Krzysztof Kozlowski In-Reply-To: <20220815123004.252014-3-tom@tom-fitzhenry.me.uk> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220816_005207_165138_3DE33B7A X-CRM114-Status: UNSURE ( 8.98 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/08/2022 15:30, Tom Fitzhenry wrote: > + > +/dts-v1/; > +#include > +#include "rk3399.dtsi" > +#include "rk3399-opp.dtsi" > + > +/ { > + model = "Pine64 PinePhonePro"; > + compatible = "pine64,pinephone-pro", "rockchip,rk3399"; > + chassis-type = "handset"; > + > + aliases { > + mmc0 = &sdio0; > + mmc1 = &sdmmc; > + mmc2 = &sdhci; > + }; > + > + chosen { > + stdout-path = "serial2:115200n8"; > + }; > + > + gpio-keys { > + compatible = "gpio-keys"; > + pinctrl-names = "default"; > + pinctrl-0 = <&pwrbtn_pin>; > + > + power { Still wrong. Do not ignore comments and test your DTS with dtbs_check. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel