From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 17910C4332F for ; Fri, 10 Nov 2023 10:22:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xhiuyRzTwLzMncWJDZ5nX5Wma26hDut7q0zyf+iZvJk=; b=cWZTKbQ9S90xda raCm9MjceByf2xJ5ltUBNCLBnYm88D/QxPgVhF+JstN56kRpy680ewVqgKHC/xiyT+ExZs0zEDukh 9Twvc9x1kN6ZeC3nx6rExGzF+hfvYj64/QgWVBu6rJaRhPzDEJgqe/kOdNfiU7KT9T5DbgQBqmfkf 9lNpPr+nJVMaGd7vVe0fsqtOJxWu6E4yWZpLbbo0HgwMk7wJGmNqWFdchKrIw9K0k7PK80B0TtvX2 ASxEdGpgo+Jlg1Mar/lLgRg31yXUFPnhxKccQ8HX7JND47Wqt1lBSqU7WYxTz8ztghH0O/Ge1NBZI cc6jTq3c+lMFKcChSiQg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1Oe9-008Hn1-1z; Fri, 10 Nov 2023 10:21:53 +0000 Received: from mout.gmx.net ([212.227.17.21]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1Oe5-008HmB-2w; Fri, 10 Nov 2023 10:21:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=s31663417; t=1699611702; x=1700216502; i=wahrenst@gmx.net; bh=pDxBNkCtCkZS6G8VVFGb2hFThM0VDkxh3OXp+guyeQE=; h=X-UI-Sender-Class:Date:Subject:To:Cc:References:From: In-Reply-To; b=tiqoqms45cjSluer2tQFyKyGah+gnuoEPmDjvpd063Wyg6etaqmsZAIftb4MrujM QMFslV7rIqGV26EzDrQmfYk1OSiNHOM8tQvNjjAt0Qd4ny0rWgM6FwGmpNGTn+es6 PE2Vm71ac3ZmP4UTou8HI1OebkNiybmQBFeOInOXT3EAeWi6KDZ6X3nIVFoUKDdqT nxc4xbhkHTWrO50NAqH3xTekoYJLETEd1iA39SKNaiyWCb3KEvU91q2YzFKMIIl3V /jKNBz9m1kHAgl1AcswqRMZnML/ByOrPoA8Y6bajNXUIQ6B5xvisYZ+bd+6llRR0+ g/8PSvGnxScf/FSsXw== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.129] ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MryXN-1rn9e71rzZ-00nxZL; Fri, 10 Nov 2023 11:21:42 +0100 Message-ID: Date: Fri, 10 Nov 2023 11:21:41 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/9] staging: vc04_services: Do not pass NULL to vchiq_log_error() To: Umang Jain , Laurent Pinchart Cc: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Phil Elwell , Dave Stevenson References: <20231107095156.365492-1-umang.jain@ideasonboard.com> <20231107095156.365492-6-umang.jain@ideasonboard.com> <20231107122551.GA3051@pendragon.ideasonboard.com> <20231107123627.GB3051@pendragon.ideasonboard.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: <20231107123627.GB3051@pendragon.ideasonboard.com> X-Provags-ID: V03:K1:yeYVJSxIyCHzHks/8URM3J2LlpTNzRU1rKdr9itN57hIV5jnkfb tRHeL1geL+ZByl9Q5dvug6Lcf6IcCzFGX/odVAy5VdXhlnUoNh6iOtbAwg2HKSwpvXJ92WV 8FEO8AOeGekSXEuqSJ06Eux6LQsEIYZtAmb2jwz+y1mtimbSEfqropPDv+EuFAPaCK3f24V OpeUb7JHPj4HarQ/C0mSg== UI-OutboundReport: notjunk:1;M01:P0:YYWisDYw8xM=;hpFPDn/U9t8bI9F/lSJsdl6yvku +flBFMDOajNqb0nd8swkU9rFelaywO5q+o1NMxfgjrUlzfobLBKbVW9dBDS4IYZ6G3kHKKRfI bIwwwSajMn5L39yW8N51rhz5J76tzdEif/luJsA5xtqwyTY079YNawaHQPs9D80Nify95uAPo 6niYudsKSpCxvHqYKNO22dbZqMPzj0lNXEqt1YSMFe9AtLlDn5M07OfjMphpP6PeXfx9hVMXU P40i5DO9aZitN65PcdkI7yqtfSiwZ9V0UiZvPZuvwU0U2u+oDndarAD/cAzGmqcY2PYn7G/bW wMeC7WgrYr14Zs/prv5PUMqTPz+hH1hF8mCIgry4Px3D4ucAX2NeuCkoy0/RmLs2ij1SAtIfQ 9BMUlgkKWRkGSiQkg4K3ozEVsIhpTEzSZq9zhRWwIYinIFnkDReaeFD3BsN7KqjY34U+Y0yW9 6iT50KeTIxJY+AweQbUKJEktHpygNtKJ2N6zRFLhC+MgwkjNgNgASLA8tro9dwCW5ReGFHbTT ANm40bO3sQXSMTf3JYMeP/Foez85PT8pW6FzS2vdIGGvUzKuJ3qBycbxF2bat4lqbfrS2A9c9 sS4Ho8sbnyXs2R05OepZRZZxMoYmTcWhbWnZaRKvRkTAgd+nIBs9IJ6V7uuPpnTrClZufw3UU 2N9JLtqMIDFqzWMV8OmBa9TftcT4yxekQR8EyTDRutnZY56MFVUVJ6qPvXU0juWfK+dwxUmFN bOJyeQt1PDECthW67xUCVJs1IGK+Dv8vusJxlS4S2D7kSwnq+WPNk+fCcIMF6UvLDZov4ifGl 6oQxPoqeweOcYgPHBA4nOV3xKujptcWbMTt/Xn++RBiM1VfXnzqWt93gCzZfZrZpFEWyjwgOJ hZmRYyNQa1iH6Or4+x+D5CDxZvJfIIh9uMVYdwiGP/mWjmZLtMxdiATzJw/o0XvusYQ9wrxTw zbtIHQ== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_022150_259944_F90403D9 X-CRM114-Status: GOOD ( 23.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Umang, Am 07.11.23 um 13:36 schrieb Laurent Pinchart: > On Tue, Nov 07, 2023 at 02:25:52PM +0200, Laurent Pinchart wrote: >> On Tue, Nov 07, 2023 at 04:51:52AM -0500, Umang Jain wrote: >>> vchiq_add_connected_callback() logs using vchiq_log_error() macro, >>> but passes NULL instead of a struct device pointer. Fix it. >>> >>> vchiq_add_connected_callback() is not used anywhere in the vc04_services >>> as of now. It will be used when we add new drivers(VC shared memory and >>> bcm2835-isp), hence it kept as it is for now. >>> >>> Fixes: 1d8915cf8899 ("staging: vc04: Convert vchiq_log_error() to use dynamic debug") >>> Signed-off-by: Umang Jain >>> --- >>> .../vc04_services/interface/vchiq_arm/vchiq_connected.c | 4 ++-- >>> .../vc04_services/interface/vchiq_arm/vchiq_connected.h | 4 +++- >>> 2 files changed, 5 insertions(+), 3 deletions(-) >>> >>> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c >>> index b3928bd8c9c6..21f9fa1a1713 100644 >>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c >>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.c >>> @@ -27,7 +27,7 @@ static void connected_init(void) >>> * be made immediately, otherwise it will be deferred until >>> * vchiq_call_connected_callbacks is called. >>> */ >>> -void vchiq_add_connected_callback(void (*callback)(void)) >>> +void vchiq_add_connected_callback(struct vchiq_device *device, void (*callback)(void)) >> >> You're changing the prototype of the function, but the patch doesn't >> update any user. If the function is unused, it looks like you can drop >> it instead. Looking at the rest of the vchiq_connected.c file, I think >> you can actually drop the whole file. > > Except that the vc-sm-cma driver will use it. I'm curious though, that > driver will have no way to acquire a pointer to a vchiq_device, so I > don't see how this will be usable. pr_err() may be a better pick here. in case there is currently no user, but vc-sm-cma will be then i'm convinced that moving this driver into staging before vchiq is out is a good idea. AFAIK your main goal is to get bcm2835-isp into mainline, so it would be faster to have it in staging, so everyone could fix the style issues. My initial concern about importing new drivers was that after moving it into staging nobody wants to finish the job. But currently i've a good feeling that vchiq is on a good way. Best regards > >>> { >>> connected_init(); >>> >>> @@ -39,7 +39,7 @@ void vchiq_add_connected_callback(void (*callback)(void)) >>> callback(); >>> } else { >>> if (g_num_deferred_callbacks >= MAX_CALLBACKS) { >>> - vchiq_log_error(NULL, VCHIQ_CORE, >>> + vchiq_log_error(&device->dev, VCHIQ_CORE, >>> "There already %d callback registered - please increase MAX_CALLBACKS", >>> g_num_deferred_callbacks); >>> } else { >>> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h >>> index 4caf5e30099d..e4ed56446f8a 100644 >>> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h >>> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_connected.h >>> @@ -1,10 +1,12 @@ >>> /* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */ >>> /* Copyright (c) 2010-2012 Broadcom. All rights reserved. */ >>> >>> +#include "vchiq_bus.h" >>> + >>> #ifndef VCHIQ_CONNECTED_H >>> #define VCHIQ_CONNECTED_H >>> >>> -void vchiq_add_connected_callback(void (*callback)(void)); >>> +void vchiq_add_connected_callback(struct vchiq_device *device, void (*callback)(void)); >>> void vchiq_call_connected_callbacks(void); >>> >>> #endif /* VCHIQ_CONNECTED_H */ > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel