Re: [PATCH 0/2] Add vcp driver

[Krzysztof Kozlowski <krzk@kernel.org>]

On 06/04/2025 10:05, Xiangzhi Tang (唐相志) wrote:
> On Wed, 2025-04-02 at 12:31 +0200, Krzysztof Kozlowski wrote:
>> External email : Please do not click links or open attachments until
>> you have verified the sender or the content.
>>
>>
>> On 02/04/2025 11:19, Xiangzhi Tang wrote:
>>> Add support MediaTek's Video Companion Processor(VCP) host driver
>>> to
>>> control the MediaTek VCP Risc-V coprocessor.
>>> The VCP host driver using rproc mechanism to load vcm firmware
>>> from filesystem, and using SMC services to request ATF to setting
>>> vcp boot sequence, and Host communicated with VCP FW depends on VCP
>>> IPC interfaces
>>>
>>> This series patches dependent on:
>>> [1]
>>>
> https://lore.kernel.org/all/20250307032942.10447-1-guangjie.song@mediatek.com/
>>
>> They should not depend. It blocks your patch. I suggest decoupling
>> from
>> dependencies.
>> I run test "make dt_binding_check
> DT_SCHEMA_FILES=Documentation/devicetree/bindings/remoteproc/mediatek,m
> t8196-vcp.yaml", And, I have to cherry-pick first "
> 

How is this related? Did you read my message? You should not depend and
you answer "I added dependency". Great, so your patch won't get accepted
and won't get tested. Lack of testing will result in lack of review.


Best regards,
Krzysztof