From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5A3C7C52D6F for ; Tue, 27 Aug 2024 08:29:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=VwBFZ+aIXeWT7gdWxFkQlsDLmw4Uh9N2NqhVyqhD1WY=; b=lfZu7nw/1D2xzCng9Fg7/qTdUE iEoCzlv0gys0c5W3uyMwoizNvXBBj5trXpAXYbGwDunRv5D+f3R1ADxA9/V1N61JECmRJMjz/azeK DM9+lEIVCsYQMP8F3MGd1gY94WcOQU8DlQeqhFg0zeDiAq0javWX4oM3t+2uTG+u70ZU6FUrrGvCP DRmYlAS2nHK+seS9ILmdyFScqNz4IJC4smfMO4IKRtNyHDqK8rgql76LefRot8984R5GlvqxMBb4p wkkwnciMBG6hkWvbwOcmCR+9Oe5bSdWPl/Llifroeho7jFAUUfOiBp75cD30pyKEKQ8mfaHVnB2ej jE8ij62A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sirZI-0000000AOtF-0JgW; Tue, 27 Aug 2024 08:28:48 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sirYT-0000000AOfI-1cXk for linux-arm-kernel@lists.infradead.org; Tue, 27 Aug 2024 08:27:59 +0000 Received: by mail-ed1-x529.google.com with SMTP id 4fb4d7f45d1cf-5bed83488b3so6053118a12.0 for ; Tue, 27 Aug 2024 01:27:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1724747275; x=1725352075; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VwBFZ+aIXeWT7gdWxFkQlsDLmw4Uh9N2NqhVyqhD1WY=; b=zwgnYptQG1smKelzu/VQpdim+T4EqF5oj8yvKE7KvrKByVCQC7t0FW1DOQ6/NMex5j LJwiz2uOKGPxit9tqR0pe/uVPGYhdyBtNFhVw3m7Q0/fN/mTetUFJMiBo9R3Kdypz6Mc 7+iS+TIS6w4Af5w7ObtXmLUtmQ5TU1t1606Xe7RJmIegCShOIKL9Qdeyzrj3ve7RXcwr WtsugHvX6YsaaVYouXLvnYQ1V11co08eaRO9UlrEv0hDDP3XWAo9Whens0oOxCGk+cvF 7ZWZ+FRsSPAo5/UVMNSE9bmc2dc6cEru11GIrfsssV12BQoQtnDobPwJKAInCxCp6VhQ S74Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724747275; x=1725352075; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VwBFZ+aIXeWT7gdWxFkQlsDLmw4Uh9N2NqhVyqhD1WY=; b=IMlwD8pUBJSdCHlB1TnxzmNAXz+7I6VlSjhY+Xq7Utgo+SPoJ67tlDSt4ziQhYBSKM byclD34/kC8JlWt+ko9Tcm1rrgudLC7UyM/h/fDafk337UbcQRbrH80X7nqa1JcTpUZn b/NCoyVYeNusn8FTfZ9Lt8WNY4MlfNFdJuMa0AVnuUEWk65Tah9Olf9o7TOtIJWTG6xK XHrJ4iUvBqJz/1XQYdCC2NJ9X0fbVPelO73g0pHR+tin33QC/6sZw5mRaS9ZOgiDqegJ uXfbetZoGCauVHqro4RWFokv+WgxzPoLYkKFySn5uppHoRPYkismhiI0d4godG5Etxv7 saHA== X-Forwarded-Encrypted: i=1; AJvYcCVn9NaL0CqRWQqJtNafexgW+/Xig+ex5W43HLu7vxj80whEPr/TXw92sHInwKJxiNR5VhGy/BR6HZ1uQDfGRjpy@lists.infradead.org X-Gm-Message-State: AOJu0YwaJDU8gT3ukKVqo3AXZP4YlFeqAxz+Tki+Wobh/URhdMTJKOtI qqyzqyB/eWf1bf0rNKs+Vh/F8G+ghk8i96v3EcOkFBmmLs3CEMltv7Vm0maX3nA= X-Google-Smtp-Source: AGHT+IGoytf/csiM7P+oT51XLKCJCIoyP5CWG+PH3sD80bM3KlZXHkavP3BVjH98KYSXriq2GD3wpw== X-Received: by 2002:a05:6402:524e:b0:5be:fc0b:9a6a with SMTP id 4fb4d7f45d1cf-5c0891aba58mr8008738a12.32.1724747274856; Tue, 27 Aug 2024 01:27:54 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c0bb4829ccsm720941a12.95.2024.08.27.01.27.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Aug 2024 01:27:54 -0700 (PDT) Date: Tue, 27 Aug 2024 11:27:48 +0300 From: Dan Carpenter To: Maxime Chevallier Cc: Pengfei Xu , davem@davemloft.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com, Andrew Lunn , Jakub Kicinski , Eric Dumazet , Paolo Abeni , Russell King , linux-arm-kernel@lists.infradead.org, Christophe Leroy , Herve Codina , Florian Fainelli , Heiner Kallweit , Vladimir Oltean , =?iso-8859-1?Q?K=F6ry?= Maincent , Jesse Brandeburg , Marek =?iso-8859-1?Q?Beh=FAn?= , Piergiorgio Beruto , Oleksij Rempel , =?iso-8859-1?Q?Nicol=F2?= Veronese , Simon Horman , mwojtas@chromium.org, Nathan Chancellor , Antoine Tenart , Marc Kleine-Budde , Romain Gantois Subject: Re: [PATCH net-next v17 11/14] net: ethtool: cable-test: Target the command to the requested PHY Message-ID: References: <20240709063039.2909536-1-maxime.chevallier@bootlin.com> <20240709063039.2909536-12-maxime.chevallier@bootlin.com> <20240827073359.5d47c077@fedora-3.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240827073359.5d47c077@fedora-3.home> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240827_012757_609454_936A84E3 X-CRM114-Status: GOOD ( 14.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 27, 2024 at 07:33:59AM +0200, Maxime Chevallier wrote: > > This issue has indeed been detected, and is being addressed, see : > > https://lore.kernel.org/netdev/20240826134656.94892-1-djahchankoike@gmail.com/ > There is a similar bug in ethnl_act_cable_test_tdr() that needs to be fixed as well. net/ethtool/cabletest.c 307 int ethnl_act_cable_test_tdr(struct sk_buff *skb, struct genl_info *info) 308 { 309 struct ethnl_req_info req_info = {}; 310 const struct ethtool_phy_ops *ops; 311 struct nlattr **tb = info->attrs; 312 struct phy_device *phydev; 313 struct phy_tdr_config cfg; 314 struct net_device *dev; 315 int ret; 316 317 ret = ethnl_parse_header_dev_get(&req_info, 318 tb[ETHTOOL_A_CABLE_TEST_TDR_HEADER], 319 genl_info_net(info), info->extack, 320 true); 321 if (ret < 0) 322 return ret; 323 324 dev = req_info.dev; 325 326 ret = ethnl_act_cable_test_tdr_cfg(tb[ETHTOOL_A_CABLE_TEST_TDR_CFG], 327 info, &cfg); 328 if (ret) 329 goto out_dev_put; 330 331 rtnl_lock(); ^^^^^^^^^^^^ 332 phydev = ethnl_req_get_phydev(&req_info, 333 tb[ETHTOOL_A_CABLE_TEST_TDR_HEADER], 334 info->extack); 335 if (!IS_ERR_OR_NULL(phydev)) { ^ This test is reversed so it will lead to a crash. Could you add some comments to ethnl_req_get_phydev() what the NULL return means vs the error pointers? I figured it out because the callers have comments but it should be next to ethnl_req_get_phydev() as well. 336 ret = -EOPNOTSUPP; 337 goto out_dev_put; 338 } 339 340 ops = ethtool_phy_ops; 341 if (!ops || !ops->start_cable_test_tdr) { 342 ret = -EOPNOTSUPP; 343 goto out_rtnl; 344 } 345 346 ret = ethnl_ops_begin(dev); 347 if (ret < 0) 348 goto out_rtnl; 349 350 ret = ops->start_cable_test_tdr(phydev, info->extack, &cfg); 351 352 ethnl_ops_complete(dev); 353 354 if (!ret) 355 ethnl_cable_test_started(phydev, 356 ETHTOOL_MSG_CABLE_TEST_TDR_NTF); 357 358 out_rtnl: 359 rtnl_unlock(); 360 out_dev_put: 361 ethnl_parse_header_dev_put(&req_info); 362 return ret; 363 } regards, dan carpenter