From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39726C433DB for ; Mon, 18 Jan 2021 01:20:53 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC916207AE for ; Mon, 18 Jan 2021 01:20:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC916207AE Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FQQ6o4wLFiyFwURT+lEuQ2rs44ZTanobZH/BAo+dxgc=; b=cKavimzQlWI44gleOkoGxpDly yhpqvyvyxQRqPvTF8+7wwwI/dI3cwHudqnD+hwv8IUw/BPELZhfla6Y5m3s4uIidjtiXoeJq67DFI RgtxjptdNncOD0GtR9P8J2xadoVZIrMHQmN0F83yOmuSDY+jb+ivDoU3tYNLSePD3OxD0zNvIqc4S O1WyoCZZGiCjDJiS/JuYvHAmoZw1nY0c2RIqqwuX3NJAtGkzncWU5WgSssc9IAnZlYqW+9G4VxFGs Wv2cPFpUXITA5vN9LnnjdtJPlNqR6Rth3NrHwBBfms9GNKSy7UBc/2Ch60cqAv5mQn9LWAbmK4F2R FfNe0Jo9g==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1JCT-0000o9-63; Mon, 18 Jan 2021 01:19:21 +0000 Received: from szxga05-in.huawei.com ([45.249.212.191]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1l1JCO-0000mF-ML for linux-arm-kernel@lists.infradead.org; Mon, 18 Jan 2021 01:19:19 +0000 Received: from DGGEMS405-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4DJv6X6JWVzj3w7; Mon, 18 Jan 2021 09:17:56 +0800 (CST) Received: from [10.174.184.42] (10.174.184.42) by DGGEMS405-HUB.china.huawei.com (10.3.19.205) with Microsoft SMTP Server id 14.3.498.0; Mon, 18 Jan 2021 09:18:52 +0800 Subject: Re: [PATCH] kvm: arm64: Properly align the end address of table walk To: Will Deacon References: <20210115095307.12912-1-zhukeqian1@huawei.com> <20210115102334.GA14167@willie-the-truck> From: Keqian Zhu Message-ID: Date: Mon, 18 Jan 2021 09:18:51 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20210115102334.GA14167@willie-the-truck> X-Originating-IP: [10.174.184.42] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210117_201918_162861_682BFB4D X-CRM114-Status: GOOD ( 17.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , jiangkunkun@huawei.com, Andrew Morton , kvm@vger.kernel.org, Suzuki K Poulose , Catalin Marinas , Joerg Roedel , Daniel Lezcano , linux-kernel@vger.kernel.org, Alexios Zavras , James Morse , Julien Thierry , Marc Zyngier , wanghaibin.wang@huawei.com, Thomas Gleixner , Robin Murphy , kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021/1/15 18:23, Will Deacon wrote: > On Fri, Jan 15, 2021 at 05:53:07PM +0800, Keqian Zhu wrote: >> When align the end address, ought to use its original value. >> >> Fixes: b1e57de62cfb ("KVM: arm64: Add stand-alone page-table walker infrastructure") >> Signed-off-by: Keqian Zhu >> --- >> arch/arm64/kvm/hyp/pgtable.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c >> index bdf8e55ed308..670b0ef12440 100644 >> --- a/arch/arm64/kvm/hyp/pgtable.c >> +++ b/arch/arm64/kvm/hyp/pgtable.c >> @@ -296,7 +296,7 @@ int kvm_pgtable_walk(struct kvm_pgtable *pgt, u64 addr, u64 size, >> struct kvm_pgtable_walk_data walk_data = { >> .pgt = pgt, >> .addr = ALIGN_DOWN(addr, PAGE_SIZE), >> - .end = PAGE_ALIGN(walk_data.addr + size), >> + .end = PAGE_ALIGN(addr + size), >> .walker = walker, > > Hmm, this is a change in behaviour, no (consider the case where both 'addr' > and 'size' are misaligned)? The current code is consistent with the > kerneldoc in asm/kvm_pgtable.h, so I don't see the motivation to change it. > > Did you hit a bug somewhere? > > Will > . > Not hit a bug, I just read the code to implement a new idea of stage2 DBM support [1]. Yes, according to doc, this is not an issue ("The offset of @addr within a page is ignored."). Sorry to disturb ;-). [1] https://lore.kernel.org/kvmarm/fd26654b-8258-061c-2a69-90b961c1c71b@huawei.com/ Thanks, Keqian _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel