From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DDB9EC3ABC7 for ; Mon, 16 Sep 2024 03:06:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:MIME-Version: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Date:Cc:To:From :Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=b4aPzdKJ99+8nbf9/pwFtWuXuCfyXaWcetBCqR9CkIg=; b=U2AGro27c25BYww+raZFOYJZtl QNkjyzAqQUg1UijPczQijPSeCjxFSUKwZajy8rPnNZNQ26w2ZC0Gx4NTudD/C5eDmFluLV9gVk3U6 YfH0lnOr3OgX0IESAOX/Pz8bdMM4AVMXpHonYoFIbGcJ7vly0At3NthOcEmWEX13PK23D1GVqHnyC GuaOTH4XxXggTB9a+eCeQoe+Cvy/P7Yi9xqVU6PsZ6WXwlHLJqE/Cyd+7qoOTGHhV5ZAHF/ch6hU+ wBHa4vOa56WRHWKjD+p+dZkluqFs09D08BOrx9uw272Z8k5vzwpeWjsbwYcSxjIa3pr13eLPnPCfK kd56DMvg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1sq24Q-00000002ytN-3VY0; Mon, 16 Sep 2024 03:06:34 +0000 Received: from pi.codeconstruct.com.au ([203.29.241.158] helo=codeconstruct.com.au) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1sq23K-00000002yoc-1Fvn for linux-arm-kernel@lists.infradead.org; Mon, 16 Sep 2024 03:05:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=codeconstruct.com.au; s=2022a; t=1726455924; bh=b4aPzdKJ99+8nbf9/pwFtWuXuCfyXaWcetBCqR9CkIg=; h=Subject:From:To:Cc:Date:In-Reply-To:References; b=XIB5v7pqm0HLKI8xDjUR88PYDtxQHFhQ2cI+x8sfAHyoEs+wmShl9smp93Fg8SMa3 dH5/LtmaCPJBZEav8qJdbXp5mYFKTHdN7kpD4e8glJ9rgqEX5+s8J2FtBDbvkfA0EL ygaOavTjBoPJ9TfgYPOHtjvjJyE9P64rQsasm3cx8JmZpZfP/mlqKMCSHTff3P0zc9 u3VmWd6eq10HQnT03Loh0fWaAy9KCHsXP8eGCVzlZn1SNNWDiLizAnOOWdKjix3kF1 Ofr0lXHp6iwIPweLJBZwLiKW3CaGFy9erBWUMMqnJPlfh5uLMctamH3FlkWtygMuQL oQf42QZSua8aA== Received: from [192.168.68.112] (ppp118-210-161-36.adl-adc-lon-bras34.tpg.internode.on.net [118.210.161.36]) by mail.codeconstruct.com.au (Postfix) with ESMTPSA id 0399B65027; Mon, 16 Sep 2024 11:05:22 +0800 (AWST) Message-ID: Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca9506 for CPLD IOE From: Andrew Jeffery To: Delphine_CC_Chiu/WYHQ/Wiwynn , "patrick@stwcx.xyz" , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Joel Stanley Cc: Ricky CX Wu , "devicetree@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-aspeed@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" Date: Mon, 16 Sep 2024 12:35:22 +0930 In-Reply-To: References: <20240910054751.2943217-1-Delphine_CC_Chiu@wiwynn.com> <20240910054751.2943217-3-Delphine_CC_Chiu@wiwynn.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.46.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240915_200526_581150_61AB5584 X-CRM114-Status: GOOD ( 27.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2024-09-13 at 03:26 +0000, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: >=20 > > -----Original Message----- > > From: Delphine_CC_Chiu/WYHQ/Wiwynn > > Sent: Friday, September 13, 2024 10:08 AM > > To: Andrew Jeffery ; > > Delphine_CC_Chiu/WYHQ/Wiwynn ; > > patrick@stwcx.xyz; Rob Herring ; Krzysztof Kozlowski > > ; Conor Dooley ; Joel Stanley > > > > Cc: Ricky CX Wu ; > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > > Subject: RE: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio pca95= 06 > > for CPLD IOE > >=20 > >=20 > >=20 > > > -----Original Message----- > > > From: Andrew Jeffery > > > Sent: Thursday, September 12, 2024 10:11 AM > > > To: Delphine_CC_Chiu/WYHQ/Wiwynn ; > > > patrick@stwcx.xyz; Rob Herring ; Krzysztof Kozlowski > > > ; Conor Dooley ; Joel Stanle= y > > > > > > Cc: Ricky CX Wu ; > > > devicetree@vger.kernel.org; linux-arm-kernel@lists.infradead.org; > > > linux-aspeed@lists.ozlabs.org; linux-kernel@vger.kernel.org > > > Subject: Re: [PATCH v1 2/2] ARM: dts: aspeed: yosemite4: Add gpio > > > pca9506 for CPLD IOE > > >=20 > > > [External Sender] > > >=20 > > > [External Sender] > > >=20 > > > On Tue, 2024-09-10 at 13:47 +0800, Delphine CC Chiu wrote: > > > > From: Ricky CX Wu > > > >=20 > > > > We use CPLD to emulate gpio pca9506 I/O expander on each server > > > > boards. > > > > Therefore, add pca9506 to probe driver for the CPLD I/O expander. > > >=20 > > > I think it might be best if you add your own compatible to the list i= n > > > the gpio-pca95xx binding just in case there are some behavioural > > > quirks of your CPLD implementation? Not sure if this should be > > > "facebook,pca9506" or "wywinn,pca9506", but assuming facebook, from > > > there you can specify > > >=20 > > > compatible =3D "facebook,pca9506", "nxp,pca9506"; > > >=20 > > > This allows you to add the quirks to the driver as required in the > > > future through the more-specific compatible. > > >=20 > > > Andrew > >=20 > > Hi Andrew, > >=20 > > Thanks for the review. > > I'll add the "facebook,pca9506" in gpio-pca95xx binding in next version= of > > patches. >=20 > Hi Andrew, >=20 > I tried to add "facebook,pca9506" in the compatible list of gpio-pca95xx = binding > and add compatible =3D "facebook,pca9506", "nxp,pca9506" but got followin= g failed > messages: > gpio@21: compatible: 'oneOf' conditional failed, one must be fixed: > ['facebook,pca9506', 'nxp,pca9506'] is too long > 'diodes,pi4ioe5v6534q' was expected > 'nxp,pcal6534' was expected > from schema $id: http://devicetree.org/schemas/gpio/gpio-pca95xx.= yaml# > Would like to ask do you have any suggestions? Thanks. Mmm, maybe it's best if we leave the compatible as just 'nxp,pca9506' for now, but if you do discover quirks then we can consider this again. Andrew