From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0921CC4360F for ; Tue, 2 Apr 2019 17:57:48 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CE4812070B for ; Tue, 2 Apr 2019 17:57:45 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="YcVKePZv"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="OSP/mj/Q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CE4812070B Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=APvfLMyhsKH528giJblvXleDTeMlND5g0Q+sw4OoJQw=; b=YcVKePZvI8Obvp OmIHRqDJuQremJQm1WYT6lCQbhqWaLDzwY8LXCE5M6FfrlbB2mQDC7a2n4LdCAC1yWsYcWAWQz96e /WHbEJJCeNsXlrS9/OKs3X75tEoN2vP7EOVQgPpRUhTBN9BYPinhMgXSpB5OzCBClr16JDPiHfpVT Rv15iHgighVya1ooyaTKQvNuEl6q9UBAc9p5rwUaAC71e0lx66geBM+JfNNmr9yy6X64JtAXt28kA J9P0GhdRLN1TeIk5cA4LpStcXggA+GK0QOFq0eU/+Iu8EVEeCbE/gj3qGbo2ZlvSnU/rYKjEaesiR k5NijGn329AQSiO+20hg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBNfK-0001dV-Ux; Tue, 02 Apr 2019 17:57:42 +0000 Received: from mail-yb1-xb41.google.com ([2607:f8b0:4864:20::b41]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hBNfI-0001d4-32 for linux-arm-kernel@lists.infradead.org; Tue, 02 Apr 2019 17:57:41 +0000 Received: by mail-yb1-xb41.google.com with SMTP id g12so3023193ybh.7 for ; Tue, 02 Apr 2019 10:57:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=2d9K9JUUlUqo7KV2H4/IAzjMAbwM+ocor4KxdYwAt1E=; b=OSP/mj/Q43obVdXvQ57TjzVvFutjUvARj/fwj7KwQbAGYyhMFLmt+xaCFRQ2gFX5wH UolTLDXM2nO1GNy0xLGQvjSqBfxb1glIYRzt//1E+1EpDhqDFPhMpRlyHYQxJOMNgMDu ceXfkzEkoJp16tAo59KKj/qtDNvKX55VkTRC4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=2d9K9JUUlUqo7KV2H4/IAzjMAbwM+ocor4KxdYwAt1E=; b=EKo4B4eiBT+HznKU1SAeGTTeJUTMyq3hfjSm5A4XJ74oq+qvOgRjqPnXmAl39vU3Cb UFyEVDxNGPcPfPmFLIDClnTXjbnZ6uB/1IfKrfKiIrJ9bjzpUrB6m6J00x5Eg5MG2Lj6 nDxTZMLAjmDSghyKC2J8Y53siGvA9tegdHIT55ZNemaIX3pkr+ZS5fwagxbG8u6V1XtI whFVRhizZ7X+F4vjBKYKkBPKl942/hHENR1MOgn2UA53F8hqZaU3tnWld0jD/nfQZN4D H3mrLBwHYdmcleVosPUap/09GbiTJDMLfi4BirKvh9ll6anog1FRi/mPHLEf6/5HIdJa LGcA== X-Gm-Message-State: APjAAAUbjXXUeLP1/WIjmpdf6y+qcOOby56k2C12IZOjue14x6qwsasy Syw8dKDXWDSaCewsOqGM08as6w== X-Google-Smtp-Source: APXvYqzJiMWjvkLIiSZO9C+i7oQS9V/YAY//eV4eWJhDinLcHwvY25ygiyVAQJ5RZA0V86V+Tydgjg== X-Received: by 2002:a25:9941:: with SMTP id n1mr58710999ybo.85.1554227857972; Tue, 02 Apr 2019 10:57:37 -0700 (PDT) Received: from [10.136.8.252] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id c206sm4681079ywc.71.2019.04.02.10.57.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 02 Apr 2019 10:57:36 -0700 (PDT) Subject: Re: [PATCH v5 7/8] i2c: iproc: add NIC I2C support To: Wolfram Sang References: <20190214175725.60462-1-ray.jui@broadcom.com> <20190214175725.60462-8-ray.jui@broadcom.com> <20190402102733.GD2960@kunai> From: Ray Jui Message-ID: Date: Tue, 2 Apr 2019 10:57:33 -0700 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190402102733.GD2960@kunai> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190402_105740_130108_EAF49A54 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rayagonda Kokatanur , linux-kernel@vger.kernel.org, Rob Herring , bcm-kernel-feedback-list@broadcom.com, linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 4/2/2019 3:27 AM, Wolfram Sang wrote: > >> +#define IDM_CTRL_DIRECT_OFFSET 0x00 > > And this IDM thing is also never used outside of the I2C context? In > other words, it also doesn't need a seperate DT node? > > That is correct. Only in the I2C context in our use case. >> + /* indicates no slave mode support */ >> + bool no_slave; > > I would suggest to not use a flag, but to nullify the {un}reg_slave > callbacks in probe depending on the type. That will also tell the > i2c-core that slave functionality is not supported. And you can use if > (!algo->reg_slave) as a flag, too. > Yes. Great idea. I'll make the change and remove reg_slave. >> + iproc_i2c->type = >> + (enum bcm_iproc_i2c_type) of_device_get_match_data(&pdev->dev); > > No need to cast a void*. > Yes will fix. Thanks, Ray _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel