From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B29E9CFD30C for ; Fri, 11 Oct 2024 10:11:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=eoav9wkO+mIe4PV1rHGpqtvnpQN84eRE/FQ5B02sO7M=; b=JulKGQuL35UUJPKihOasiz/SPa kXhCB6Nb2sOMEIn6QwmZBA9ZlFL8fbR5nPjq1TWj0TCt2HEfaZazuVLCPjOTePj6O5J58I6nqWZEs uwDHjw2Wafov5gz/51I0MATeqNECCV/2tlfex/6bcIx/i/kKbJqjMu9IUD9JKnbBiEMyzOV53kJ0F X+eibBUSzdHWTYA96k8qNFGAVu4567eWM4DQieN57yeBBIJr+Y/HPKiiNB2WPK+68wJod6TBuDFmF nRXUITF+FxoriqVUwbSk8bCKu4iPmMokjtgti4d1CBa8QzRmpkQFuJHQNXX1wqnpnljmCkTbpM3cz M6lTTfAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1szCbh-0000000FvF2-3B59; Fri, 11 Oct 2024 10:10:49 +0000 Received: from mout.gmx.net ([212.227.17.20]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1szCaH-0000000Fuu3-3wuf; Fri, 11 Oct 2024 10:09:23 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmx.net; s=s31663417; t=1728641337; x=1729246137; i=wahrenst@gmx.net; bh=eoav9wkO+mIe4PV1rHGpqtvnpQN84eRE/FQ5B02sO7M=; h=X-UI-Sender-Class:Message-ID:Date:MIME-Version:Subject:To:Cc: References:From:In-Reply-To:Content-Type: Content-Transfer-Encoding:cc:content-transfer-encoding: content-type:date:from:message-id:mime-version:reply-to:subject: to; b=L6KYr/HotO3ODVCzjyupk3DKZ61fWxCKb1v0bpnSZL1CZPvy7oe9/5ir3ZUEuDla VQWvdKwXXPGlxsM2fwdTM3iGQxt416F6V8/MAaLmqwgXIU8XSvWsowxdnKLoUU0GB CD/wcoOy6jmxP7i8LtTkXYXiaHWAZ2usivveAZyQkJXfWpDeyvNJcadue/eAGBvGV ZIHSGPCQUs35ugrNSKiuBVpGKkIWYNuF4h4YOadT+R0/mVIRlBScS5zZisVfeWdRt d63kF6CSHjBdYyXYTmB1BHgLObVmY8yD5i8bW3HJESGrZevaLuqOXoGxSotQ9ivzH 2roSznDPT2MecF+oPA== X-UI-Sender-Class: 724b4f7f-cbec-4199-ad4e-598c01a50d3a Received: from [192.168.1.104] ([37.4.248.43]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N4hzj-1u0UKl2nkF-015B3x; Fri, 11 Oct 2024 12:08:56 +0200 Message-ID: Date: Fri, 11 Oct 2024 12:08:52 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 09/14] pinctrl: rp1: Implement RaspberryPi RP1 gpio support To: Linus Walleij , Andrea della Porta Cc: Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Florian Fainelli , Broadcom internal kernel review list , Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Manivannan Sadhasivam , Bjorn Helgaas , Catalin Marinas , Will Deacon , Bartosz Golaszewski , Derek Kiernan , Dragan Cvetic , Arnd Bergmann , Greg Kroah-Hartman , Saravana Kannan , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-gpio@vger.kernel.org, Masahiro Yamada , Herve Codina , Luca Ceresoli , Thomas Petazzoni , Andrew Lunn References: <199a4994312b120c73c95fa368954ad5a2a8aee6.1728300190.git.andrea.porta@suse.com> Content-Language: en-US From: Stefan Wahren In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:LqY4jNXpUn/szfUlWjhhwIcxwRo5I0Rfv5kZ780LihSoEH5kZEs LBEXN1xvXO3oyM2VurBOq0JyQUCUOFbQy01ZamLt5KFsS3mw08WU1N8sDv11Pmmucpg2KuM mTFNN1/unuc2aK9/oBJXjQGszv4sUl2x3P9K1Qe72TdIv3JxoYwlOMlkzFcJuYkKYtNMQ9C WExkC/oy7cXveyEvXEVWQ== UI-OutboundReport: notjunk:1;M01:P0:gfvBp+EhPSg=;Krp+Dt4+0xc0T3nyoXq1JLBXS+4 ssl7ep8XjwEVmqJfN1tBRWWWZWygUXl0AWATC2RYwQpwWy8uFZn2G8A1YS77SobXzuApkCH3T gAujAK/+hYi09B6UIUGrxadmCvoXHScVW8fD1EbKql9k4KdtL4QL9STqL8P2WRDb/GObmbna3 v0X4lbplDs53TY2opRzzoia/hisRmP90PlW0ACs/icw4vs8wCcO2TmrvHCtUpDbkk1q3j+XI6 /I6m9+q9CiVZERFsOmU/lOOa2nKmYP7XN59T893soEMqrDxmc6pI8onxeFyw2xUqJhGmgVgS7 56xC/OT5sE1nNh2O5/uFRYkPmsyKVQT935g4W3k4XY6a7PpWZH+W71JjWxPRrzLYuz5P/DlDr 0PM9tPFSQO6nLkSCi9YvIFdVKCKfT+kPTfFq4cP6LrCu7l4fVq1Ky6uHS4hpPAbVpkIZYlpG7 2rGZhYKVppBIDMQvcxeIV3wAD/A+66/A2IvW0XYfRc6GbBjwBmm28BTBVSZjVX/MPnohHyws7 Q3D7k+D+uI0opPMIHGy3fZsVQ8QkZ3vFV5sOWkqlx5u+gkLnUBWgZwKR0xVxzKi/ZOJXG4N57 PaJAzG7M/e0K9mqrAhQgaavITppLM/Fc9DoUzIwbB0cvpik/tc3qBYW8F9YHgfnZU/pM/4Lb1 OzFLFVtL/ITPMYrk3lJi9mAPR7jZlBwO5x+48aRf7JhiffhVwBEDOvKxLJT+L44kT5FOSiyzk aQggDfZtmYp244brhtEqY7L7zEiDqAKBQBNl9zyh/x1ZedjDMLmbnklzB8Mb9yTd5SjizUpaB xr4Mo6Y76DusHmA0f6y8DOKA== X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20241011_030922_302167_0C19E4CE X-CRM114-Status: GOOD ( 15.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am 11.10.24 um 11:03 schrieb Linus Walleij: > On Mon, Oct 7, 2024 at 2:39=E2=80=AFPM Andrea della Porta wrote: > >> The RP1 is an MFD supporting a gpio controller and /pinmux/pinctrl. >> Add minimum support for the gpio only portion. The driver is in >> pinctrl folder since upcoming patches will add the pinmux/pinctrl >> support where the gpio part can be seen as an addition. >> >> Signed-off-by: Andrea della Porta > This is a nice driver and I find no issues with it, what causes > an issue is gpiochip_set_names() as pointed out by Bartosz. > If you can live without the names you can remove that part for > now and we can merge the driver, then you can add the names > later when we sorted out how to share that function. I raised the concerns about missing gpio line names in the first version of patch, without knowing the real efforts. So I'm fine with Linus' suggestion, because I don't want to delay the upstreaming effort unnecessarily. Regards > > Yours, > Linus Walleij