From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Andre Przywara <andre.przywara@arm.com>,
Thomas Gleixner <tglx@linutronix.de>
Cc: Russell King <linux@armlinux.org.uk>,
Kefeng Wang <wangkefeng.wang@huawei.com>,
Zhen Lei <thunder.leizhen@huawei.com>,
Robin Murphy <robin.murphy@arm.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] clocksource/drivers/sp804: avoid error on multiple instances
Date: Mon, 9 May 2022 13:46:25 +0200 [thread overview]
Message-ID: <a1d44fbb-c2a9-e422-8ce8-2a3982a75bb8@linaro.org> (raw)
In-Reply-To: <20220506162522.3675399-1-andre.przywara@arm.com>
On 06/05/2022 18:25, Andre Przywara wrote:
> When a machine sports more than one SP804 timer instance, we only bring
> up the first one, since multiple timers of the same kind are not useful
> to Linux. As this is intentional behaviour, we should not return an
> error message, as we do today:
> ===============
> [ 0.000800] Failed to initialize '/bus@8000000/motherboard-bus@8000000/iofpga-bus@300000000/timer@120000': -22
> ===============
>
> Replace the -EINVAL return with a debug message and return 0 instead.
>
> Also we do not reach the init function anymore if the DT node is
> disabled (as this is now handled by OF_DECLARE), so remove the explicit
> check for that case.
>
> This fixes a long standing bogus error when booting ARM's fastmodels.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
Applied, thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-05-09 11:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-06 16:25 [PATCH v2] clocksource/drivers/sp804: avoid error on multiple instances Andre Przywara
2022-05-06 16:41 ` Robin Murphy
2022-05-09 11:46 ` Daniel Lezcano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1d44fbb-c2a9-e422-8ce8-2a3982a75bb8@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=andre.przywara@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=robin.murphy@arm.com \
--cc=tglx@linutronix.de \
--cc=thunder.leizhen@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox