From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 78CB2C433EF for ; Thu, 28 Apr 2022 07:14:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q7JWjlyDn2Vkgj3oQkWk55x42YTx8Xjdkj2ZKyYe7gw=; b=xkEIN+dSiB1LkO 83TBhxTJ8cEq6Fa9r1zdxhMdmhjC8u5Y5QjMv0ekJb65D4bd0DQtJw9si7FjJwDWShzv5lVV1PqCj GrVeEVfk0AhDYfZStWBgzVW5mOX1OIcduGvOKdlSlkWdqt7OWsFgTDz0a9aeM4Dp99W7hlJduEoVR wIOWC35S8/b2YQOKhzaoi8SI+KiC0yS8q8JAyfGm8nUnl2qShYP/QMBfJxwLWgN24g1DsfifGdVs7 suJeb0wcQbzs+gvIkLO5mVdkiNYQr2yE9oOJR5FZzpUS2L73JzkYZ0Fuk18WI9pcy12GHQIdmfPAJ 9nf0BzslK0Myx4MkU8og==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1njyLM-0055wq-Ak; Thu, 28 Apr 2022 07:13:40 +0000 Received: from mail-ej1-x631.google.com ([2a00:1450:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1njyLD-0055tT-Q1 for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 07:13:35 +0000 Received: by mail-ej1-x631.google.com with SMTP id y3so7653569ejo.12 for ; Thu, 28 Apr 2022 00:13:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=iGqqNXodCdUDh7H9P3dABdV87d92uw3GOCws81glz0A=; b=bZSDYZK3nZ8gNy0m2zOk1wfcaP/wBfAJTWrD4X7zoB+oJBYlWudyPmULtS1NYm4mxp 7HfiUBgkOKIwAzB4l4kApY3BoLGk/ZoyLxYc7OtY4Whi+KY/JkuV3ZOkSXu/28vUE/0D 3v/J3lI7c5WbaegYPuiWYmUX/pR/+IiERbtnl07Ek3QmqFEeA6DrJnzri8MhZzRsePQ2 NQII16PWfwWBGz9/z3Q5wfP/Ng2BvuX7NxP8ZzvtU+aQ4JFFPKB2A8eJR61JyS9BAr+B VWKOYXYjyzGazWswq8q7jjB6GWV27+/fCtbo+sGDf7xKX1cuHHekM1EQEMVSicse3rjh ywFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=iGqqNXodCdUDh7H9P3dABdV87d92uw3GOCws81glz0A=; b=3sLnsDdSkKvFYRdRsWu/GDBr1yazCQ704HOXWFAMp8PxH5sr7WEJxTTtEqxrbAB6eA C1snejVA0v+2sKibxmigpxaNPvVBEXHsRaxvdUMS/0nnH67S6furWIpiK8XftMAAC929 zbPCVS4nPZUqvuAXUqYbLCauHjQyllkUN2Uh2qjvRutjLYYd9IzC0vrOuPk2tiwcgBaW Inrm/DcP8hp7kDn59/rb7zHIntKLSqAQYD8xrZBjKFFKI30+QAIBAe+JA5M4EzWQUNp2 OEEsv7XSNB3W8OtizNFxfhOvpcK+FT5VhQ0jIgUAc0IC07Rc6LCyv5k9PAEIh8Q3lKHM iIgQ== X-Gm-Message-State: AOAM530BrnmGAo9VyiZQxfgDITIIgQpykWpjIX4/UPji9SZkbpdmwb7A VdoCepbSFJvF7bs/EAfSWKXe9Q== X-Google-Smtp-Source: ABdhPJzklgMRo6K6Lgff0kJeIZiKiKNlkH0bcxPoFqazCmfw8oQiB7HgE78X2TJm3gxs/k62MWTUpg== X-Received: by 2002:a17:907:e88:b0:6ef:bce9:ff6a with SMTP id ho8-20020a1709070e8800b006efbce9ff6amr32059892ejc.275.1651130007604; Thu, 28 Apr 2022 00:13:27 -0700 (PDT) Received: from [192.168.0.160] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id k26-20020a17090666da00b006ef79b595e9sm7946644ejp.80.2022.04.28.00.13.26 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 28 Apr 2022 00:13:26 -0700 (PDT) Message-ID: Date: Thu, 28 Apr 2022 09:13:25 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [RFC RFT PATCH v1 1/1] ARM: orion5x: convert D-Link DNS-323 to the Device Tree Content-Language: en-US To: Mauri Sandberg , soc@kernel.org, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org Cc: arnd@arndb.de, olof@lixom.net, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, andrew@lunn.ch, sebastian.hesselbarth@gmail.com References: <20220427162123.110458-1-maukka@ext.kapsi.fi> <20220427162123.110458-2-maukka@ext.kapsi.fi> From: Krzysztof Kozlowski In-Reply-To: <20220427162123.110458-2-maukka@ext.kapsi.fi> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_001331_911635_894C8545 X-CRM114-Status: GOOD ( 19.95 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 27/04/2022 18:21, Mauri Sandberg wrote: > Convert D-Link DNS-323 to use the device tree and remove associated > mach file. > Thank you for your patch. There is something to discuss/improve. > Signed-off-by: Mauri Sandberg > --- > arch/arm/boot/dts/Makefile | 3 + > arch/arm/boot/dts/orion5x-dlink-dns323.dtsi | 217 ++++++ > arch/arm/boot/dts/orion5x-dlink-dns323a1.dts | 59 ++ > arch/arm/boot/dts/orion5x-dlink-dns323b1.dts | 38 + > arch/arm/boot/dts/orion5x-dlink-dns323c1.dts | 80 ++ > arch/arm/mach-orion5x/Kconfig | 6 +- > arch/arm/mach-orion5x/Makefile | 2 +- > arch/arm/mach-orion5x/board-dns323.c | 118 +++ > arch/arm/mach-orion5x/board-dt.c | 3 + > arch/arm/mach-orion5x/common.h | 6 + > arch/arm/mach-orion5x/dns323-setup.c | 724 ------------------- > 11 files changed, 528 insertions(+), 728 deletions(-) > create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323.dtsi > create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323a1.dts > create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323b1.dts > create mode 100644 arch/arm/boot/dts/orion5x-dlink-dns323c1.dts > create mode 100644 arch/arm/mach-orion5x/board-dns323.c > delete mode 100644 arch/arm/mach-orion5x/dns323-setup.c DTS goes separately. > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index 7c16f8a2b738..c7c5c0b6c843 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -949,6 +949,9 @@ dtb-$(CONFIG_SOC_DRA7XX) += \ > dra71-evm.dtb \ > dra76-evm.dtb > dtb-$(CONFIG_ARCH_ORION5X) += \ > + orion5x-dlink-dns323a1.dtb \ > + orion5x-dlink-dns323b1.dtb \ > + orion5x-dlink-dns323c1.dtb \ > orion5x-kuroboxpro.dtb \ > orion5x-lacie-d2-network.dtb \ > orion5x-lacie-ethernet-disk-mini-v2.dtb \ > diff --git a/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi b/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi > new file mode 100644 > index 000000000000..2b033d37cbf8 > --- /dev/null > +++ b/arch/arm/boot/dts/orion5x-dlink-dns323.dtsi > @@ -0,0 +1,217 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Copyright (C) 2022 Mauri Sandberg > + * > + */ > + > +/ { > + model = "D-Link DNS-323"; > + compatible = "dlink,dns323", "marvell,orion5x"; > You need to also document the compatibles in bindings file for boards. It would be nice to convert Documentation/devicetree/bindings/arm/marvell/marvell,orion5x.txt to DT Schema (see armada-7k-8k.yaml for example), but it is not a requirement. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel