From: "Jason-JH Lin (林睿祥)" <Jason-JH.Lin@mediatek.com>
To: "angelogioacchino.delregno@collabora.com"
<angelogioacchino.delregno@collabora.com>,
"chunkuang.hu@kernel.org" <chunkuang.hu@kernel.org>
Cc: "linux-mediatek@lists.infradead.org"
<linux-mediatek@lists.infradead.org>,
"Singo Chang (張興國)" <Singo.Chang@mediatek.com>,
"Johnson Wang (王聖鑫)" <Johnson.Wang@mediatek.com>,
"Jason-ch Chen (陳建豪)" <Jason-ch.Chen@mediatek.com>,
"Shawn Sung (宋孝謙)" <Shawn.Sung@mediatek.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Nancy Lin (林欣螢)" <Nancy.Lin@mediatek.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
Project_Global_Chrome_Upstream_Group
<Project_Global_Chrome_Upstream_Group@mediatek.com>,
"Nathan Lu (呂東霖)" <Nathan.Lu@mediatek.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"matthias.bgg@gmail.com" <matthias.bgg@gmail.com>
Subject: Re: [PATCH v7 4/4] drm/mediatek: Add DSI support for mt8188 vdosys0
Date: Mon, 31 Jul 2023 16:08:43 +0000 [thread overview]
Message-ID: <a1ec3ad4c5714d9e75375decf272ec677c05a5e4.camel@mediatek.com> (raw)
In-Reply-To: <3dca39b3-b152-34e7-8959-78fe68e1a899@collabora.com>
Hi Angelo,
Thanks for the reviews.
On Fri, 2023-07-28 at 10:14 +0200, AngeloGioacchino Del Regno wrote:
> Il 27/07/23 18:41, Jason-JH.Lin ha scritto:
> > Add DSI as main display output for mt8188 vdosys0.
> >
>
> I would split this commit in two:
>
> 1. drm/mediatek: dsi: Support dynamic connector selection
> 2. drm/mediatek: Support DSI on MT8188 VDOSYS0
>
OK, I'll separate this commit like this.
Regards,
Jason-JH.Lin
> Where the first one sets up the mtk_dsi driver for .encoder_index(),
> and
> where the second one is a one-liner simply adding `{0,
> DDP_COMPONENT_DSI0},`
> to the MT8188 main routes array.
>
> The reason is that if you split it like that, whoever reads the
> commit history
> will immediately understand how to add dynamic connector selection to
> a MTK DRM
> driver, and how to perform the SoC-specific connection....
>
> Please!
>
> Thanks,
> Angelo
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2023-07-31 16:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 16:41 [PATCH v7 0/4] Add dynamic connector selection mechanism Jason-JH.Lin
2023-07-27 16:41 ` [PATCH v7 1/4] drm/mediatek: Add mmsys_dev_num to mt8188 vdosys0 driver data Jason-JH.Lin
2023-07-28 7:53 ` CK Hu (胡俊光)
2023-07-28 8:11 ` AngeloGioacchino Del Regno
2023-07-27 16:41 ` [PATCH v7 2/4] drm/mediatek: Fix using wrong drm private data to bind mediatek-drm Jason-JH.Lin
2023-07-28 8:03 ` CK Hu (胡俊光)
2023-07-28 8:11 ` AngeloGioacchino Del Regno
2023-07-28 8:47 ` Eugen Hristev
2023-07-31 8:21 ` Jason-JH Lin (林睿祥)
2023-07-31 8:32 ` Eugen Hristev
2023-08-02 7:05 ` Jason-JH Lin (林睿祥)
2023-07-27 16:41 ` [PATCH v7 3/4] drm/mediatek: Add ability to support dynamic connector selection Jason-JH.Lin
2023-07-28 8:11 ` AngeloGioacchino Del Regno
2023-07-31 9:37 ` Jason-JH Lin (林睿祥)
2023-07-28 9:56 ` CK Hu (胡俊光)
2023-07-31 10:08 ` Jason-JH Lin (林睿祥)
2023-07-31 10:27 ` CK Hu (胡俊光)
2023-07-31 6:37 ` CK Hu (胡俊光)
2023-08-02 5:59 ` Jason-JH Lin (林睿祥)
2023-07-27 16:41 ` [PATCH v7 4/4] drm/mediatek: Add DSI support for mt8188 vdosys0 Jason-JH.Lin
2023-07-28 8:14 ` AngeloGioacchino Del Regno
2023-07-31 16:08 ` Jason-JH Lin (林睿祥) [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a1ec3ad4c5714d9e75375decf272ec677c05a5e4.camel@mediatek.com \
--to=jason-jh.lin@mediatek.com \
--cc=Jason-ch.Chen@mediatek.com \
--cc=Johnson.Wang@mediatek.com \
--cc=Nancy.Lin@mediatek.com \
--cc=Nathan.Lu@mediatek.com \
--cc=Project_Global_Chrome_Upstream_Group@mediatek.com \
--cc=Shawn.Sung@mediatek.com \
--cc=Singo.Chang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).