From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6918C433F5 for ; Mon, 25 Oct 2021 11:16:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 997D260EDF for ; Mon, 25 Oct 2021 11:16:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 997D260EDF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=/eyr7z4c2QIj5qtXYkbsnw0teV5u9ZVYfxVV3ZxB9Cc=; b=QOXr4nAB4gt1FZo7MPEaa2/O0o BTNJWqvjMVgypm2XmL5kxo5jC3EmfTLTIoAsj5vUVfFVb5Z1hBWxvXdHIAakAK21L9NLMbJp91h+w wf3OqVqI5JIMdz+WHVKfO/pl9WWEyXLCqzCgFW6B5Y4TWokWEOgTFiD8lXG0Vze9RL2nYCYhe9aAk uV4SaERkp/7w3r2aUCm/rKwoeSAj0WTMUnMICzZ6kntJuu7aDWOczj1tRPjoQDVMRfirTbMr5Jmks P1Fxlb7UpS345N3lzhKZfgIZwQgNBNBV43GDdJ8Df33JGekdS8js5Pjdiwt5XZVmj1Yx1d6lDusig ESptK3OA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mexwd-00GEv3-Nq; Mon, 25 Oct 2021 11:15:11 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mexwZ-00GEu9-Gt for linux-arm-kernel@lists.infradead.org; Mon, 25 Oct 2021 11:15:08 +0000 Received: from disco-boy.misterjones.org (disco-boy.misterjones.org [51.254.78.96]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1017C60238; Mon, 25 Oct 2021 11:15:07 +0000 (UTC) Received: from disco-boy.misterjones.org ([51.254.78.96] helo=www.loen.fr) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1mexwW-001LU4-U6; Mon, 25 Oct 2021 12:15:04 +0100 MIME-Version: 1.0 Date: Mon, 25 Oct 2021 12:15:04 +0100 From: Marc Zyngier To: Mark Rutland , Brad Larson Cc: linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 11/11] arm64: dts: Add Pensando Elba SoC support In-Reply-To: <20211025091731.GA2001@C02TD0UTHF1T.local> References: <20211025015156.33133-1-brad@pensando.io> <20211025015156.33133-12-brad@pensando.io> <20211025091731.GA2001@C02TD0UTHF1T.local> User-Agent: Roundcube Webmail/1.4.11 Message-ID: X-Sender: maz@kernel.org X-SA-Exim-Connect-IP: 51.254.78.96 X-SA-Exim-Rcpt-To: mark.rutland@arm.com, brad@pensando.io, linux-arm-kernel@lists.infradead.org, arnd@arndb.de, linus.walleij@linaro.org, bgolaszewski@baylibre.com, broonie@kernel.org, fancer.lancer@gmail.com, adrian.hunter@intel.com, ulf.hansson@linaro.org, olof@lixom.net, linux-gpio@vger.kernel.org, linux-spi@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211025_041507_643409_9854691B X-CRM114-Status: GOOD ( 18.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2021-10-25 10:17, Mark Rutland wrote: > Hi, > > On Sun, Oct 24, 2021 at 06:51:56PM -0700, Brad Larson wrote: >> Add Pensando common and Elba SoC specific device nodes >> >> Signed-off-by: Brad Larson > > [...] > >> + timer { >> + compatible = "arm,armv8-timer"; >> + interrupts = > + IRQ_TYPE_LEVEL_LOW)>, >> + > + IRQ_TYPE_LEVEL_LOW)>, >> + > + IRQ_TYPE_LEVEL_LOW)>, >> + > + IRQ_TYPE_LEVEL_LOW)>; >> + }; > > The GIC_CPU_MASK_SIMPLE() stuff is meant for GICv2, but as below you > have GICv3, where this is not valid, so this should go. > > Also, beware that GIC_CPU_MASK_SIMPLE(1) means a single CPU, which > doesn't mak sense for the 16 CPUs you have. > >> + gic: interrupt-controller@800000 { >> + compatible = "arm,gic-v3"; >> + #interrupt-cells = <3>; >> + #address-cells = <2>; >> + #size-cells = <2>; >> + ranges; >> + interrupt-controller; >> + reg = <0x0 0x800000 0x0 0x200000>, /* GICD */ >> + <0x0 0xa00000 0x0 0x200000>; /* GICR */ This is missing the GICv2 compat regions that the CPUs implement. >> + interrupts = ; >> + >> + gic_its: msi-controller@820000 { >> + compatible = "arm,gic-v3-its"; >> + msi-controller; >> + #msi-cells = <1>; >> + reg = <0x0 0x820000 0x0 0x10000>; >> + socionext,synquacer-pre-its = >> + <0xc00000 0x1000000>; >> + }; >> + }; > > Is there any shared lineage with Synquacer? The commit message didn't > describe this quirk. Funny, it looks like there is a sudden outburst of stupid copy/paste among HW designers. TI did the exact same thing recently. This totally negates all the advantages of having an ITS and makes sure that you have all the overhead. Facepalm... M. -- Jazz is not dead. It just smells funny... _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel