From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Thippeswamy Havalige <thippeswamy.havalige@amd.com>,
bhelgaas@google.com, devicetree@vger.kernel.org,
linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
robh+dt@kernel.org
Cc: lorenzo.pieralisi@arm.com, linux-arm-kernel@lists.infradead.org,
bharat.kumar.gogada@amd.com, michals@amd.com,
nagaradhesh.yeleswarapu@amd.com
Subject: Re: [PATCH v4 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge
Date: Mon, 5 Jun 2023 09:39:27 +0200 [thread overview]
Message-ID: <a2086bb1-160e-1dee-a686-ffdaf3422595@linaro.org> (raw)
In-Reply-To: <20230531083825.985584-3-thippeswamy.havalige@amd.com>
On 31/05/2023 10:38, Thippeswamy Havalige wrote:
> Add YAML dtschemas of Xilinx XDMA Soft IP PCIe Root Port Bridge
> dt binding.
>
> Signed-off-by: Thippeswamy Havalige <thippeswamy.havalige@amd.com>
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@amd.com>
> ---
> change in v4:
> +unevaluatedProperties: false
> +
> +examples:
> +
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> + #include <dt-bindings/interrupt-controller/irq.h>
> +
> + soc {
> + #address-cells = <2>;
> + #size-cells = <2>;
> + pcie@a0000000 {
> + compatible = "xlnx,xdma-host-3.00";
> + reg = <0x0 0xa0000000 0x0 0x10000000>;
> + ranges = <0x2000000 0x0 0xB0000000 0x0 0xB0000000 0x0 0x1000000>,
If there is going to be resend, use lower-case hex everywhere.
Otherwise, it's fine:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-05 7:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-31 8:38 [PATCH v4 0/3] Add support for Xilinx XDMA Soft IP as Root Port Thippeswamy Havalige
2023-05-31 8:38 ` [PATCH v4 1/3] Move and rename error interrupt bits to a common header Thippeswamy Havalige
2023-05-31 8:38 ` [PATCH v4 2/3] dt-bindings: PCI: xilinx-xdma: Add YAML schemas for Xilinx XDMA PCIe Root Port Bridge Thippeswamy Havalige
2023-06-05 7:39 ` Krzysztof Kozlowski [this message]
2023-06-05 8:55 ` Havalige, Thippeswamy
2023-05-31 8:38 ` [PATCH v4 3/3] PCI: xilinx-xdma: Add Xilinx XDMA Root Port driver Thippeswamy Havalige
2023-05-31 17:12 ` Bjorn Helgaas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2086bb1-160e-1dee-a686-ffdaf3422595@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bharat.kumar.gogada@amd.com \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=michals@amd.com \
--cc=nagaradhesh.yeleswarapu@amd.com \
--cc=robh+dt@kernel.org \
--cc=thippeswamy.havalige@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox