From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 33D04C433E0 for ; Thu, 7 Jan 2021 14:57:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DE3E623340 for ; Thu, 7 Jan 2021 14:57:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE3E623340 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=pengutronix.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=8s07KQiyikt5J9IsmpFuf+OHmVdsEsV3XLeC3wfcdug=; b=sAxaPyey0A333W7jkHhuSwUk4 doGDjHFQogyjhEdz5hIBgeGFGjrgfv7nlrCtmP/Rgw0fx3j9ySv3uy1u7T93UcUaMlSo6T8Id4epb SyxLDSxEtajimbPfu/kph4p1MpQxHt6Az87S1/5/7OJxmlr4m+yl3TMul8tX/26ZZp56J0XEoW5m6 ry9cU1Cn5aY4hwd+PEbHh2yMOOSe0D+Z9uDzrBx7ASmwNtQkvgWcTWy2ZeVu/F9uT1dy4K93wwTjP 7RCZnv5hl2EBUv1pxbo2v4/fwvLngYRnAZRQEP+tbaDQ1GOURdc2KyRHIsBzy/sv4Py6UrErxWuKO WAYx/xDpA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxWhc-0006Db-TF; Thu, 07 Jan 2021 14:55:52 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kxWhY-0006Bk-0b for linux-arm-kernel@lists.infradead.org; Thu, 07 Jan 2021 14:55:50 +0000 Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kxWhV-0006TA-EU; Thu, 07 Jan 2021 15:55:45 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kxWhP-0003zw-Fm; Thu, 07 Jan 2021 15:55:39 +0100 Message-ID: Subject: Re: [PATCH 3/5] dt-bindings: media: rockchip-vpu: Add PX30 compatible From: Philipp Zabel To: Paul Kocialkowski , linux-media@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Thu, 07 Jan 2021 15:55:39 +0100 In-Reply-To: <20210107134101.195426-4-paul.kocialkowski@bootlin.com> References: <20210107134101.195426-1-paul.kocialkowski@bootlin.com> <20210107134101.195426-4-paul.kocialkowski@bootlin.com> User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210107_095548_164058_2D9D7A35 X-CRM114-Status: GOOD ( 15.66 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , Greg Kroah-Hartman , Rob Herring , Jacob Chen , Thomas Petazzoni , Mauro Carvalho Chehab , Ezequiel Garcia Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Paul, On Thu, 2021-01-07 at 14:40 +0100, Paul Kocialkowski wrote: > The Rockchip PX30 SoC has a Hantro VPU that features a decoder (VDPU2) > and an encoder (VEPU2). It is similar to the RK3399's VPU but takes an > extra clock (SCLK). > > Signed-off-by: Paul Kocialkowski > --- > .../bindings/media/rockchip-vpu.yaml | 25 +++++++++++++------ > 1 file changed, 17 insertions(+), 8 deletions(-) > > diff --git a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > index c81dbc3e8960..c446b9ead21b 100644 > --- a/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > +++ b/Documentation/devicetree/bindings/media/rockchip-vpu.yaml > @@ -15,10 +15,13 @@ description: > > properties: > compatible: > - enum: > - - rockchip,rk3288-vpu > - - rockchip,rk3328-vpu > - - rockchip,rk3399-vpu > + oneOf: > + - const: rockchip,rk3288-vpu > + - const: rockchip,rk3328-vpu > + - const: rockchip,rk3399-vpu > + - items: > + - const: rockchip,px30-vpu > + - const: rockchip,rk3399-vpu > > reg: > maxItems: 1 > @@ -35,12 +38,18 @@ properties: > - const: vdpu > > clocks: > - maxItems: 2 > + minItems: 2 > + maxItems: 3 > > clock-names: > - items: > - - const: aclk > - - const: hclk > + oneOf: > + - items: > + - const: aclk > + - const: hclk > + - items: > + - const: aclk > + - const: hclk > + - const: sclk You could make this: clock-names: minItems: 2 items: - const: aclk - const: hclk - const: sclk And then: allOf: - if: properties: compatible: contains: const: rockchip,px30-vpu then: properties: clock-names: minItems: 3 to make sure each variant has the correct clocks set. regards Philipp _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel