From: Alexander Sverdlin <alexander.sverdlin@gmail.com>
To: Rob Herring <robh@kernel.org>
Cc: linux-iio@vger.kernel.org,
Hartley Sweeten <hsweeten@visionengravers.com>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-arm-kernel@lists.infradead.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description
Date: Thu, 15 Dec 2022 17:25:04 +0100 [thread overview]
Message-ID: <a279467764c063fccf28c7d8fdfac2ab57570fee.camel@gmail.com> (raw)
In-Reply-To: <20221215161835.GA138650-robh@kernel.org>
Thanks Krzysztof, Rob,
I'll incorporate your comments into the next version, but...
On Thu, 2022-12-15 at 10:18 -0600, Rob Herring wrote:
> > + clock-names:
> > + const: ep93xx-adc
>
> Weird name for a clock. Generally is signal name or what it
> controls (e.g. bus, core, etc.). Perhaps just drop it.
>
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > + - clock-names
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/clock/cirrus,ep93xx-clock.h>
your robot was right, this dependency is missing, I thought I can prepare
the ADC driver in advance, but seems it has to go together with the whole
DT conversion of the EP93xx series.
--
Alexander Sverdlin.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-12-15 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-14 22:20 [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Alexander Sverdlin
2022-12-14 22:20 ` [PATCH 2/2] iio: adc: ep93xx: Add OF support Alexander Sverdlin
2022-12-15 8:42 ` [PATCH 1/2] dt-bindings: iio: adc: ep93xx: Add cirrus,ep9301-adc description Krzysztof Kozlowski
2022-12-15 13:24 ` Rob Herring
2022-12-15 16:18 ` Rob Herring
2022-12-15 16:25 ` Alexander Sverdlin [this message]
2022-12-16 11:40 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a279467764c063fccf28c7d8fdfac2ab57570fee.camel@gmail.com \
--to=alexander.sverdlin@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=hsweeten@visionengravers.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox