From: Gavin Shan <gshan@redhat.com>
To: Andre Przywara <andre.przywara@arm.com>,
Lorenzo Pieralisi <lpieralisi@kernel.org>,
Hanjun Guo <guohanjun@huawei.com>,
Sudeep Holla <sudeep.holla@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>,
"Rafael J . Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, James Morse <james.morse@arm.com>,
Ben Horgan <ben.horgan@arm.com>,
Reinette Chatre <reinette.chatre@intel.com>,
Fenghua Yu <fenghuay@nvidia.com>
Cc: Jonathan Cameron <jic23@kernel.org>,
Srivathsa L Rao <srivathsa.rao@oss.qualcomm.com>,
Ganapatrao Kulkarni <ganapatrao.kulkarni@oss.qualcomm.com>,
Trilok Soni <tsoni@quicinc.com>,
Srinivas Ramana <sramana@qti.qualcomm.com>,
Niyas Sait <niyas.sait@arm.com>, Lee Trager <lee@trager.us>,
Ritwick Sharma <ritwick.sharma@arm.com>,
linux-acpi@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v9 11/12] arm_mpam: change MPAM-Fb error IRQ to use a threaded IRQ handler
Date: Thu, 27 Aug 2026 10:09:49 +1000 [thread overview]
Message-ID: <a2ac5d0f-1fe3-4dc6-92cc-d6aae82a9baa@redhat.com> (raw)
In-Reply-To: <20260807105451.3728284-12-andre.przywara@arm.com>
On 8/7/26 8:54 PM, Andre Przywara wrote:
> When an MPAM MSC gets into an error condition, it can trigger an error
> IRQ. We cannot really do much about those errors, but we at least query
> and log the error, then disable MPAM functionality.
>
> This error report relies on reading the MSC's error status register
> (ESR) in the current hard-IRQ handler, which is not possible for MPAM-Fb
> based MSC accesses, since they involve mailbox routines that might sleep.
> The same is true for clearing the interrupt at the source, which requires
> a (potentially sleeping) MSC access as well.
>
> Change the error IRQ handler to be a threaded interrupt, but keep the
> handling in the hard-IRQ part for MMIO MSCs. This is needed since the
> CPU affinity check in the MSC accessors requires a non-preemptible
> context.
> When the MSC is using an MPAM-Fb based access, we push the work into the
> threaded part of the handler, where the accessors are allowed to sleep.
> Also forbid per-CPU interrupts (PPIs) for MPAM-Fb, as we cannot use a
> threaded IRQ here.
>
> The actual IRQ handler learns how to deal with errors. We cannot really
> handle them, but we can try our best to disable the IRQ anyway.
> Should the level IRQ line deactivation fail on the device side, we mask
> the IRQ on the irqchip level, to prevent an interrupt storm.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
> drivers/resctrl/mpam_devices.c | 77 ++++++++++++++++++++++++++++------
> 1 file changed, 65 insertions(+), 12 deletions(-)
>
Reviewed-by: Gavin Shan <gshan@redhat.com>
next prev parent reply other threads:[~2026-08-27 0:10 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-07 10:54 [PATCH v9 00/12] arm_mpam: Add MPAM-Fb firmware support Andre Przywara
2026-08-07 10:54 ` [PATCH v9 01/12] arm_mpam: let low level MSC accessors return an error Andre Przywara
2026-08-07 10:54 ` [PATCH v9 02/12] arm_mpam: propagate MSC access errors for hw_probe functions Andre Przywara
2026-08-07 10:54 ` [PATCH v9 03/12] arm_mpam: propagate MSC access errors for MBWU counters Andre Przywara
2026-08-07 10:54 ` [PATCH v9 04/12] arm_mpam: propagate MSC access errors for msmon helpers Andre Przywara
2026-08-07 10:54 ` [PATCH v9 05/12] arm_mpam: propagate MSC access errors for __ris_msmon_read() Andre Przywara
2026-08-07 10:54 ` [PATCH v9 06/12] arm_mpam: propagate MSC access errors for state saving function Andre Przywara
2026-08-07 10:54 ` [PATCH v9 07/12] arm_mpam: propagate MSC access errors for mpam_reprogram_ris_partid() Andre Przywara
2026-08-26 17:41 ` Srivathsa L Rao
2026-08-07 10:54 ` [PATCH v9 08/12] arm_mpam: propagate MSC access errors for interrupt control Andre Przywara
2026-08-26 17:37 ` Srivathsa L Rao
2026-08-07 10:54 ` [PATCH v9 09/12] arm_mpam: prepare mon_sel locking for MPAM-Fb Andre Przywara
2026-08-07 10:54 ` [PATCH v9 10/12] arm_mpam: add MPAM-Fb MSC firmware access support Andre Przywara
2026-08-26 17:39 ` Srivathsa L Rao
2026-08-07 10:54 ` [PATCH v9 11/12] arm_mpam: change MPAM-Fb error IRQ to use a threaded IRQ handler Andre Przywara
2026-08-26 17:38 ` Srivathsa L Rao
2026-08-27 0:09 ` Gavin Shan [this message]
2026-08-07 10:54 ` [PATCH v9 12/12] arm_mpam: detect and enable MPAM-Fb PCC support Andre Przywara
2026-08-26 17:43 ` Srivathsa L Rao
2026-08-27 0:10 ` Gavin Shan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ac5d0f-1fe3-4dc6-92cc-d6aae82a9baa@redhat.com \
--to=gshan@redhat.com \
--cc=andre.przywara@arm.com \
--cc=ben.horgan@arm.com \
--cc=catalin.marinas@arm.com \
--cc=fenghuay@nvidia.com \
--cc=ganapatrao.kulkarni@oss.qualcomm.com \
--cc=guohanjun@huawei.com \
--cc=james.morse@arm.com \
--cc=jic23@kernel.org \
--cc=lee@trager.us \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=niyas.sait@arm.com \
--cc=rafael@kernel.org \
--cc=reinette.chatre@intel.com \
--cc=ritwick.sharma@arm.com \
--cc=sramana@qti.qualcomm.com \
--cc=srivathsa.rao@oss.qualcomm.com \
--cc=sudeep.holla@kernel.org \
--cc=tsoni@quicinc.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox