From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02A00C433ED for ; Thu, 1 Apr 2021 14:54:42 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7844661366 for ; Thu, 1 Apr 2021 14:54:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7844661366 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=CU6f1uI3/yU4qoQTyFT0XY8n1sOSmFQd2DI6vVutAs4=; b=YMmqpLq6ySfwgW0JiZ5/LyGqd +g/e6m8U3j7sZF+ZAzveXu7JG2b6UGrrOeL4KHZaCW6hR+sX+D6BXxwFPJYBlSBSI+UiWcVwGpto2 YRWxpU+SONkSXgWAGObGG3I07wcDeEIduvrR8/0UNhmvAPNMNOkpE1RXqpfKX6WyQakF18d0JYw9p kIZYYPMJ4Kz7iTc+XCreZSZgeISjTq1XfUNZ7H1lBlT75kpyHtK5Mpgmz7alCtOsk1zz8llVbO6hR nuS6wMfrS1DDebBCklDRZ68lUmLneQfda1ZFGBSidYfJdM2TMLdapOurS6lHmIDyGiHhBkQKeuDSg Ve5MIlmvw==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lRyh2-009usc-Ep; Thu, 01 Apr 2021 14:53:08 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lRygy-009us9-2T for linux-arm-kernel@lists.infradead.org; Thu, 01 Apr 2021 14:53:06 +0000 Received: by mail-pf1-x431.google.com with SMTP id a12so1648866pfc.7 for ; Thu, 01 Apr 2021 07:53:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=S8v12+xvw38bIlezrR3XZMbu9iWBOqwBPhWL+2JH5Uc=; b=Dyqaw1+fyqUfg5bx0s7dFljkCV8PaVIz36dJtCnis6d0JE98H+gWGEiJkpxzAu72t5 7wx0QmLOv6AMm0/1H50UY2mhotoAXpVBh6TjlUbhRDghDYIvd4Na88BsYOU/MfjiG/Ek 5L9NUBnbr0HDgBFpjCwPCjneRQQqWMFxfdBdAOUbbkWGh50YlaxYeyrpcBppDZxPfLju 7W5/5wDngGZi9dfnVSeMQtKWEkaIJVTGbtbo9z+RiPBI2tP2AG9Lmg2iFXLV7/mlHJpP BdQnus19uPbIqKC78aExwLAg091o5q+nisiOXbINw42FSWQE+dz2viABp1CuUiFcQbbV QNRA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=S8v12+xvw38bIlezrR3XZMbu9iWBOqwBPhWL+2JH5Uc=; b=UllPhZREhRy/rmhUZW7SWATD3yQ81O21LfJeFv4LeMFidTWkXjV8g57Cg/UPNNQbZz 5HTgVR1T73FBfm8Ge9d6ftgqEW95iShu3lPNL1yn+6x7uMhXlhzGRgN7sC0YLtC2+3bu 5DIDPu/XnALI1SOfC42obkHH0CLHlP8UJV0SN7QbBRhYGB3GXuxtU07mfh2+tRc9joSF zOq2MoDvcyWdZ7i7m2sduLF4pr4+BhXWO19gAA4XyXu21kCeF/5cSdRTyQW+erxhsOvJ ppB58bEwJPoSMz3FGzcnsDyJLdyqGixp+wqhBhCA5p+EJcwKGpVqTq+QWOHNPUdhMnKk Z2gQ== X-Gm-Message-State: AOAM530lU/dWgLBRXLD4pacB1SDi5JF41wO+9PFXnPOzqYu3qnorjYpX fE3/8zTk+NDlW5werd1JFrg= X-Google-Smtp-Source: ABdhPJzu44h9Fj7Ot3tFgyse9/w8XDAsDQQFWBiJsD/anxTnTfRamR8LuuoBNBHgcCRNKdUOVvGHZw== X-Received: by 2002:a63:1a47:: with SMTP id a7mr7729388pgm.437.1617288782443; Thu, 01 Apr 2021 07:53:02 -0700 (PDT) Received: from ?IPv6:2409:4072:6307:8389:a773:d07f:cd55:994a? ([2409:4072:6307:8389:a773:d07f:cd55:994a]) by smtp.gmail.com with ESMTPSA id s19sm5825401pfh.168.2021.04.01.07.52.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 01 Apr 2021 07:53:01 -0700 (PDT) Subject: Re: [PATCH] iio: adc: bcm_iproc_adc: Use %s and __func__ To: Jonathan Cameron , Andy Shevchenko Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Ray Jui , Scott Branden , bcm-kernel-feedback-list , linux-iio , linux-arm Mailing List , Linux Kernel Mailing List References: <20210401062517.28832-1-dmugil2000@gmail.com> <20210401113015.00006b70@Huawei.com> From: Mugilraj D Message-ID: Date: Thu, 1 Apr 2021 20:22:47 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210401113015.00006b70@Huawei.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210401_155304_338955_4F57B281 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 01/04/21 4:00 pm, Jonathan Cameron wrote: > On Thu, 1 Apr 2021 12:24:50 +0300 > Andy Shevchenko wrote: > >> On Thu, Apr 1, 2021 at 9:27 AM Mugilraj Dhavachelvan >> wrote: >>> >>> Change function's name to %s and __func__ to fix checkpatch.pl errors. >> >> No, just drop the __func__ completely. First of all, we have a device >> name, and uniqueness of the messages in the driver should guarantee >> easy findings. Second, specific to _dbg() variants, with enabled >> Dynamic Debug it can be chosen at run time! >> >> I recommend going through all drivers and drop __func__ near to >> dev_dbg() and pr_debug(). >> > > Agreed. Though beware that some maintainers will count this > as noise and get grumpy. > > I'm fine with such patches for IIO. Sorry for the noise. I just seen the docs about dynamic debug. So, if we use dev_dbg("log_msg") it will print statement like filename:lineno [module]func flag log_msg, If I get it correctly. And no need of specifying __func__ in dev_dbg() and dp_dbg() right!! Jonathan do you have any TODO's? > > Jonathan > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel