From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ryan Chen <ryan_chen@aspeedtech.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>, Joel Stanley <joel@jms.id.au>,
Andrew Jeffery <andrew@codeconstruct.com.au>,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will@kernel.org>, Arnd Bergmann <arnd@arndb.de>,
Bjorn Andersson <bjorn.andersson@oss.qualcomm.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Nishanth Menon <nm@ti.com>,
"nfraprado@collabora.com" <nfraprado@collabora.com>,
Taniya Das <quic_tdas@quicinc.com>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Eric Biggers <ebiggers@google.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-aspeed@lists.ozlabs.org" <linux-aspeed@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"soc@lists.linux.dev" <soc@lists.linux.dev>,
Mo Elbadry <elbadrym@google.com>,
Rom Lemarchand <romlem@google.com>,
William Kennington <wak@google.com>,
Yuxiao Zhang <yuxiaozhang@google.com>,
"wthai@nvidia.com" <wthai@nvidia.com>,
"leohu@nvidia.com" <leohu@nvidia.com>,
"dkodihalli@nvidia.com" <dkodihalli@nvidia.com>,
"spuranik@nvidia.com" <spuranik@nvidia.com>
Subject: Re: [PATCH v0 3/5] arm64: dts: aspeed: Add initial AST2700 SoC device tree
Date: Mon, 16 Jun 2025 08:43:00 +0200 [thread overview]
Message-ID: <a2ca2f58-f648-43f9-8d23-4111e4eb1f1d@kernel.org> (raw)
In-Reply-To: <OS8PR06MB7541645F6A0638FC250B1272F270A@OS8PR06MB7541.apcprd06.prod.outlook.com>
On 16/06/2025 08:32, Ryan Chen wrote:
>>>
>>> But I don't know your previous "NAK, never tested" mean.
>>> I did make CHECK_DTBS=y arch/arm64/boot/dts/aspeed/ don't see the fail
>>> with
>>> intc0: interrupt-controller@12100000 {
>>> compatible = "simple-mfd";
>>>
>>> So, could you point me more test instruction for this?
>> See syscon.yaml. And writing bindings or talks on conferences:
>> simple-mfd cannot be alone.
>>
>
> intc0: interrupt-controller@12100000 {
> Sorry, do you mean add by following?
> compatible = "aspeed,intc-controller", "simple-mfd";
> .....
> intc0_11: interrupt-controller@1b00 {
> compatible = "aspeed,ast2700-intc-ic";
> ......
> };
> };
Maybe, but you said this is base address, so how can it be some separate
device?
I mean really, don't add fake nodes just to satisfy some device
instantiation. Describe what this really is. That is the job of DTS. Not
some fake nodes.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-06-16 6:45 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-12 10:09 [PATCH v0 0/5] Add initial AST2700 SoC support Ryan Chen
2025-06-12 10:09 ` [PATCH v0 1/5] dt-bindings: arm: aspeed: Add AST2700 board compatible Ryan Chen
2025-06-12 10:15 ` Krzysztof Kozlowski
2025-06-13 2:00 ` Ryan Chen
2025-06-12 10:09 ` [PATCH v0 2/5] arm64: Kconfig: Add Aspeed SoC family (ast2700) platform option Ryan Chen
2025-06-12 10:09 ` [PATCH v0 3/5] arm64: dts: aspeed: Add initial AST2700 SoC device tree Ryan Chen
2025-06-12 10:17 ` Krzysztof Kozlowski
2025-06-13 2:29 ` Ryan Chen
2025-06-13 6:16 ` Krzysztof Kozlowski
2025-06-16 2:24 ` Ryan Chen
2025-06-16 6:15 ` Krzysztof Kozlowski
2025-06-16 6:32 ` Ryan Chen
2025-06-16 6:43 ` Krzysztof Kozlowski [this message]
2025-06-16 6:54 ` Ryan Chen
2025-06-16 7:07 ` Krzysztof Kozlowski
2025-06-16 7:52 ` Ryan Chen
2025-06-16 10:29 ` Krzysztof Kozlowski
2025-06-12 10:20 ` Krzysztof Kozlowski
2025-06-13 2:54 ` Ryan Chen
2025-06-12 10:09 ` [PATCH v0 4/5] arm64: dts: aspeed: Add AST2700 EVB " Ryan Chen
2025-06-12 10:14 ` Krzysztof Kozlowski
2025-06-12 10:14 ` Krzysztof Kozlowski
2025-06-12 10:09 ` [PATCH v0 5/5] arm64: configs: Update defconfig for AST2700 platform support Ryan Chen
2025-06-12 10:18 ` Krzysztof Kozlowski
2025-06-12 20:12 ` [PATCH v0 0/5] Add initial AST2700 SoC support Rob Herring (Arm)
2025-06-13 5:29 ` Andrew Jeffery
2025-06-25 20:42 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a2ca2f58-f648-43f9-8d23-4111e4eb1f1d@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@codeconstruct.com.au \
--cc=arnd@arndb.de \
--cc=bjorn.andersson@oss.qualcomm.com \
--cc=catalin.marinas@arm.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dkodihalli@nvidia.com \
--cc=ebiggers@google.com \
--cc=elbadrym@google.com \
--cc=geert@linux-m68k.org \
--cc=joel@jms.id.au \
--cc=krzk+dt@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=leohu@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfraprado@collabora.com \
--cc=nm@ti.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=romlem@google.com \
--cc=ryan_chen@aspeedtech.com \
--cc=soc@lists.linux.dev \
--cc=spuranik@nvidia.com \
--cc=wak@google.com \
--cc=will@kernel.org \
--cc=wthai@nvidia.com \
--cc=yuxiaozhang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).