From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E983C433E2 for ; Fri, 28 Aug 2020 02:01:16 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A817207DF for ; Fri, 28 Aug 2020 02:01:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="LAAqyQCj" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3A817207DF Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tq3na3fDfMf4B9n8cRS3s3YUFf+7z8VKX8gZ6vlaGPM=; b=LAAqyQCjLLPurOBloIZ2NtDJ0 UqOzSDtUvzAf73Mx2cIxwXjcGc/ENMCvMJ4XHyeE7IHMVV+Z+UdNLU3jQjBt+KvYVt8bwW3SKbkwB XqkPHdqcYZcp+wlxa+h2weqMVrdSQf3R9ABwRv4jjsNbpol7A2fBNEje1PST9L6BVDkKlXD0tDp6O FX6auHgIbsou9Q/fn4wTT6E7IqgOKfkukDbUurroaV0IlZZ2YUbaU0pIfQ+ZgQBAJwWALvXB56fWv MjgysJ7S0UwOOdLOM8veNM820afU63nq1kSAWvvSYssAWfQDvwwiApv8bPAIzYGMh2Annl7msK3Fi 3NuTYpGhw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBTgD-0000ZV-TB; Fri, 28 Aug 2020 01:59:49 +0000 Received: from szxga06-in.huawei.com ([45.249.212.32] helo=huawei.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kBTgA-0000Yg-2y; Fri, 28 Aug 2020 01:59:47 +0000 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id AD070D3F16C2953E7244; Fri, 28 Aug 2020 09:59:31 +0800 (CST) Received: from [127.0.0.1] (10.174.176.220) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Fri, 28 Aug 2020 09:59:21 +0800 Subject: Re: [PATCH v11 5/5] kdump: update Documentation about crashkernel To: Dave Young , References: <20200801130856.86625-1-chenzhou10@huawei.com> <20200801130856.86625-6-chenzhou10@huawei.com> <20200808100239.GB60590@dhcp-128-65.nay.redhat.com> <96d0da23-d484-7f66-1680-07b4b5984831@huawei.com> <20200810060355.GB6988@dhcp-128-65.nay.redhat.com> <2e6aebf9-3765-5d8c-933c-698442db1d52@huawei.com> <20200819120301.GA13727@dhcp-128-65.nay.redhat.com> From: chenzhou Message-ID: Date: Fri, 28 Aug 2020 09:59:19 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <20200819120301.GA13727@dhcp-128-65.nay.redhat.com> X-Originating-IP: [10.174.176.220] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200827_215946_377748_1D864112 X-CRM114-Status: GOOD ( 17.01 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: John.P.donnelly@oracle.com, guohanjun@huawei.com, xiexiuqi@huawei.com, arnd@arndb.de, bhe@redhat.com, corbet@lwn.net, horms@verge.net.au, bhsharma@redhat.com, linux-doc@vger.kernel.org, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, robh+dt@kernel.org, wangkefeng.wang@huawei.com, mingo@redhat.com, james.morse@arm.com, linux-arm-kernel@lists.infradead.org, huawei.libin@huawei.com, prabhakar.pkin@gmail.com, tglx@linutronix.de, will@kernel.org, nsaenzjulienne@suse.de Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Catalin, On 2020/8/19 20:03, Dave Young wrote: > On 08/18/20 at 03:07pm, chenzhou wrote: >> >> On 2020/8/10 14:03, Dave Young wrote: >>> Hi, >>> >>>>> Previously I remember we talked about to use similar logic as X86, but I >>>>> remember you mentioned on some arm64 platform there could be no low >>>>> memory at all. Is this not a problem now for the fallback? Just be >>>>> curious, thanks for the update, for the common part looks good. >>>> Hi Dave, >>>> >>>> Did you mean this discuss: https://lkml.org/lkml/2019/12/27/122? >>> I meant about this reply instead :) >>> https://lkml.org/lkml/2020/1/16/616 >> Hi Dave, >> >> Sorry for not repley in time, I was on holiday last week. > Hi, no problem, thanks for following up. > >> The platform James mentioned may exist for which have no devices and need no low memory. >> For our arm64 server platform, there are some devices and need low memory. >> >> I got it. For the platform with no low memory, reserving crashkernel will always fail. >> How about like this: > I think the question should leave to Catalin or James, I have no > suggestion about this:) Any suggestions about this? Thanks, Chen Zhou > >> diff --git a/arch/arm64/mm/init.c b/arch/arm64/mm/init.c >> index a8e34d97a894..4df18c7ea438 100644 >> --- a/arch/arm64/mm/init.c >> +++ b/arch/arm64/mm/init.c >> @@ -147,7 +147,7 @@ static void __init reserve_crashkernel(void) >> } >> memblock_reserve(crash_base, crash_size); >> >> - if (crash_base >= CRASH_ADDR_LOW_MAX) { >> + if (memstart_addr < CRASH_ADDR_LOW_MAX && crash_base >= CRASH_ADDR_LOW_MAX) { >> const char *rename = "Crash kernel (low)"; >> >> if (reserve_crashkernel_low()) { >> >> >> Thanks, >> Chen Zhou >> >>> Thanks >>> Dave >>> >>> >>> . >>> >> > > . > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel