From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 976B6C87FCA for ; Tue, 29 Jul 2025 19:17:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:Message-ID:References:In-Reply-To:Subject:Cc:To:From:Date: MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=KKWyy9AysMqp+foLRIk/frdK0mBNoA6TGv7vzHMpIoo=; b=Cgsw+kOTDzuLVG/XuRpDsohgWY vIv4TPDsfyFlSWbfdW7vV0ZlZ4e7dPMC/rxX16c/sA8gxfRuOy8We4uPAtnouzvMXD0jU9Vg01Uvx 67VFYvZjUnR92tbjlIGmz7c8AqZ/eisKzOucEgOSTEIMpgq7xnGippS56F8TG2oJ+Rpe4crSOyYHv 4rut9LuD+1XWoBFJJ9o/JclbCU0Ss4VUsVLXHsvaFVPj5NjJAP+8yXeZ5sWPpIBXLWo82MSy91yGp 8iH0QW8olBlzS1mw/+zHrH92MNJ8ipJeEQm0/9zBR/I+9/codTESI1NRuSSSW4vEyaFg+xcxLwZtV UfZL0Zog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugppC-0000000HXqz-492z; Tue, 29 Jul 2025 19:17:22 +0000 Received: from mail.manjaro.org ([116.203.91.91]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1ugpls-0000000HXYB-3ATJ; Tue, 29 Jul 2025 19:13:58 +0000 MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1753816435; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KKWyy9AysMqp+foLRIk/frdK0mBNoA6TGv7vzHMpIoo=; b=uJKVPu3R1sIM5+48xB8nDMZO4mC4PkFIyss6I7l6EZuQiAz+M+Ix2y+XAz2yt8oe5SyYK8 3kgR0b3QGbCieJHK3ACSDl0TmIURCM7yzLl3WgZQ7zmHlvbetnFcU631ZtzePaf1Fa1Wjs P23xZX9+p4ZlUp7tHbH/MXDsH4toLTMqHVxqCL3SMzauCyaqyX1Vy1ChM1F4uibD1ORLy1 E4toMslBj6UaIAEacWaPTCEk/OFyWV4FLOnTS/+YnWIsl9KZ+5/SRdElBcBoA895WcB8ME eQWKyN51kOL4bgs9hXwjz69y9L2CSJgGrhb3J0x3XArCv9ny+ZfRhXwjqyv59A== Date: Tue, 29 Jul 2025 21:13:54 +0200 From: Dragan Simic To: Peter Robinson Cc: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , Geert Uytterhoeven , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, Diederik de Haas Subject: Re: [PATCH] arm64: dts: rockchip: Pinephone Pro: Update WiFi In-Reply-To: <20250729190712.145817-1-pbrobinson@gmail.com> References: <20250729190712.145817-1-pbrobinson@gmail.com> Message-ID: X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250729_121356_939113_98577A18 X-CRM114-Status: GOOD ( 14.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello Peter, On 2025-07-29 21:06, Peter Robinson wrote: > Update the WiFi configuration to include the wake-up > pin and add an ethernet alias to allow assignment of > a mac-address from the firmware. > > Signed-off-by: Peter Robinson > --- > .../dts/rockchip/rk3399-pinephone-pro.dts | 19 +++++++++++++++++++ > 1 file changed, 19 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > index 585ef0fd88ef0..05f7b506f3594 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-pinephone-pro.dts > @@ -21,6 +21,7 @@ / { > chassis-type = "handset"; > > aliases { > + ethernet0 = &brcmf; The same comments I made on your Pinebook Pro DT patch [1] apply here as well. To sum it up, I'm sorry, but an alias like this one isn't acceptable. [1] https://lore.kernel.org/linux-rockchip/20250729185827.144547-1-pbrobinson@gmail.com/T/#u > mmc0 = &sdio0; > mmc1 = &sdmmc; > mmc2 = &sdhci; > @@ -689,6 +690,12 @@ vcc1v8_codec_en: vcc1v8-codec-en { > }; > }; > > + wifi { > + wifi_host_wake_l: wifi-host-wake-l { > + rockchip,pins = <4 RK_PD0 RK_FUNC_GPIO &pcfg_pull_none>; > + }; > + }; > + > wireless-bluetooth { > bt_wake_pin: bt-wake-pin { > rockchip,pins = <2 RK_PD2 RK_FUNC_GPIO &pcfg_pull_none>; > @@ -715,7 +722,19 @@ &sdio0 { > pinctrl-names = "default"; > pinctrl-0 = <&sdio0_bus4 &sdio0_cmd &sdio0_clk>; > sd-uhs-sdr104; > + #address-cells = <1>; > + #size-cells = <0>; > status = "okay"; > + > + brcmf: wifi@1 { > + reg = <1>; > + compatible = "brcm,bcm4329-fmac"; > + interrupt-parent = <&gpio4>; > + interrupts = ; > + interrupt-names = "host-wake"; > + pinctrl-names = "default"; > + pinctrl-0 = <&wifi_host_wake_l>; > + }; > }; > > &pwm0 {