From: Stefan Wahren <stefan.wahren@i2se.com>
To: Padmanabha Srinivasaiah <treasure4paddy@gmail.com>,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: gregkh@linuxfoundation.org, nsaenz@kernel.org,
Gaston Gonzalez <gascoar@gmail.com>,
Ojaswin Mujoo <ojaswin98@gmail.com>,
Arnd Bergmann <arnd@arndb.de>, Phil Elwell <phil@raspberrypi.com>,
bcm-kernel-feedback-list@broadcom.com
Subject: Re: [PATCH] staging: vc04_services: Fix RCU dereference check
Date: Wed, 29 Dec 2021 20:13:40 +0100 [thread overview]
Message-ID: <a30849fa-dd7c-f661-0b27-a04c6531cfb8@i2se.com> (raw)
In-Reply-To: <20211229153243.6064-1-treasure4paddy@gmail.com>
Hi Padmanabha,
Am 29.12.21 um 16:32 schrieb Padmanabha Srinivasaiah:
> In service_callback path RCU dereference done without
> rcu_read_[lock/unlock] pair, fixing same by using them.
>
> [ 32.201659] =============================
> [ 32.201664] WARNING: suspicious RCU usage
> [ 32.201670] 5.15.11-rt24-v8+ #3 Not tainted
> [ 32.201680] -----------------------------
> [ 32.201685] drivers/staging/vc04_services/interface/vchiq_arm/vchiq_core.h:529 suspicious rcu_dereference_check() usage!
> [ 32.201695]
> [ 32.201695] other info that might help us debug this:
> [ 32.201695]
> [ 32.201700]
> [ 32.201700] rcu_scheduler_active = 2, debug_locks = 1
> [ 32.201708] no locks held by vchiq-slot/0/98.
> [ 32.201715]
> [ 32.201715] stack backtrace:
> [ 32.201723] CPU: 1 PID: 98 Comm: vchiq-slot/0 Not tainted 5.15.11-rt24-v8+ #3
> [ 32.201733] Hardware name: Raspberry Pi 4 Model B Rev 1.4 (DT)
> [ 32.201739] Call trace:
> [ 32.201742] dump_backtrace+0x0/0x1b8
> [ 32.201772] show_stack+0x20/0x30
> [ 32.201784] dump_stack_lvl+0x8c/0xb8
> [ 32.201799] dump_stack+0x18/0x34
> [ 32.201808] lockdep_rcu_suspicious+0xe4/0xf8
> [ 32.201817] service_callback+0x124/0x400
> [ 32.201830] slot_handler_func+0xf60/0x1e20
> [ 32.201839] kthread+0x19c/0x1a8
> [ 32.201849] ret_from_fork+0x10/0x20
>
> Signed-off-by: Padmanabha Srinivasaiah <treasure4paddy@gmail.com>
> ---
> drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> index 6759a6261500..ee1b48db9681 100644
> --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c
> @@ -1058,7 +1058,10 @@ service_callback(enum vchiq_reason reason, struct vchiq_header *header,
>
> DEBUG_TRACE(SERVICE_CALLBACK_LINE);
>
> + rcu_read_lock();
> service = handle_to_service(handle);
> + rcu_read_unlock();
> +
> if (WARN_ON(!service))
> return VCHIQ_SUCCESS;
>
thanks for reporting this issue.
Could you please explain how to reproduce this issue?
What makes you sure that your patch fixes the issue and not just hiding
the warning?
Best regards
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-12-29 19:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-29 15:32 [PATCH] staging: vc04_services: Fix RCU dereference check Padmanabha Srinivasaiah
2021-12-29 19:13 ` Stefan Wahren [this message]
2021-12-30 13:34 ` Padmanabha Srinivasaiah
2021-12-30 14:54 ` [PATCH v2] " Padmanabha Srinivasaiah
2021-12-30 21:39 ` Stefan Wahren
2021-12-31 18:56 ` Padmanabha Srinivasaiah
2021-12-31 19:54 ` [PATCH v3] " Padmanabha Srinivasaiah
2022-01-23 17:32 ` Stefan Wahren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a30849fa-dd7c-f661-0b27-a04c6531cfb8@i2se.com \
--to=stefan.wahren@i2se.com \
--cc=arnd@arndb.de \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=gascoar@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rpi-kernel@lists.infradead.org \
--cc=linux-staging@lists.linux.dev \
--cc=nsaenz@kernel.org \
--cc=ojaswin98@gmail.com \
--cc=phil@raspberrypi.com \
--cc=treasure4paddy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).