linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: Josua Mayer <josua@solid-run.com>
To: Krzysztof Kozlowski <krzk@kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@bootlin.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2 1/8] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml
Date: Sun, 24 Dec 2023 15:45:48 +0000	[thread overview]
Message-ID: <a32f81b0-cd01-4290-8be7-83b94e4b504e@solid-run.com> (raw)
In-Reply-To: <495a0f12-2627-4c47-9d51-ca580d378652@kernel.org>

Am 24.12.23 um 15:57 schrieb Krzysztof Kozlowski:
> On 24/12/2023 15:37, Josua Mayer wrote:
>> Convert the existing txt binding for armada-38x socs to DT schema
>> format.
>>
>> Signed-off-by: Josua Mayer <josua@solid-run.com>
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC. It might happen, that command when run on an older
> kernel, gives you outdated entries. Therefore please be sure you base
> your patches on recent Linux kernel.
>
> You missed at least devicetree list (maybe more), so this won't be
> tested by automated tooling. Performing review on untested code might be
> a waste of time, thus I will skip this patch entirely till you follow
> the process allowing the patch to be tested.
>
> Please kindly resend and include all necessary To/Cc entries.
I am sorry ...
I will verify what get_maintainers said ...

https://www.kernel.org/doc/html/latest/process/submitting-patches.html#select-the-recipients-for-your-patch
I got confused from this guide - what to do when it tells me 3 or more 
lists.
Should I take the most specific one? Or all of them? I.e.:

linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell 
Kirkwood and Armada 370, 375, 38x,...)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE 
TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)

>
>> +
>> +properties:
>> +  $nodename:
>> +    const: '/'
>> +  compatible:
>> +    oneOf:
>> +
>> +      - description: Armada 380 SoC
>> +        items:
>> +          - const: marvell,armada380
>> +
>> +      - description: Armada 385 SoC
>> +        items:
>> +          - const: marvell,armada385
>> +          - const: marvell,armada380
>> +
>> +      - description: Armada 388 SoC
>> +        items:
>> +          - const: marvell,armada388
>> +          - const: marvell,armada385
>> +          - const: marvell,armada380
> These should not be used alone, so such schema is not what we want. We
> want boards to be documented with these SoCs.
There is only one Marvell example for armada-8k:
Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml

I mirrored how that conversion had been done from text to yaml.
If only boards belong in the yaml, then the conversion from txt will 
create an empty file,
to which I could then add specific boards on top.

>
> Best regards,
> Krzysztof
>
sincerely
Josua Mayer

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-24 15:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-24 14:37 [PATCH v2 0/8] arm: dts: marvell: clearfog-gtr: miscellaneous enhancements Josua Mayer
2023-12-24 14:37 ` [PATCH v2 1/8] dt-bindings: marvell: a38x: convert the soc compatibles description to yaml Josua Mayer
2023-12-24 14:57   ` Krzysztof Kozlowski
2023-12-24 15:45     ` Josua Mayer [this message]
2023-12-24 15:52       ` Krzysztof Kozlowski
2023-12-24 16:04         ` Josua Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a32f81b0-cd01-4290-8be7-83b94e4b504e@solid-run.com \
    --to=josua@solid-run.com \
    --cc=andrew@lunn.ch \
    --cc=conor+dt@kernel.org \
    --cc=gregory.clement@bootlin.com \
    --cc=krzk@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=robh+dt@kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).