From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 01340EB64D9 for ; Wed, 12 Jul 2023 08:02:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sQDAQO3x7fAcQjQirUjs1qIMnvFjRq4bc1OiNuQlkU8=; b=VvmZ4M3O/Iitg6 bKL0HIQRlUSgFCT4Eq6J9vzZp5C/K8yNqE5SqEDec54XIWJOsv8WyGYPuLwgekgBp4s3lC+TbjunW kgOpM6K0GlpIpGlR/TV/Lb4Urqk6xgaU3+xlqEkykQXvSCQPQsLNHYkPqOLwPKB1iadZl676ULEpN vucHdnwX9mcpWQfXnSSzjvB2DEm5sqneO45U4nCbRbS1J5KasAODk4vAia4Wac5K2Eu2b2D9aoexl 3AkZ+Hk1zvbpb6BC/NajfyLYGoNOc7I+uo1AezEQXLAsq31G+q+9bXHOmeoy/xnzE8kqfHvg2TUSi Ih7W0yPtxWjGSiFOjObQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qJUnY-00Gr6n-2c; Wed, 12 Jul 2023 08:02:08 +0000 Received: from mail-wm1-x329.google.com ([2a00:1450:4864:20::329]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qJUnV-00Gr5n-1B for linux-arm-kernel@lists.infradead.org; Wed, 12 Jul 2023 08:02:07 +0000 Received: by mail-wm1-x329.google.com with SMTP id 5b1f17b1804b1-3fbef8ad9bbso72118095e9.0 for ; Wed, 12 Jul 2023 01:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20221208.gappssmtp.com; s=20221208; t=1689148921; x=1691740921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=YkIwyBsrrasbrw6SKcJzFKY+sZkplhIF1ednI0kruDo=; b=bDSyjqZU/kFai51bS4zMV7wkn6IN8baUYkKTFjyQ9VhethzeBGEkbszBcepIHQbhX/ SR/g8PJirC6plcC2OT3jO68NN6EISfhUEmvt1ZcYlS/KOUSkMDDyzznSdhUpivM0iJrQ 13i1l9cefjz5I67sRJQjmQxF2fa4P6dQ1xUf9knjRn5qTZv38166mojcNDNcHvXl6FfO ZPLuDOoK4MudT/YUB8wSHQ5pU5Z1S1Uo9G9e864mQVzsIieIc4ZhlEWbw2DVMhPKZv+y 9pxVVcRTZpHSUgTEL4Ayjp11/BWLsAVT7lgVUza3wY3VczprtRt4N1StlWKYkVsvVF/d dVMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689148921; x=1691740921; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=YkIwyBsrrasbrw6SKcJzFKY+sZkplhIF1ednI0kruDo=; b=K6MDLJGFUfwq00ZWTzypmAeOvLd1hVCFDz+teF6kHMAmJ69fsBLvgZtmcm4USkxurg LF1b2zy5rmv/bnD2SdMytmCTABjHeUMozFKHzc2P1mRuxwdblNSu9GWgftctdF35AYAv PbP4NcU7+8m0x832fRnoShR1BaU+5y2Qw8qUBSYoIhVxkJN5m4Nc1orwGLrAd4MuSnWi nanO7I9Lwpc8ygxtaIzpuRRGgjgI11L+nTAimy5EyWyrVZO0iqF5D/5kRc03BmYlyGa2 QzJUbfLx071nyyn9NCB4ABm4ED8kGfh90fUEjxivw7AOJlOfGLUvbrXbjYulA7l7dNhA Yyuw== X-Gm-Message-State: ABy/qLbmPqqwswJHME5tCa5VHO3TDFVu5/UV9tmbk+B6+gcHv0iq0Bwc mYURo7cq59/sxOSxEWrDkSuWVw== X-Google-Smtp-Source: APBJJlFBDoZQA2YW3Bxt2cfhjxIimssHNv6+Ox3A25mufenbLcs3GAodp0BeuMoLjGNPDIVyI6916Q== X-Received: by 2002:a1c:ed10:0:b0:3fb:b008:2002 with SMTP id l16-20020a1ced10000000b003fbb0082002mr18164102wmh.0.1689148920442; Wed, 12 Jul 2023 01:02:00 -0700 (PDT) Received: from [192.168.1.172] ([93.5.22.158]) by smtp.gmail.com with ESMTPSA id g23-20020a7bc4d7000000b003fc02a410d0sm12536303wmk.48.2023.07.12.01.01.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jul 2023 01:02:00 -0700 (PDT) Message-ID: Date: Wed, 12 Jul 2023 10:01:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [PATCH 1/3] dt-bindings: display: panel: add startek kd070fhfid015 support To: Krzysztof Kozlowski , Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Catalin Marinas , Will Deacon Cc: Guillaume La Roque , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230711-startek_display-v1-0-163917bed385@baylibre.com> <20230711-startek_display-v1-1-163917bed385@baylibre.com> <14bed951-22ae-4aa8-5fcb-b2cd92ebdbef@linaro.org> Content-Language: en-US From: Alexandre Mergnat In-Reply-To: <14bed951-22ae-4aa8-5fcb-b2cd92ebdbef@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230712_010205_626279_25311E53 X-CRM114-Status: GOOD ( 12.84 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, Thanks for your review On 12/07/2023 07:32, Krzysztof Kozlowski wrote: > On 11/07/2023 17:36, Alexandre Mergnat wrote: >> The Startek KD070FHFID015 is a 7-inch TFT LCD display with a resolution snip >> + >> + dcdc-gpios: true > > From where does this come? Which schema defines it? It's a miss. I will fix it and reset-gpios too by adding a maxItems and a description. >> + >> + height-mm: >> + const: 151 >> + >> + iovcc-supply: >> + description: Reference to the regulator powering the panel IO pins. >> + >> + reg: >> + maxItems: 1 >> + description: DSI virtual channel >> + >> + reset-gpios: true >> + >> + port: true >> + >> + power-supply: true >> + >> + width-mm: >> + const: 95 >> + >> +additionalProperties: false >> + >> +required: >> + - compatible >> + - dcdc-gpios >> + - iovcc-supply >> + - reg >> + - reset-gpios >> + - port >> + - power-supply > > Missing example. I will add it. -- Regards, Alexandre _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel