From: Fabio Estevam <festevam@denx.de>
To: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@gmail.com>,
shawnguo@kernel.org, robh+dt@kernel.org,
krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org
Subject: Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register
Date: Mon, 22 May 2023 11:18:37 -0300 [thread overview]
Message-ID: <a357394b7ba6d79d9bb3e85e2f992b85@denx.de> (raw)
In-Reply-To: <8d15b607-2a0c-91dc-33ce-8a0066ff9b11@denx.de>
Hi Marek,
On 22/05/2023 10:20, Marek Vasut wrote:
> Take a look at MX6Q and notice how the iomuxc and GPR register sets
> share the same base address . That's different on MX6SX where they are
> separate. So I think this binding should be specific to MX6SX ONLY and
> for MX6Q the subnode probing should be handled in the IOMUXC driver
> instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi .
>
> $ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi
> arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000
> {
> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
> "fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd";
> arch/arm/boot/dts/imx6qdl.dtsi- reg =
> <0x20e0000 0x38>;
> --
> arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000
> {
> arch/arm/boot/dts/imx6qdl.dtsi- compatible =
> "fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc";
> arch/arm/boot/dts/imx6qdl.dtsi- reg =
> <0x20e0000 0x4000>;
Removing fsl,imx6q-iomuxc-gpr causes PCI probe issue on imx6sx
as the driver searches for "fsl,imx6q-iomuxc-gpr":
static const struct imx6_pcie_drvdata drvdata[] = {
....
[IMX6SX] = {
.variant = IMX6SX,
.flags = IMX6_PCIE_FLAG_IMX6_PHY |
IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE |
IMX6_PCIE_FLAG_SUPPORTS_SUSPEND,
.gpr = "fsl,imx6q-iomuxc-gpr",
# dmesg | grep pci
[ 0.260212] imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-05-22 14:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 12:51 [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Fabio Estevam
2023-05-22 12:51 ` [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register Fabio Estevam
2023-05-22 13:20 ` Marek Vasut
2023-05-22 14:18 ` Fabio Estevam [this message]
2023-05-22 14:24 ` Marek Vasut
2023-05-22 13:28 ` Rob Herring
2023-05-22 12:51 ` [PATCH v5 3/4] ARM: dts: imx6sx: Add LDB support Fabio Estevam
2023-05-22 13:20 ` Marek Vasut
2023-05-22 14:19 ` Fabio Estevam
2023-05-22 14:22 ` Marek Vasut
2023-05-22 12:51 ` [PATCH v5 4/4] soc: imx: imx6sx-gpr: Introduce a GPR driver Fabio Estevam
2023-05-22 13:12 ` [PATCH v5 1/4] dt-bindings: display: bridge: ldb: Adjust imx6sx entries Marek Vasut
2023-05-22 13:28 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a357394b7ba6d79d9bb3e85e2f992b85@denx.de \
--to=festevam@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=marex@denx.de \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox