From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34C6EC7EE2E for ; Mon, 22 May 2023 14:19:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-ID:References:In-Reply-To:Subject:Cc:To:From :Date:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=JfokpiZF2M8L37/kn2laIP+wHy1JUMWXbxDNI8ixw88=; b=z+ppJnVCch/lB5RG+SynYuijWK 2mvyN8ug0WhljYBPrqNYURP/auWS9W9DTwC5u4avHewgKOGe9dOEVJ3DXny5kOkbyJT03AtJSVBBp +WdgDpW7gfnaGD2rhoUa9AACuSdfn8zP4iGSjH99P0UNZ69k7jAQgy7Bh727eFZs+XJB8Y9eyvPK7 Y4vOfvaAj0xBT7GjK8GnYZzYZDF8YbFiFxoScR4z9N18p4ufrUFXdjoqx34q89EFjiwaVZuZ0l2p+ PC6x93XXEvICq+iLswWPDcRQmKS+qTvKzdtJttLVH6FLaN6PWByaT+l5qxKDELvTpX9VurfhlJIWS F1CTvYxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q16N1-006nsE-1K; Mon, 22 May 2023 14:18:43 +0000 Received: from phobos.denx.de ([2a01:238:438b:c500:173d:9f52:ddab:ee01]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q16My-006nr3-0q for linux-arm-kernel@lists.infradead.org; Mon, 22 May 2023 14:18:41 +0000 Received: from mail.denx.de (unknown [IPv6:2a01:238:438b:c500:173d:9f52:ddab:ee01]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: festevam@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id C4E6E82790; Mon, 22 May 2023 16:18:37 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1684765117; bh=0DKYy6VV+LysXw/64jDOlwJ+iovgxOc9Kz3OwRZg1nI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=DGUsjmbXZcYlDgfmI+bNsfyenPgXLe458JDryQxw268/VjNybqCJMCLwrsN4Kysxo zY+aWJgzYw2yqHJPfKusra5wwMIPyFhDdHkTH3MLjEdwEH5ehnzWqJ91Kyb8I8vONV hesUiPtjrGHxRSabhsbWcDfs2LTMaHWdH1JhHaxyLr54Zo6mGabE6BrKOyteMn4ymp ybAtxYIDQuCfEZN03Ip4Y/8JACsTju7hZgM0W3IrFKi3rJlPzymFn48E4lvUS+Mer4 E7pSivtL26acPIFh8z5w9UY8bOFHjtKdXKCypTHMhNa8fIqvPaqrzRfu+ywaZYW5zc 7eTFxCFQut6GQ== MIME-Version: 1.0 Date: Mon, 22 May 2023 11:18:37 -0300 From: Fabio Estevam To: Marek Vasut Cc: Fabio Estevam , shawnguo@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, conor+dt@kernel.org Subject: Re: [PATCH v5 2/4] dt-bindings: soc: Add i.MX6SX General Purpose Register In-Reply-To: <8d15b607-2a0c-91dc-33ce-8a0066ff9b11@denx.de> References: <20230522125129.526604-1-festevam@gmail.com> <20230522125129.526604-2-festevam@gmail.com> <8d15b607-2a0c-91dc-33ce-8a0066ff9b11@denx.de> Message-ID: X-Sender: festevam@denx.de User-Agent: Roundcube Webmail/1.3.6 X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230522_071840_525065_A4AB4428 X-CRM114-Status: UNSURE ( 9.61 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Marek, On 22/05/2023 10:20, Marek Vasut wrote: > Take a look at MX6Q and notice how the iomuxc and GPR register sets > share the same base address . That's different on MX6SX where they are > separate. So I think this binding should be specific to MX6SX ONLY and > for MX6Q the subnode probing should be handled in the IOMUXC driver > instead , i.e. drop the fsl,imx6q-iomuxc-gpr here and in imx6sx.dtsi . > > $ git grep -A 2 @20e0000 arch/arm/boot/dts/imx6qdl.dtsi > arch/arm/boot/dts/imx6qdl.dtsi: gpr: iomuxc-gpr@20e0000 > { > arch/arm/boot/dts/imx6qdl.dtsi- compatible = > "fsl,imx6q-iomuxc-gpr", "syscon", "simple-mfd"; > arch/arm/boot/dts/imx6qdl.dtsi- reg = > <0x20e0000 0x38>; > -- > arch/arm/boot/dts/imx6qdl.dtsi: iomuxc: pinctrl@20e0000 > { > arch/arm/boot/dts/imx6qdl.dtsi- compatible = > "fsl,imx6dl-iomuxc", "fsl,imx6q-iomuxc"; > arch/arm/boot/dts/imx6qdl.dtsi- reg = > <0x20e0000 0x4000>; Removing fsl,imx6q-iomuxc-gpr causes PCI probe issue on imx6sx as the driver searches for "fsl,imx6q-iomuxc-gpr": static const struct imx6_pcie_drvdata drvdata[] = { .... [IMX6SX] = { .variant = IMX6SX, .flags = IMX6_PCIE_FLAG_IMX6_PHY | IMX6_PCIE_FLAG_IMX6_SPEED_CHANGE | IMX6_PCIE_FLAG_SUPPORTS_SUSPEND, .gpr = "fsl,imx6q-iomuxc-gpr", # dmesg | grep pci [ 0.260212] imx6q-pcie 8ffc000.pcie: unable to find iomuxc registers _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel