From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 254BFC38A2D for ; Sat, 22 Oct 2022 01:01:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=wh7ojonYaoaSa925CdVeSfIj7VkohSkwXqgtk0f5VIM=; b=CGOnZEsATlF9a5 oBrkkuEy3XwV7m3l1ILydD3xU8sEymaE1nVdfaxiPzodb/HAchz+Y315tg6steu+G82DvBtv7oKnU IfBv8Dzt24DGFrbwhUKjvFUyceVTeRtbtFxds3enFpY5bTBOaPHYC1xO6nOezw0OUKbEr/p1xaA3I gH/Vh23RElJdyRWv+19FbV9LmQnJFcFx28xsXgoCFyRbpfqXmWYCvjVxNoYBpCbTP8GpIb/Oa4Rww Sfa1Sv85pXbgIGB6FM0ioN+GUHbXLDI5ax8ziUcLiRU/9GPwX/5s59anKDSilDLDX0moRLwArBjWr +7Tv79XazbWyQ8enBGRg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1om2rm-00AeTn-N3; Sat, 22 Oct 2022 00:59:58 +0000 Received: from mail-qk1-x736.google.com ([2607:f8b0:4864:20::736]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1om2rj-00AeTG-Mp for linux-arm-kernel@lists.infradead.org; Sat, 22 Oct 2022 00:59:57 +0000 Received: by mail-qk1-x736.google.com with SMTP id o2so3094590qkk.10 for ; Fri, 21 Oct 2022 17:59:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=zLWMEaldl7mwAfibkMQ7f9QF8cCYwWsptPAXuW24IaM=; b=GQWsjBoGJUcqsoAAKfGshd5eISh/AnwduwW5D8aypRX7KEwXJ3w0D6o0OgT+l0RRXr GAAgtG5CUkJGI8fPQTQJiXbSO5cvaYoHOB+pshLdvXMezLl4y2enQTFHnGTAywwHljKj OjDsBu1AxLK1MUqf77CFy0sXBrlK8oRg11+QpsDkXshX+NBYr8M8Rodc3RNeeQexSBKN SPKAwpNgsl9Z0k9aaWLtpH/1H88dGThafvAGPC76HOpA6F7wQnazqxMti59Z2E1W+uDB 0pl8XwQj8qtiHEu5mTxYuuyUgok5l4D1JvlxVzuXlkjIhSLp4pa2Tuq2XCwK+/n/+Spi eG3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=zLWMEaldl7mwAfibkMQ7f9QF8cCYwWsptPAXuW24IaM=; b=LJI7866bpIqBtJXZkM5gi3+7pm8LTZeRYJqWGvt8u8Ww8rvBFn4w5RztijlmX88JKu sOgcuXArcpXAYCY5h7s2/JuH0DWyVAqxU2NlH//UKT0uAIkupTX253IXtlLB5dSn1gSS GlWUCspNag2hd0VWciCsfvR6V9rl/i3FkenX5LWGlXqHWkoTAAiw3DU5/cqNFaF1lMcv qSLhfgxkRbGW4E+FCUyKlhEB1W2trpaMRKF2149e+fXBy8FEXhRxRsSfn+B9IH+YJyZ9 1CKIgHeoe34NNfpabniujXJge5iUNx2HikwIA1lOKsnLBQzMcZd5bkN9Xgnj5njB4vSD NZNg== X-Gm-Message-State: ACrzQf0P/ZhN52ywmLyOMYYULmhuhhc2CK0jubgw01AiJnZEMlxipDvy k5RysTJK3334FmFalmKn9ikU0g== X-Google-Smtp-Source: AMsMyM5ePAEqT1CxZUNaI9lUZ9Iw9tWpO3mKZVYrsZfLArowIXhAP+1rILHZiBcFibxg3mzf8FbaaA== X-Received: by 2002:a37:b86:0:b0:6ea:3ec9:7994 with SMTP id 128-20020a370b86000000b006ea3ec97994mr15758286qkl.199.1666400393864; Fri, 21 Oct 2022 17:59:53 -0700 (PDT) Received: from [192.168.10.124] (pool-72-83-177-149.washdc.east.verizon.net. [72.83.177.149]) by smtp.gmail.com with ESMTPSA id l20-20020a05620a28d400b006b8e8c657ccsm10801547qkp.117.2022.10.21.17.59.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 21 Oct 2022 17:59:53 -0700 (PDT) Message-ID: Date: Fri, 21 Oct 2022 20:59:50 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [RFC PATCH 1/9] dt-bindings: arm-smmu: Add missing Qualcomm SMMU compatibles Content-Language: en-US To: Dmitry Baryshkov , Will Deacon , Robin Murphy , Joerg Roedel , Rob Herring , Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Rob Clark Cc: Vinod Koul , Sai Prakash Ranjan , linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org, freedreno@lists.freedesktop.org References: <20221021165534.2334329-1-dmitry.baryshkov@linaro.org> <20221021165534.2334329-2-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20221021165534.2334329-2-dmitry.baryshkov@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221021_175955_775405_0BBB4307 X-CRM114-Status: GOOD ( 16.50 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 21/10/2022 12:55, Dmitry Baryshkov wrote: > Add missing compatibles used for Adreno SMMU on sc7280 and sm8450 > platforms and for the Qualcomm v2 SMMU used on SDM630 platform. > > Signed-off-by: Dmitry Baryshkov > --- > Documentation/devicetree/bindings/iommu/arm,smmu.yaml | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > index 9066e6df1ba1..34ee33a62ba5 100644 > --- a/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > +++ b/Documentation/devicetree/bindings/iommu/arm,smmu.yaml > @@ -28,6 +28,7 @@ properties: > - enum: > - qcom,msm8996-smmu-v2 > - qcom,msm8998-smmu-v2 > + - qcom,sdm630-smmu-v2 So qcom,adreno-smmu is not compatible with Adreno? See below. > - const: qcom,smmu-v2 > > - description: Qcom SoCs implementing "arm,mmu-500" > @@ -48,10 +49,20 @@ properties: > - qcom,sm8350-smmu-500 > - qcom,sm8450-smmu-500 > - const: arm,mmu-500 > + > + - description: Qcom Adreno GPUs implementing "arm,smmu-500" > + items: > + - enum: > + - qcom,sc7280-smmu-500 > + - qcom,sm8250-smmu-500 > + - const: qcom,adreno-smmu > + - const: arm,mmu-500 > - description: Qcom Adreno GPUs implementing "arm,smmu-v2" > items: > - enum: > + - qcom,msm8996-smmu-v2 > - qcom,sc7180-smmu-v2 > + - qcom,sdm630-smmu-v2 This does not look correct. The same compatible should not be present in two different setups. If qcom,msm8996-smmu-v2 is compatible with qcom,adreno-smmu, then your first hunk is not correct. > - qcom,sdm845-smmu-v2 > - const: qcom,adreno-smmu > - const: qcom,smmu-v2 Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel