From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: * X-Spam-Status: No, score=1.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_DBL_ABUSE_MALW autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF9DDC33C9E for ; Thu, 30 Jan 2020 08:37:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FCCC206D5 for ; Thu, 30 Jan 2020 08:37:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="AARiIdD5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FCCC206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7i/9iewq8j2oeG5Dv0qHWB2D0/Q6LJTTh8hhRj8fMhw=; b=AARiIdD5RP0HLG 0L8bQww2LLw9NrZ21d/rNou5aLAp5vDYeme0doUauX/U0RVdBhd+s2/HTVMye5sP6y1Vqa+i13S+T udrrQ8zmZs+E8VjzXFzNK6OiXeeSk5dDM5zF/4aasFmOv+47owdTg+YGH9gRAy8fhdQhkm3K9+Ly5 tKOipPZaEXTA5Iua4Sbp7YCLf+JPkfERiXxJAF6x2TgK/+5lJij6W+DafBnvBOBZRDXl+YVfHQRHk zCO7rijavNlLT8F9tgXmdJwIuVKsHPNMlTJIcgMhffpJsNLIHEvilL/WqaLtM4o8LrsjYMQNY+prA r5CxzCWkJt2RsFC6/Nvw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix5KT-00019j-AM; Thu, 30 Jan 2020 08:37:37 +0000 Received: from mga17.intel.com ([192.55.52.151]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ix5KN-00018X-0f for linux-arm-kernel@lists.infradead.org; Thu, 30 Jan 2020 08:37:35 +0000 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2020 00:37:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,381,1574150400"; d="scan'208";a="232837098" Received: from kvehmane-mobl.ger.corp.intel.com (HELO jsakkine-mobl1) ([10.237.50.119]) by orsmga006.jf.intel.com with ESMTP; 30 Jan 2020 00:37:26 -0800 Message-ID: Subject: Re: [PATCH v2 2/2] tpm: tis: add support for MMIO TPM on SynQuacer From: Jarkko Sakkinen To: Ard Biesheuvel Date: Thu, 30 Jan 2020 10:37:25 +0200 In-Reply-To: References: <20200114141647.109347-1-ardb@kernel.org> <20200114141647.109347-3-ardb@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Evolution 3.34.1-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200130_003734_148538_20B3814F X-CRM114-Status: GOOD ( 15.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Devicetree List , Peter =?ISO-8859-1?Q?H=FCwe?= , Linux Kernel Mailing List , Jason Gunthorpe , Masahisa Kojima , linux-integrity , Ard Biesheuvel , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2020-01-23 at 13:29 +0100, Ard Biesheuvel wrote: > On Thu, 23 Jan 2020 at 13:27, Jarkko Sakkinen > wrote: > > On Tue, 2020-01-14 at 15:16 +0100, Ard Biesheuvel wrote: > > > When fitted, the SynQuacer platform exposes its SPI TPM via a MMIO > > > window that is backed by the SPI command sequencer in the SPI bus > > > controller. This arrangement has the limitation that only byte size > > > accesses are supported, and so we'll need to provide a separate set > > > of read and write accessors that take this into account. > > > > What is SynQuacer platform? > > > > It is an arm64 SoC manufactured by Socionext. > > > I'm also missing a resolution why tpm_tis.c is extended to handle both > > and not add tpm_tis_something.c instead. It does not follow the pattern > > we have in place (e.g. look up tpm_tis_spi.c). > > > > We could easily do that instead, if preferred. It's just that it would > duplicate a bit of code. I'm fine with that. Overally I think it is cleaner flow. /Jarkko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel