* [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe()
@ 2023-08-01 12:28 Zhu Wang
2023-08-01 12:38 ` AngeloGioacchino Del Regno
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Zhu Wang @ 2023-08-01 12:28 UTC (permalink / raw)
To: linux, heikki.krogerus, gregkh, matthias.bgg,
angelogioacchino.delregno, linux-usb, linux-arm-kernel,
linux-mediatek
Cc: wangzhu9
When platform_get_irq() is called, the error message has been printed,
so it need not to call dev_err_probe() to present error messages.
Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
---
drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
index 2a079464b398..9cda1005ef01 100644
--- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
+++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
@@ -147,7 +147,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev)
irq = platform_get_irq(pdev, 0);
if (irq < 0)
- return dev_err_probe(dev, irq, "Failed to get irq\n");
+ return irq;
/* Assign TCPCI feature and ops */
priv->tcpci_data.auto_discharge_disconnect = 1;
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe()
2023-08-01 12:28 [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe() Zhu Wang
@ 2023-08-01 12:38 ` AngeloGioacchino Del Regno
2023-08-01 14:35 ` Guenter Roeck
2023-08-02 10:59 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-08-01 12:38 UTC (permalink / raw)
To: Zhu Wang, linux, heikki.krogerus, gregkh, matthias.bgg, linux-usb,
linux-arm-kernel, linux-mediatek
Il 01/08/23 14:28, Zhu Wang ha scritto:
> When platform_get_irq() is called, the error message has been printed,
> so it need not to call dev_err_probe() to present error messages.
>
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe()
2023-08-01 12:28 [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe() Zhu Wang
2023-08-01 12:38 ` AngeloGioacchino Del Regno
@ 2023-08-01 14:35 ` Guenter Roeck
2023-08-02 10:59 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Guenter Roeck @ 2023-08-01 14:35 UTC (permalink / raw)
To: Zhu Wang, heikki.krogerus, gregkh, matthias.bgg,
angelogioacchino.delregno, linux-usb, linux-arm-kernel,
linux-mediatek
On 8/1/23 05:28, Zhu Wang wrote:
> When platform_get_irq() is called, the error message has been printed,
> so it need not to call dev_err_probe() to present error messages.
>
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> index 2a079464b398..9cda1005ef01 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> @@ -147,7 +147,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return dev_err_probe(dev, irq, "Failed to get irq\n");
> + return irq;
>
> /* Assign TCPCI feature and ops */
> priv->tcpci_data.auto_discharge_disconnect = 1;
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe()
2023-08-01 12:28 [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe() Zhu Wang
2023-08-01 12:38 ` AngeloGioacchino Del Regno
2023-08-01 14:35 ` Guenter Roeck
@ 2023-08-02 10:59 ` Heikki Krogerus
2 siblings, 0 replies; 4+ messages in thread
From: Heikki Krogerus @ 2023-08-02 10:59 UTC (permalink / raw)
To: Zhu Wang
Cc: linux, gregkh, matthias.bgg, angelogioacchino.delregno, linux-usb,
linux-arm-kernel, linux-mediatek
On Tue, Aug 01, 2023 at 08:28:34PM +0800, Zhu Wang wrote:
> When platform_get_irq() is called, the error message has been printed,
> so it need not to call dev_err_probe() to present error messages.
>
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>
Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
> drivers/usb/typec/tcpm/tcpci_mt6370.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/typec/tcpm/tcpci_mt6370.c b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> index 2a079464b398..9cda1005ef01 100644
> --- a/drivers/usb/typec/tcpm/tcpci_mt6370.c
> +++ b/drivers/usb/typec/tcpm/tcpci_mt6370.c
> @@ -147,7 +147,7 @@ static int mt6370_tcpc_probe(struct platform_device *pdev)
>
> irq = platform_get_irq(pdev, 0);
> if (irq < 0)
> - return dev_err_probe(dev, irq, "Failed to get irq\n");
> + return irq;
>
> /* Assign TCPCI feature and ops */
> priv->tcpci_data.auto_discharge_disconnect = 1;
> --
> 2.17.1
--
heikki
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-08-02 11:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-08-01 12:28 [PATCH -next] usb: typec: tcpci_mt6370: remove redundant dev_err_probe() Zhu Wang
2023-08-01 12:38 ` AngeloGioacchino Del Regno
2023-08-01 14:35 ` Guenter Roeck
2023-08-02 10:59 ` Heikki Krogerus
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).