From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB7E3CCA468 for ; Mon, 29 Sep 2025 17:45:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xxOy9NVXUKo2r8viMGsfOm+H8eQBo5JltBhPtU+i+fI=; b=gkpmiWqW+lPhpz0R5YuhEm+2u/ cuFIX8C+p4/5wYaX0SczXL1pGnRJJdHCdKK3kba0PWtz87IQOGcwregjkyXmrxn4TmFSiBrE7ynH6 eqM+k0nX7R+aWf2QkrW2XJOkltCUgFvDouBQZBZFFsfSPSZhcPiI3esYM1uArRZa+wHEaub50ahtD Vb/zWZ8sBKtOl9sB/TY+UPz9JO9zOEk5RhmV/afIkhGPe4wyL4Dl5Tdk3Oi9XxD5y51QDe2+XGwYG FZ6A3KfpLj7/QGJZYn0j7FKj2pIQ0zAv+++nupkIgYW4RWJ+mdiTSB1HS5C5zaoHHvFIGxY216sKn KNE5wP5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v3Hvq-00000003A19-2Mli; Mon, 29 Sep 2025 17:45:02 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v3Hvc-000000039tH-2cPt for linux-arm-kernel@lists.infradead.org; Mon, 29 Sep 2025 17:44:49 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DF1491758; Mon, 29 Sep 2025 10:44:39 -0700 (PDT) Received: from [10.1.197.69] (eglon.cambridge.arm.com [10.1.197.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 6E5123F59E; Mon, 29 Sep 2025 10:44:42 -0700 (PDT) Message-ID: Date: Mon, 29 Sep 2025 18:44:39 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 11/29] arm_mpam: Probe hardware to find the supported partid/pmg values To: Ben Horgan , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org Cc: D Scott Phillips OS , carl@os.amperecomputing.com, lcherian@marvell.com, bobo.shaobowang@huawei.com, tan.shaopeng@fujitsu.com, baolin.wang@linux.alibaba.com, Jamie Iles , Xin Hao , peternewman@google.com, dfustini@baylibre.com, amitsinght@marvell.com, David Hildenbrand , Dave Martin , Koba Ko , Shanker Donthineni , fenghuay@nvidia.com, baisheng.gao@unisoc.com, Jonathan Cameron , Rob Herring , Rohit Mathew , Rafael Wysocki , Len Brown , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , Catalin Marinas , Will Deacon , Greg Kroah-Hartman , Danilo Krummrich References: <20250910204309.20751-1-james.morse@arm.com> <20250910204309.20751-12-james.morse@arm.com> <0382ea8a-8f15-4983-8659-0471f9090012@arm.com> Content-Language: en-GB From: James Morse In-Reply-To: <0382ea8a-8f15-4983-8659-0471f9090012@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250929_104448_713156_6A9D13E1 X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Ben, On 12/09/2025 12:11, Ben Horgan wrote: > On 9/10/25 21:42, James Morse wrote: >> CPUs can generate traffic with a range of PARTID and PMG values, >> but each MSC may also have its own maximum size for these fields. >> Before MPAM can be used, the driver needs to probe each RIS on >> each MSC, to find the system-wide smallest value that can be used. >> The limits from requestors (e.g. CPUs) also need taking into account. >> >> While doing this, RIS entries that firmware didn't describe are created >> under MPAM_CLASS_UNKNOWN. >> >> While we're here, implement the mpam_register_requestor() call >> for the arch code to register the CPU limits. Future callers of this >> will tell us about the SMMU and ITS. > Looks good to me. I think Jonathan's comment on getting rid of the local > variable, 'found', is worthwhile. > > Reviewed-by: Ben Horgan Thanks! James