From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C1D6EE57CE for ; Wed, 11 Sep 2024 18:41:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1+7p3Z5qCC26Ye8mLVaKGA4gMsf3x0zTnnTmPLOwPnE=; b=4ceoMSsTfXh1kkpfw+awyt4xYY 0RnNX6CV4TUvzriN6QiMo83SM3F8DRItdgdtTna3jOK+5nfQ5WqOHlY1gWpREdnF/9hcUfQS99NU5 R3/IPEQObbJGzoUIt7AUvr/2xW/fv7ipIWJMjBI+lV5z2/o1mEG4I7yyrf+QFHmDcpydv1xRUFNZa ptQE34ENjLCJw3VHoBrvtSy6T5Nmbogpvk3hLeZQENFjS2zMGUBPLQ3J0caDCspc0zZTxUCdB4nAc PhlG+RVHImvhBQXH4QOxNuJ0vW8wF+ecHy6jA8Pti/lHwsH2HsoPXeJPMFGfDH2No28H7rrTZyL4g 9jF5QvxQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1soSHJ-0000000AgAE-1YKj; Wed, 11 Sep 2024 18:41:21 +0000 Received: from mail-pg1-x536.google.com ([2607:f8b0:4864:20::536]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1soSGG-0000000Afyk-1v2g for linux-arm-kernel@lists.infradead.org; Wed, 11 Sep 2024 18:40:17 +0000 Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-7c1324be8easo917216a12.1 for ; Wed, 11 Sep 2024 11:40:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1726080015; x=1726684815; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=1+7p3Z5qCC26Ye8mLVaKGA4gMsf3x0zTnnTmPLOwPnE=; b=OxP4VlbR5KsyVaFmMpR9ournLF5Ldq+aBo/c1DsSLX6SVcoBzaI/RuiQlTQAO1MP0y GON2Gj7w+zZ7poXLVmGWhqRaRfJHxUFcM85VFr9exDD4cb2C1TGxsTxznUP2Ecr5fxN2 gbPp/cLAQ6uz2dKKjkIYW3jNI65YU/PF+YMJGPoql8Hi7YT6EWxcPK/21mdlL9YPdp+E n1rTBIxJy7nNhHUJQI6y7TX0y6Nql6q/eZeo4Ux1gLMRphQCt9aIv2QTYFHYG9ZweoU6 I+sKcKMdvYfeoNBSUq0/nDfap7XrYtK0BoyDuP57touO6iHAxUZuSm08+Wtzx7tCpt3v cI7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1726080015; x=1726684815; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=1+7p3Z5qCC26Ye8mLVaKGA4gMsf3x0zTnnTmPLOwPnE=; b=lHEKRbu5XKEUG5GauVMqR4RduwYCT6A9D6oXqQfLp4PIZtjzne21/r6NMTM47llqpq 3bFIq8UvBMwS1sANUmDJ68JbPWBpLDnYzaieX8aoecCsaTTHqcbPvkc3eL0RVdeVaLPR f8VrkMLb4aRG9Zt/1DBZ/9TuQymrsVSmQ2EpBe8fxCn6BY3fCaPaDEGpio5wEZhHy/uG ZDoIIafSjYANZ1BrHIXMMsCZDN7ER5poG2x0/ZrnTMZX9OR8FeOEX6w1MqUl9ALDahvy Tk7gKhTxelFEJIPr6qGeNshE0UXzr5X/4pDyc83DHVliZcePdp4Gnn9Ht2pA0GSANTco 6baA== X-Forwarded-Encrypted: i=1; AJvYcCU8x6uYvDxN/4wBRpWvS99lFmdPRHsPqKDeN+CWjdGTuQlgZD+xoVEhzklzhz4+h85WheqaTuF48WbYxTI+XG1b@lists.infradead.org X-Gm-Message-State: AOJu0YwCpIdujnekMGisXrTRUN11fU2+LGeeshkP0EOrZtNJBnDCsFFF dtLbIRQEgEFTYESa8X+et+snFkOeU888nfNWCIOKwQVl1QibqNgXcnq5mEwgVdM= X-Google-Smtp-Source: AGHT+IGWNpBp0JEJJKNe7VJxVt4ola9QUy4T9WHvT1vG5vjPcbQJy+069xnc1aIkGvbTJudOOVEgTw== X-Received: by 2002:a17:902:e80f:b0:205:5f95:c283 with SMTP id d9443c01a7336-2074c5d28d9mr77798925ad.4.1726080014877; Wed, 11 Sep 2024 11:40:14 -0700 (PDT) Received: from [192.168.0.122] ([59.188.211.160]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2076b039539sm2541905ad.309.2024.09.11.11.40.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Sep 2024 11:40:14 -0700 (PDT) Message-ID: Date: Thu, 12 Sep 2024 02:40:09 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/22] dt-bindings: arm: cpus: Add Apple A7-A11 CPU cores Content-Language: en-MW To: Conor Dooley Cc: Hector Martin , Sven Peter , Alyssa Rosenzweig , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Rafael J . Wysocki" , Viresh Kumar , Linus Walleij , Wim Van Sebroeck , Guenter Roeck , Catalin Marinas , Will Deacon , Lorenzo Pieralisi , Mark Kettenis , asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org, Konrad Dybcio , Ivaylo Ivanov References: <20240911084353.28888-2-towinchenmi@gmail.com> <20240911084353.28888-3-towinchenmi@gmail.com> <20240911-unsuited-pranker-60a7d0b6caf9@spud> From: Nick Chan In-Reply-To: <20240911-unsuited-pranker-60a7d0b6caf9@spud> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240911_114016_538046_31A61D41 X-CRM114-Status: GOOD ( 21.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 12/9/2024 02:16, Conor Dooley wrote: > On Wed, Sep 11, 2024 at 04:40:51PM +0800, Nick Chan wrote: >> Add the following CPU cores: >> >> - apple,cyclone: A7 cores >> - apple,typhoon: A8 cores >> - apple,twister: A9 cores >> - apple,hurricane-zephyr: A10 logical cores >> - apple,monsoon: A11 performance cores >> - apple,mistral: A11 efficiency cores >> >> In the Apple A10, there are physical performance-efficiency cores that >> forms logical cores to software depending on the current p-state, and >> only one type of core may be active at one time. >> >> Signed-off-by: Nick Chan >> --- >> Documentation/devicetree/bindings/arm/cpus.yaml | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/arm/cpus.yaml b/Documentation/devicetree/bindings/arm/cpus.yaml >> index f308ff6c3532..3959e022079f 100644 >> --- a/Documentation/devicetree/bindings/arm/cpus.yaml >> +++ b/Documentation/devicetree/bindings/arm/cpus.yaml >> @@ -89,6 +89,12 @@ properties: >> - apple,blizzard >> - apple,icestorm >> - apple,firestorm >> + - apple,mistral >> + - apple,monsoon >> + - apple,hurricane-zephyr >> + - apple,twister >> + - apple,typhoon >> + - apple,cyclone > > Same on this one, can you add these in alphanumerical order, even if the > existing 3 devices are not in it? You could take the opportunity to > reshuffle icestorm and firestorm while you're at it. (Same goes for the watchdog, pinctrl and cluster-cpufreq bindings) I am not actually sure what is the right thing to do here. It seems that these bindings are originally sorted using SoC types (desktop or mobile) and generations. But then again I have looked at some other in-tree bindings from asahi, and it seems to be a mix of alphabetical and logical sorting in the way mentioned above. Maybe we can get some clarification from an Asahi Maintainer? For the soc-level machine compatibles though, I believe that should be retaining the logical order instead of trying to use alphabetical order. > > Cheers, > Conor. > >> - arm,arm710t >> - arm,arm720t >> - arm,arm740t >> -- >> 2.46.0 >> Nick Chan