From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82A82C47074 for ; Thu, 4 Jan 2024 15:42:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=939vHdMVjsJ6JS4qiq2UXS0+hHVtM57E4LHJzdDmclI=; b=JNT6Zx4QRpfjA8 WaWdhDZH16/mGtM74jMJNlhCiKJPjGwieCsZ2+bUBR/L/2ykbJZCqQiwwgh/4c1djOQSAWQY4j7LE lxGohA2c1/BRlxMISidcADw5vBnx6zEzEAkLne2106fBo9wgvBbkZB5c2Ef0z4NcKTiXFPJtDjMnn l1jBFWVrge4VSllZCZlSIHEbYCdbAh4cdK06QxsvW4FVKA7G6K/v9pIUAwBQcuVvAf8gduHkPsd0G Latas8/NEN6XdPWH0FUMDYxvhy/FU7TZolf5RV/bpM1XrQBmftpcVpWFQBDNDoERVvj/jjX+G9N1N vfR+Dl7F/8MHswYBLWUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rLPqi-00EX1G-1o; Thu, 04 Jan 2024 15:41:36 +0000 Received: from mail-ed1-x530.google.com ([2a00:1450:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rLPqg-00EX0b-09 for linux-arm-kernel@lists.infradead.org; Thu, 04 Jan 2024 15:41:35 +0000 Received: by mail-ed1-x530.google.com with SMTP id 4fb4d7f45d1cf-55719cdc0e1so124087a12.1 for ; Thu, 04 Jan 2024 07:41:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704382891; x=1704987691; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=F7/ShbpEf54yAHHl4FpslzJHf7YewK4v2kQSkVZU+B4=; b=Xr4Pad8HDVGXGaMB7igIEXEOxjEoYOsS9pZawGb5npJWtNVNE1xfxEcHOMXz76ncXc 2qR5tjxXt6maSZzIOiODOq/08ylLuvFdz99JJrEXLJ/D1q9y72HcOYe+oH9HuEbL41t8 FhnYNnz6EiXd8uFa44K46ax77IP+DKCdK5Z4PS1GA6IpIpJprTiMWcSgPDggPf4lgnER HGxH0DC9nRrt7CdZ/xqd2cgDyL3jTMHU0Xfh+20+HsdlF/DVGAOJo8QZu74ngzM8c3Lq bXX3yT/KZ/FyctmTMbqItEFVFNPzSyZ0nnkXtvXTtR9eNamjUJLe8AO09uX4MJ964jfp Qi9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704382891; x=1704987691; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=F7/ShbpEf54yAHHl4FpslzJHf7YewK4v2kQSkVZU+B4=; b=VHe5Ywab6/0weJ6xwE2FBtb6G/xsT/U4wiir7Rz4fDoGJE/airSo7PntEq6UvlXbgJ xwmAizQX4USZDgFlB68fPwYbB9PaB4v1fCtuvwU9AlhsxNm7fZtkPfg0iaFDfsGGpgMa iHc6NUoDiwPB1yx1teQOpVYj+ndiMMbLi1z9Kivq2uDHoTzLfPhyPQ/7VyiIu12tU9Ix 51ykcVeiQCmvxqvB885Zd8njRbtDfL4h7tQ7zJDyk5lYCLuebat1VVPBXfdlprBOpc5M CREh2sTbURnSdSsKGa76frj64Uf4zDUTYj7LtnvfhMC2aEU6eKGiVFR759lz949WNfbI DtJg== X-Gm-Message-State: AOJu0YwZliS4n3F74jUs3LvbFB6bxqgAygi+Qnysxs9WmA468Wm2dkLV DhKIvGiH/iHnwUjZu9izPS5ANT6I/S0ovQ== X-Google-Smtp-Source: AGHT+IEah0e7M2KrNungIWa3+GEmC8D68fB1t4UAkc0BcqWffzA+XwCkKbcFVX1Hg/VoQkLod6TmbQ== X-Received: by 2002:a17:906:3a09:b0:a26:a245:9cef with SMTP id z9-20020a1709063a0900b00a26a2459cefmr351361eje.64.1704382891320; Thu, 04 Jan 2024 07:41:31 -0800 (PST) Received: from [192.168.2.107] ([79.115.63.202]) by smtp.gmail.com with ESMTPSA id c15-20020a170906d18f00b00a28ba0c3821sm1132678ejz.101.2024.01.04.07.41.29 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 04 Jan 2024 07:41:30 -0800 (PST) Message-ID: Date: Thu, 4 Jan 2024 15:41:28 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 04/12] tty: serial: samsung: prepare for different IO types Content-Language: en-US To: Greg KH Cc: peter.griffin@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, sboyd@kernel.org, conor+dt@kernel.org, andi.shyti@kernel.org, alim.akhtar@samsung.com, jirislaby@kernel.org, s.nawrocki@samsung.com, tomasz.figa@gmail.com, cw00.choi@samsung.com, arnd@arndb.de, semen.protsenko@linaro.org, andre.draszik@linaro.org, saravanak@google.com, willmcvicker@google.com, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-serial@vger.kernel.org, kernel-team@android.com References: <20231228125805.661725-1-tudor.ambarus@linaro.org> <20231228125805.661725-5-tudor.ambarus@linaro.org> <2024010432-taco-moneyless-53e2@gregkh> From: Tudor Ambarus In-Reply-To: <2024010432-taco-moneyless-53e2@gregkh> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240104_074134_089449_52698E97 X-CRM114-Status: GOOD ( 20.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 1/4/24 15:32, Greg KH wrote: > On Thu, Dec 28, 2023 at 12:57:57PM +0000, Tudor Ambarus wrote: >> GS101's Connectivity Peripheral blocks (peric0/1 blocks) which >> include the I3C and USI (I2C, SPI, UART) only allow 32-bit >> register accesses. If using 8-bit register accesses, a SError >> Interrupt is raised causing the system unusable. >> >> Instead of specifying the reg-io-width = 4 everywhere, for each node, >> the requirement should be deduced from the compatible. >> >> Prepare the samsung tty driver to allow IO types different than >> UPIO_MEM. ``struct uart_port::iotype`` is an unsigned char where all >> its 8 bits are exposed to uapi. We can't make NULL checks on it to >> verify if it's set, thus always set it from the driver's data. >> >> Signed-off-by: Tudor Ambarus >> --- >> v2: new patch >> >> drivers/tty/serial/samsung_tty.c | 9 ++++++++- >> 1 file changed, 8 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/tty/serial/samsung_tty.c b/drivers/tty/serial/samsung_tty.c >> index 66bd6c090ace..97ce4b2424af 100644 >> --- a/drivers/tty/serial/samsung_tty.c >> +++ b/drivers/tty/serial/samsung_tty.c >> @@ -72,6 +72,7 @@ struct s3c24xx_uart_info { >> const char *name; >> enum s3c24xx_port_type type; >> unsigned int port_type; >> + unsigned char iotype; >> unsigned int fifosize; >> unsigned long rx_fifomask; >> unsigned long rx_fifoshift; > > Is there a reason you are trying to add unused memory spaces to this > structure for no valid reason? I don't think you could have picked a > more incorrect place in there to add this :) > > Please fix. > Will put it after "const char *name". Thanks, ta _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel