From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 39574EB8FA5 for ; Wed, 6 Sep 2023 08:49:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RrtmJuZe6Rb6VbQZ8xE+QMWbofSfY9j8AgIAJZ1Q9k4=; b=m0n4lhKLG3gXqC SuuwutXMww9lidc2JzsFWxhiPU84Q+3qzt2A7PgERjdzYUndJg6zNCZJtrhDFYe1w7Yg6MK4CR73f a1VXI9nOLKI6mD6G2+dd0CNIDEUxjIHloAP2SszgAAvGj3FH+VatmiTaCz/HCvaiaXP7tkeS9B2w3 OzfRYzfxY8dMjfbbbiXO9igoVgazep2CAQGoZ50Wc7r6YPL3HAsheuhc5jqPxKf8/+i9HxjFG49EB eNxp6NhaT3hq56eb5yOFMylUcJkFMyD2D8j09yj+7A8XeEfq0iyMY3iFD5gBEysaVFE+Rnxv5l2LO 43zF8POypcrCP2GVhr0g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qdoDC-007nKC-38; Wed, 06 Sep 2023 08:48:34 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdoDA-007nJT-1c for linux-arm-kernel@bombadil.infradead.org; Wed, 06 Sep 2023 08:48:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date:Message-ID: Sender:Reply-To:Content-ID:Content-Description; bh=RrCIcjF1rY1mMD/Gu+r4tbPGrpOuOBfXe5P30B5qf1Q=; b=aNIcnJfoJLIZari4eFXnCQJVYX +r+qdoLhPBFZDtR2AY4wrvRcWizLJPLG8CRysCA1vgYH32woMABnn9A4TxB/KT8SjlYMuckZFFOeJ gm/fvdal4vvgydvyJFjq/kSne4ULj65KTtGzBNIq/53TrFASn10p7Sy4fTTsAlQmuBYz56euvwJ3/ YkRgd6uw1y9vFJ5R55saw2mVs5+2bQAdJJpeBTwACm+orbfIQyX8+lAj3aO1qr7gpfO13fPmINCVr m87sidZGP6wRGOhKDQ4ggPkbiQZspOA8lYn6+b1f+NJHm0wcxOOpeK47th+HHWR8w2FbkuXvOvEy7 pc9968vg==; Received: from mail-ej1-x62f.google.com ([2a00:1450:4864:20::62f]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qdoD3-000zYr-2D for linux-arm-kernel@lists.infradead.org; Wed, 06 Sep 2023 08:48:30 +0000 Received: by mail-ej1-x62f.google.com with SMTP id a640c23a62f3a-9936b3d0286so525757866b.0 for ; Wed, 06 Sep 2023 01:48:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1693990105; x=1694594905; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=RrCIcjF1rY1mMD/Gu+r4tbPGrpOuOBfXe5P30B5qf1Q=; b=qH89XQ3MLpMnWlWtoKHEYHOCgMhkj8gvP3V2qQbV/eLnTLALulCB8TyqgsYCChOHmK HsIgFNoa/VSRVQXEka+CcoSvOE0JgDyT0vEbS45+YaCsGMIfx30eML6ZY24BLDGTFVpB DkhyfHelG3dDuQZp8AaNOigTBl5tMcsEzQ6qtB2Djc3Pbs5XjNiRgFV6C8ExhWRjOKgg agrEkKimrr8JGNdvUGlGQU8HoA+1mBwHpyaKiWJWTlqhU5w00rZzdzR1vHE9qOffX7NT uCfb3qcZ3gTg+aicMB6604c8Px5w9nTUfLp9XNU8cvh201+//20f4xmykM4mSyQqHyru Q+vg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693990105; x=1694594905; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=RrCIcjF1rY1mMD/Gu+r4tbPGrpOuOBfXe5P30B5qf1Q=; b=jB3xtAJkIwDbUz2zK26SEKAMd9SZ31kJyj2y4nT77yLGPXzpzCklDjVTY1a2vikLYh Eh1cWzSm5/Pu6mDrEBrlyUMchjA33aDh2UshyLwSvF/ohx6ic1yfwRYH4u9uZIZFJNWm YELgYSYimKhDlqhbNKq/tP36jGe/AArfT9EBmlrX+B0FuNWisXyIVO/6/60xRbnkSoff IDIVBe3eBWYE+L+i0zU6mlooLLFrNnCJOq4h2MsYsxpfugr460xrmO67loJ68tNtNJ0K pL+2SC03BYdWbuGZ+hfYiSJR5vUrIXbFNdqGu2EjsB0+LtB3EPIskb1bY69IbWZVYz4B MI5w== X-Gm-Message-State: AOJu0YwRhNxOUKksUhwwbjulnk4CHSNHIqSzFMR97T0qHjSc8hC68PRA DiBYKt5RyLHq1xMZ1K0l82gPug== X-Google-Smtp-Source: AGHT+IH8UP4xS9z1tEun/6EHP9/nk72OwvNjGqpg0zwCljUObKiMg7WpCrPYbEl9OzalF7MYJfPYtA== X-Received: by 2002:a17:906:cc4e:b0:9a2:292d:ea63 with SMTP id mm14-20020a170906cc4e00b009a2292dea63mr1570271ejb.37.1693990105263; Wed, 06 Sep 2023 01:48:25 -0700 (PDT) Received: from [192.168.0.22] (77-252-46-238.static.ip.netia.com.pl. [77.252.46.238]) by smtp.gmail.com with ESMTPSA id ov22-20020a170906fc1600b00992c92af6f4sm8841374ejb.144.2023.09.06.01.48.24 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Sep 2023 01:48:24 -0700 (PDT) Message-ID: Date: Wed, 6 Sep 2023 10:48:23 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 3/3] arm64: dts: mediatek: mt8365-pumpkin: Add overlays for thp7312 cameras Content-Language: en-US To: Laurent Pinchart Cc: Paul Elder , linux-media@vger.kernel.org, Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Hans Verkuil , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org References: <20230905233118.183140-1-paul.elder@ideasonboard.com> <20230905233118.183140-4-paul.elder@ideasonboard.com> <502fc7b1-a32d-6901-3a45-d2aa0e0c3849@linaro.org> <20230906083237.GL7971@pendragon.ideasonboard.com> From: Krzysztof Kozlowski In-Reply-To: <20230906083237.GL7971@pendragon.ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230906_094827_973929_761FB53C X-CRM114-Status: GOOD ( 28.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 06/09/2023 10:32, Laurent Pinchart wrote: > Hi Krzysztof, > > On Wed, Sep 06, 2023 at 09:27:07AM +0200, Krzysztof Kozlowski wrote: >> On 06/09/2023 01:31, Paul Elder wrote: >>> Add overlays for the Pumpkin i350 to support THP7312 cameras. >>> >>> Signed-off-by: Paul Elder >>> --- >>> arch/arm64/boot/dts/mediatek/Makefile | 4 + >>> .../mt8365-pumpkin-common-thp7312.dtsi | 23 ++++++ >>> .../mt8365-pumpkin-csi0-thp7312-imx258.dtso | 73 +++++++++++++++++++ >>> .../mt8365-pumpkin-csi1-thp7312-imx258.dtso | 73 +++++++++++++++++++ >>> 4 files changed, 173 insertions(+) >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi0-thp7312-imx258.dtso >>> create mode 100644 arch/arm64/boot/dts/mediatek/mt8365-pumpkin-csi1-thp7312-imx258.dtso >>> >>> diff --git a/arch/arm64/boot/dts/mediatek/Makefile b/arch/arm64/boot/dts/mediatek/Makefile >>> index 20570bc40de8..ceaf24105001 100644 >>> --- a/arch/arm64/boot/dts/mediatek/Makefile >>> +++ b/arch/arm64/boot/dts/mediatek/Makefile >>> @@ -56,4 +56,8 @@ dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-evk.dtb >>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8365-pumpkin.dtb >>> dtb-$(CONFIG_ARCH_MEDIATEK) += mt8516-pumpkin.dtb >>> >>> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi0-thp7312-imx258.dtbo >>> +mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-csi1-thp7312-imx258.dtbo >>> mtk-mt8365-pumpkin-dtbs := mt8365-pumpkin.dtb mt8365-pumpkin-ethernet-usb.dtbo >>> + >>> +dtb-$(CONFIG_ARCH_MEDIATEK) += mtk-mt8365-pumpkin.dtb >>> diff --git a/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> new file mode 100644 >>> index 000000000000..478697552617 >>> --- /dev/null >>> +++ b/arch/arm64/boot/dts/mediatek/mt8365-pumpkin-common-thp7312.dtsi >>> @@ -0,0 +1,23 @@ >>> +// SPDX-License-Identifier: GPL-2.0 >>> +/* >>> + * Copyright (c) 2023 Ideas on Board >>> + * Author: Paul Elder >>> + */ >>> + >>> +/dts-v1/; >>> +/plugin/; >>> + >>> +&{/} { >>> + vsys_v4p2: regulator@0 { >> >> Hm? Is this a bus? > > There are multiple instances of "numbered" regulators in upstream DT > files, for instance arch/arm/boot/dts/nxp/imx/imx6qdl-nitrogen6_max.dtsi That's the only example I saw... I fixed it now. > has a regulator@0. There are similar instances for clocks. > > I understand why it may not be a good idea, and how the root node is > indeed not a bus. In some cases, those regulators and clocks are grouped > in a regulators or clocks node that has a "simple-bus" compatible. I'm > not sure if that's a good idea, but at least it should validate. > > What's the best practice for discrete board-level clocks and regulators > in overlays ? How do we ensure that their node name will not conflict > with the board to which the overlay is attached ? Top-level nodes (so under /) do not have unit addresses. If they have - it's an error, because it is not a bus. Also, unit address requires reg. No reg? No unit address. DTC reports this as warnings as well. >>> + orientation = <0>; >>> + rotation = <0>; >>> + >>> + thine,rx,data-lanes = <4 1 3 2>; >> >> NAK for this property. > > Please explain why. You commented very briefly in the bindings review, > and it wasn't clear to me if you were happy or not with the property, > and if not, why. Because it is duplicating endpoint. At least from the description. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel