From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DF218C6FD1D for ; Wed, 15 Mar 2023 15:53:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BH4sQX2an4+w+O5ljXbmXk8LiPl7NSfjVUfcMTsRz5A=; b=2OIm8oxyyob2Qw +s7rF90P4lFKD88v38UNTABOaiZPigpgAid/zLsw+4SB7bWkRyCCQd25QqHIERMoJOnegBcqt4m11 O7jCdoh1b+O0P7QgXQLqBLd3P1HScTidKOBHwyN87fsMKV5kXrnZx3kkfyeWQTayOd7INxfYI/jHG q9dHJZntPAopsS/ZgTyVs2vwHwu9G5+bt3odhW+BeJumsqrtxO8URlRYhtxjzHCkf2mV8+Jt5+Dyi TzrVh1KASC9M8Z3UpcJcHT0RJMLbhJGjB9XQ7N3nYGqyrQFxGpAfOWzAKgN8EOzZF8of1xjNDybDy N2ruWRXhwPiBSAHrmPqg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pcTR1-00Dx4b-0a; Wed, 15 Mar 2023 15:53:03 +0000 Received: from out-27.mta0.migadu.com ([91.218.175.27]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pcTQp-00Dwzt-1e for linux-arm-kernel@lists.infradead.org; Wed, 15 Mar 2023 15:52:53 +0000 Message-ID: DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1678895567; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LAZRybupTvQEP0hHnGktZ9GfjVa1Kn4GHkLJyjxmJqc=; b=tFSK0itZaddcvsbD3fAZ9iXUM0mQS0REsGD8wAg1x+9tvOgAED3Tiak+5dNwulyIDk6r+b vJB3jicZXYqgY4aqwugxCaJtviRADODqZy0M6g3TdD2eSzoBh7Sv3bxekgEheC/CGwIh0M AA7w63hptaRkbZZybILr5Y9bvmJGc/s= Date: Wed, 15 Mar 2023 15:52:43 +0000 MIME-Version: 1.0 Subject: Re: [PATCH RFC v6 6/6] ptp_ocp: implement DPLL ops Content-Language: en-US To: Jiri Pirko , Vadim Fedorenko Cc: Jakub Kicinski , Arkadiusz Kubalewski , Jonathan Lemon , Paolo Abeni , poros@redhat.com, mschmidt@redhat.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org References: <20230312022807.278528-1-vadfed@meta.com> <20230312022807.278528-7-vadfed@meta.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Vadim Fedorenko In-Reply-To: X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230315_085251_965414_7FCEFBDD X-CRM114-Status: UNSURE ( 7.56 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 15/03/2023 15:34, Jiri Pirko wrote: > Sun, Mar 12, 2023 at 03:28:07AM CET, vadfed@meta.com wrote: > > [...] > >> @@ -4226,8 +4377,44 @@ ptp_ocp_probe(struct pci_dev *pdev, const struct pci_device_id *id) >> >> ptp_ocp_info(bp); >> devlink_register(devlink); >> - return 0; >> >> + clkid = pci_get_dsn(pdev); >> + bp->dpll = dpll_device_get(clkid, 0, THIS_MODULE); >> + if (!bp->dpll) { > > You have to use IS_ERR() here. Same problem in ice. > Yep, fixed, thanks! _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel