public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Swamil Jain <s-jain1@ti.com>
Cc: jyri.sarha@iki.fi, tomi.valkeinen@ideasonboard.com,
	maarten.lankhorst@linux.intel.com, mripard@kernel.org,
	tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch,
	nm@ti.com, vigneshr@ti.com, kristo@kernel.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, lee@kernel.org,
	louis.chauvet@bootlin.com, aradhya.bhatia@linux.dev,
	devarsht@ti.com, praneeth@ti.com, h-shenoy@ti.com,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v2 2/5] dt-bindings: mfd: syscon: Add ti,am625-dss-clk-ctrl
Date: Fri, 7 Nov 2025 08:56:50 +0100	[thread overview]
Message-ID: <a40e8329-0423-49a9-8675-3a3ecb9c9134@kernel.org> (raw)
In-Reply-To: <20251107-ambrosial-soft-grebe-ebaa3b@kuoka>

On 07/11/2025 08:50, Krzysztof Kozlowski wrote:
> On Thu, Nov 06, 2025 at 07:42:24PM +0530, Swamil Jain wrote:
>> From: Louis Chauvet <louis.chauvet@bootlin.com>
>>
>> The dt-bindings for the multi-function device (mfd) syscon need to include
>> ti,am625-dss-clk-ctrl. On AM62X, AM62A and AM62P devicess, the display
>> controller (tidss) has external registers to control certain clock
>> properties. These registers are located in the device configuration
>> registers, so they need to be declared using syscon. They will later be
>> used with a phandle in the tidss node.
>>
>> Fixes: ad2ac9dc9426 ("drm/tidss: Add support for AM625 DSS")
>> Fixes: 5cc5ea7b6d7b ("drm/tidss: Add support for AM62A7 DSS")
> 
> Adding missing hardware is not a fix. Drop both.
> 
>> Cc: stable@vger.kernel.org
> 
> For sure not a stable commit. You just add new hardware.
> 
>> Signed-off-by: Louis Chauvet <louis.chauvet@bootlin.com>
>> Signed-off-by: Swamil Jain <s-jain1@ti.com>
>> ---
>>  Documentation/devicetree/bindings/mfd/syscon.yaml | 3 ++-
>>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> With these fixed/dropped:
> 
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Un-acked, NAK.

You just ignored previous feedback.

Best regards,
Krzysztof


  reply	other threads:[~2025-11-07  7:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-06 14:12 [RESEND PATCH v2 0/5] drm/tidss: Fixes data edge sampling on AM62X and AM62A Swamil Jain
2025-11-06 14:12 ` [RESEND PATCH v2 1/5] dt-bindings: display: ti,am65x-dss: Add clk property for data edge synchronization Swamil Jain
2025-11-07  7:54   ` Krzysztof Kozlowski
2025-11-07  7:56     ` Krzysztof Kozlowski
2025-11-06 14:12 ` [RESEND PATCH v2 2/5] dt-bindings: mfd: syscon: Add ti,am625-dss-clk-ctrl Swamil Jain
2025-11-07  7:50   ` Krzysztof Kozlowski
2025-11-07  7:56     ` Krzysztof Kozlowski [this message]
2025-11-06 14:12 ` [RESEND PATCH v2 3/5] arm64: dts: ti: k3-am62-main: Add tidss clk-ctrl property Swamil Jain
2025-11-07  7:57   ` Krzysztof Kozlowski
2025-11-06 14:12 ` [RESEND PATCH v2 4/5] arm64: dts: ti: k3-am62a-main: " Swamil Jain
2025-11-07  7:58   ` Krzysztof Kozlowski
2025-11-06 14:12 ` [RESEND PATCH v2 5/5] drm/tidss: Fix sampling edge configuration Swamil Jain
2025-11-07  7:59   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a40e8329-0423-49a9-8675-3a3ecb9c9134@kernel.org \
    --to=krzk@kernel.org \
    --cc=airlied@gmail.com \
    --cc=aradhya.bhatia@linux.dev \
    --cc=conor+dt@kernel.org \
    --cc=devarsht@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=h-shenoy@ti.com \
    --cc=jyri.sarha@iki.fi \
    --cc=kristo@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=louis.chauvet@bootlin.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nm@ti.com \
    --cc=praneeth@ti.com \
    --cc=robh@kernel.org \
    --cc=s-jain1@ti.com \
    --cc=simona@ffwll.ch \
    --cc=tomi.valkeinen@ideasonboard.com \
    --cc=tzimmermann@suse.de \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox