linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: hramrach@gmail.com (Michal Suchanek)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/9] spi: sun4i: fix FIFO limit
Date: 20 Aug 2015 14:19:46 -0000	[thread overview]
Message-ID: <a40fbf7ca8bd36f08f5e9d3fb6f6de2454066af7.1440080122.git.hramrach@gmail.com> (raw)
In-Reply-To: <cover.1440080122.git.hramrach@gmail.com>

When testing SPI without DMA I noticed that filling the FIFO on the
spi controller causes timeout.

Always leave room for one byte in the FIFO.

Signed-off-by: Michal Suchanek <hramrach@gmail.com>
---
 drivers/spi/spi-sun4i.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/spi/spi-sun4i.c b/drivers/spi/spi-sun4i.c
index 48532ec..707f61b 100644
--- a/drivers/spi/spi-sun4i.c
+++ b/drivers/spi/spi-sun4i.c
@@ -178,6 +178,8 @@ static int sun4i_spi_transfer_one(struct spi_master *master,
 	/* We don't support transfer larger than the FIFO */
 	if (tfr->len > SUN4I_FIFO_DEPTH)
 		return -EINVAL;
+	if (tfr->tx_buf && tfr->len => SUN4I_FIFO_DEPTH)
+		return -EINVAL;
 
 	reinit_completion(&sspi->done);
 	sspi->tx_buf = tfr->tx_buf;
@@ -271,7 +273,9 @@ static int sun4i_spi_transfer_one(struct spi_master *master,
 	sun4i_spi_write(sspi, SUN4I_XMIT_CNT_REG, SUN4I_XMIT_CNT(tx_len));
 
 	/* Fill the TX FIFO */
-	sun4i_spi_fill_fifo(sspi, SUN4I_FIFO_DEPTH);
+	/* Filling the fifo fully causes timeout for some reason
+	 * at least on spi2 on a10s */
+	sun4i_spi_fill_fifo(sspi, SUN4I_FIFO_DEPTH - 1);
 
 	/* Enable the interrupts */
 	sun4i_spi_write(sspi, SUN4I_INT_CTL_REG, SUN4I_INT_CTL_TC);
-- 
2.1.4

  parent reply	other threads:[~2015-08-20 14:19 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-20 14:15 [PATCH 0/9] spi/sunxi patches Michal Suchanek
2015-08-20 14:19 ` [PATCH 1/9] spi: sunxi: fix transfer timeout Michal Suchanek
2015-08-20 14:43   ` Maxime Ripard
2015-08-20 18:41   ` Mark Brown
2015-08-20 19:34     ` Maxime Ripard
2015-08-20 21:08       ` Mark Brown
2015-08-20 21:18         ` Maxime Ripard
2015-08-20 21:29           ` Mark Brown
2015-08-20 14:19 ` [PATCH 3/9] spi: sunxi: check that transfer speed is non-zero Michal Suchanek
2015-08-20 14:48   ` Maxime Ripard
2015-08-20 19:45     ` Michal Suchanek
2015-08-20 21:23       ` Maxime Ripard
2015-08-20 18:45   ` Mark Brown
2015-08-20 14:19 ` [PATCH 5/9] ARM: dts: sun7i: cubieboard2: Enable SPI0 Michal Suchanek
2015-08-20 14:58   ` Maxime Ripard
2015-08-20 14:19 ` Michal Suchanek [this message]
2015-08-20 14:45   ` [PATCH 2/9] spi: sun4i: fix FIFO limit Maxime Ripard
2015-08-20 14:19 ` [PATCH 4/9] spi: sun4i: add DMA support Emilio López
2015-08-20 14:24   ` [linux-sunxi] " Michal Suchanek
2015-08-20 14:56   ` Maxime Ripard
2015-08-20 18:58   ` Mark Brown
2016-05-17  5:44     ` [linux-sunxi] " Michal Suchanek
2015-08-20 19:00   ` Mark Brown
2015-08-20 14:19 ` [PATCH 6/9] ARM: dts: sunxi: add spi aliases on cubieboards Michal Suchanek
2015-08-20 14:19 ` [PATCH 7/9] ARM: dts: sun5i: add SPI pins on A13 and A10s Michal Suchanek
2015-08-20 15:00   ` Maxime Ripard
2015-08-20 14:19 ` [PATCH 9/9] ARM: dts: sunxi: Add SPI aliases on A10s Olinuxino Michal Suchanek
2015-08-20 14:19 ` [PATCH 8/9] ARM: dts: sunxi: A10s Olinuxino Micro: add spi2 Michal Suchanek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a40fbf7ca8bd36f08f5e9d3fb6f6de2454066af7.1440080122.git.hramrach@gmail.com \
    --to=hramrach@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).