From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6B4EEC64EC4 for ; Thu, 9 Mar 2023 11:53:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:CC:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vnseod0auukoZXlMSFYO/IzO7Ks9xy7KuhEcvsBXg4w=; b=vK3o+JBw52zisi xvJ7XiJEGum772nIDJ73/iL7g8w3DkOZ6Yq0BrKfRCFGCyeg3axZbunGlxLoDj4aCXCHe5wMY6zTD LkuQr/G8sno08Hucf2nNYeP5h2RXl2KA6EkUt09P7W5YCtBxJfN7fkhJ99Mv0ssB1BwQxbywc7dbj AAqZZe97DGFc34HKPjFrSyRzA/4AMiN4nUid1HSedy3Trx8xCuwnVRN2tXcUaDb81RqiyXJf3a0hH DJUTvGP3V6bfdE94JLnu0mjn14+TQMW+7s8CMe3vrofcAaW2EmOeRotZV5WRiawRIxKhnkvJSI8ol RPNHGhT1f4x9CroRXaIw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1paEpC-009gXo-NL; Thu, 09 Mar 2023 11:52:47 +0000 Received: from lelv0143.ext.ti.com ([198.47.23.248]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1paEUM-009WiV-3V for linux-arm-kernel@lists.infradead.org; Thu, 09 Mar 2023 11:31:18 +0000 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 329BV5Fv019998; Thu, 9 Mar 2023 05:31:05 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1678361465; bh=PVFsQ2KDP+Vkk1afSUgI+AQ9InzXNc5xwXMybxvdwSw=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=MpSE924ZKyhRfViXEDZgjXmip4NIjHXb7dNtr/UAvumbyANXqfzWwiXNHn0c44PNW C3iDsxSq6EGcmSuHfgZlvlrROAzeALcUC/BGhQDXYzwNST2Zirq4xvMkwGml//wWr9 o6oYACPa5ylKEz/OMwK+PLsAa7h/IqVLawnUnejw= Received: from DFLE101.ent.ti.com (dfle101.ent.ti.com [10.64.6.22]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 329BV5Ev035566 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 9 Mar 2023 05:31:05 -0600 Received: from DFLE106.ent.ti.com (10.64.6.27) by DFLE101.ent.ti.com (10.64.6.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Thu, 9 Mar 2023 05:31:04 -0600 Received: from fllv0039.itg.ti.com (10.64.41.19) by DFLE106.ent.ti.com (10.64.6.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Thu, 9 Mar 2023 05:31:04 -0600 Received: from [10.24.69.114] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by fllv0039.itg.ti.com (8.15.2/8.15.2) with ESMTP id 329BUxNf006862; Thu, 9 Mar 2023 05:31:00 -0600 Message-ID: Date: Thu, 9 Mar 2023 17:00:59 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [EXTERNAL] Re: [EXTERNAL] Re: [PATCH v3 3/6] soc: ti: pruss: Add pruss_cfg_read()/update() API Content-Language: en-US To: Roger Quadros , MD Danish Anwar , "Andrew F. Davis" , Suman Anna , Vignesh Raghavendra , Mathieu Poirier , Bjorn Andersson , Santosh Shilimkar , Nishanth Menon CC: , , , , , , References: <20230306110934.2736465-1-danishanwar@ti.com> <20230306110934.2736465-4-danishanwar@ti.com> <7076208d-7dca-6980-5399-498e55648740@kernel.org> From: Md Danish Anwar Organization: Texas Instruments In-Reply-To: X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230309_033114_413148_A9E7BD09 X-CRM114-Status: GOOD ( 19.76 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Roger, On 08/03/23 17:12, Roger Quadros wrote: > > > On 08/03/2023 13:36, Md Danish Anwar wrote: >> Hi Roger, >> >> On 08/03/23 13:57, Roger Quadros wrote: >>> Hi, >>> >>> On 06/03/2023 13:09, MD Danish Anwar wrote: >>>> From: Suman Anna >>>> >>>> Add two new generic API pruss_cfg_read() and pruss_cfg_update() to >>>> the PRUSS platform driver to allow other drivers to read and program >>>> respectively a register within the PRUSS CFG sub-module represented >>>> by a syscon driver. This interface provides a simple way for client >>> >>> Do you really need these 2 functions to be public? >>> I see that later patches (4-6) add APIs for doing specific things >>> and that should be sufficient than exposing entire CFG space via >>> pruss_cfg_read/update(). >>> >>> >> >> I think the intention here is to keep this APIs pruss_cfg_read() and >> pruss_cfg_update() public so that other drivers can read / modify PRUSS config >> when needed. > > Where are these other drivers? If they don't exist then let's not make provision > for it now. > We can provide necessary API helpers when needed instead of letting client drivers > do what they want as they can be misused and hard to debug. > The ICSSG Ethernet driver uses pruss_cfg_update() API. It is posted upstream in the series [1]. The ethernet driver series is dependent on this series. In series [1] we are using pruss_cfg_update() in icssg_config.c file, icssg_config() API. So for this, the API pruss_cfg_update() needs to be public. [1] https://lore.kernel.org/all/20230210114957.2667963-3-danishanwar@ti.com/ >> >> The later patches (4-6) add APIs to do specific thing, but those APIs also >> eventually call pruss_cfg_read/update(). > > They can still call them but they need to be private to pruss.c > >> >>>> drivers without having them to include and parse the CFG syscon node >>>> within their respective device nodes. Various useful registers and >>>> macros for certain register bit-fields and their values have also >>>> been added. >>>> >>>> It is the responsibility of the client drivers to reconfigure or >>>> reset a particular register upon any failures. >>>> >>>> Signed-off-by: Suman Anna >>>> Co-developed-by: Grzegorz Jaszczyk >>>> Signed-off-by: Grzegorz Jaszczyk >>>> Signed-off-by: Puranjay Mohan >>>> --- >>>> drivers/soc/ti/pruss.c | 41 +++++++++++++ >>>> include/linux/remoteproc/pruss.h | 102 +++++++++++++++++++++++++++++++ >>>> 2 files changed, 143 insertions(+) >>>> >>>> diff --git a/drivers/soc/ti/pruss.c b/drivers/soc/ti/pruss.c >>>> index c8053c0d735f..537a3910ffd8 100644 >>>> --- a/drivers/soc/ti/pruss.c >>>> +++ b/drivers/soc/ti/pruss.c >>>> @@ -164,6 +164,47 @@ int pruss_release_mem_region(struct pruss *pruss, >>>> } >>>> EXPORT_SYMBOL_GPL(pruss_release_mem_region); >>> >>> cheers, >>> -roger >> -- Thanks and Regards, Danish. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel