From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5F57AC27C4F for ; Thu, 13 Jun 2024 19:59:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=J8nD3Tx/2ajPq4oiZeg181ZjliU9kpOqAJj/ASz1bTw=; b=TVZSwrDk5cS8oavwSoHwmT0F+g HSaorRCjcnlbtoO4NSpqMF4gVSSfcgIkeeoDvZfjWfX4dCs5+f50A29niKAMBaG327nGxMDEbJSqz O1iVk4MUGHtPNLWiZzITS+d0hiuSdpb45QRuKXFMQbSVLqQTQuqsTik9xfrFObEsPj0IALOPxlttN plM+eoAKfw/7+X9brzdgqeH+Q5H4Pwm8heWw1p7uCJyHaD4Xr3A1yUesYzSsKbOFxwuV2H4xXDdDV WaCMzih0Mfm9p5Z27P9b6WXhqNV79KOVyqMALuA+CMnH+9xr7dUN0KDfJG7xDad1y8wXX7zp7hk8R rHkFIcIQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHqaw-00000000LiI-1PQH; Thu, 13 Jun 2024 19:58:50 +0000 Received: from mail-wr1-x430.google.com ([2a00:1450:4864:20::430]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHqat-00000000LhL-1gL2 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 19:58:48 +0000 Received: by mail-wr1-x430.google.com with SMTP id ffacd0b85a97d-35f1dc4ab9aso1286843f8f.3 for ; Thu, 13 Jun 2024 12:58:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1718308726; x=1718913526; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=J8nD3Tx/2ajPq4oiZeg181ZjliU9kpOqAJj/ASz1bTw=; b=kWna4wJG2C72xlFp+oJnYwGljEYj+ByAWUGtz3d/mUyYxJUr8CZ05xIAdUMjnV3rFe tOTsns1s/ykh3dAL+W4HH1z2l5UlO6z0s+CJ+pBN3ugTUyuw59eeaRLZ7zDblzb3eRcI LCItuGPrlb6bgkj1QL9MFIZ9i5zLGN1SiSzVeTIYuFu/Um9qmi3r1JaX2ugdzTHrZr6k 24925lAQxNarYrWfXAvTNRkVfwk0Ira59hv/DlxaDIPmu8qjgiDZU6m31iJWdsPL2d2Z 5AS/TgeeVVpwlL8eLISRbsA00YS6J/Z2oGR7d3X7S8sWmMR4m9D7T9fCh4y/65CVx/o7 vODQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718308726; x=1718913526; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=J8nD3Tx/2ajPq4oiZeg181ZjliU9kpOqAJj/ASz1bTw=; b=M7wJzwHkoa3ntTCsSCEns6ZpDMKM27mnQmELyBGF7i8TPFPyBVA76oZgvN5X+AG1xK NMLLL+EtFc+KOUqsp4rcnXTirwjuGfnJVFCL48X1pLOUvl3/+Mh9l3dKSckunePkoRG3 z3/QaLyonJ5SciQkAt7Ee/qm6FMtAoWFD6FEnd2mzsKak8ysiN6CHtZq/4PP/GKuyiGu vGdtwBtp2U5nBU+YaKts5+KAmq7wKkcwkDuDxmdG8LMP57ro1j0OMvZd4LoKe1Aq6OIq PGoe3ppApLXycqleuj3p/YAOLRa2mmpbmWFtadJ9yxwqlDcqinQhp7+JgkMClrCKewpd f89g== X-Forwarded-Encrypted: i=1; AJvYcCVuWwwOSS38XiME9EaMvJdYQiuAQ7bhU/IIu8KIjNMHhyi700j/ilyXSGlsFlWO6h+iAEtNTM0MsO+v2wsTSowSuYZJMtKEvvpqQuW0BBKHYVVlMYo= X-Gm-Message-State: AOJu0YxaLBKkiR59jk8g4E16ckAReWhOgg/BbBgWQPlKupBfTyktMxJN JDEHwrvTwW/BlaCjvwxQA5YFQjDPN9yjzkId+O3MKu4388ubVdWlFIAyFR/CfJ0= X-Google-Smtp-Source: AGHT+IGhE54rnPxMpctAzOM52kvVqwoHNWOb3ufa5cu9POuaX89ge9H6lokYmXmoiIrQpIX/ilu++Q== X-Received: by 2002:adf:e64c:0:b0:35f:1f3c:b632 with SMTP id ffacd0b85a97d-3607a746efbmr516075f8f.12.1718308725147; Thu, 13 Jun 2024 12:58:45 -0700 (PDT) Received: from localhost ([102.222.70.76]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-36075104a0fsm2545651f8f.96.2024.06.13.12.58.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Jun 2024 12:58:44 -0700 (PDT) Date: Thu, 13 Jun 2024 22:58:40 +0300 From: Dan Carpenter To: Kieran Bingham Cc: Umang Jain , Florian Fainelli , linux-rpi-kernel@lists.infradead.org, Broadcom internal kernel review list , Greg Kroah-Hartman , Stefan Wahren , Laurent Pinchart , Dave Stevenson , detule , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:STAGING SUBSYSTEM" , open list , Julia Lawall Subject: Re: [PATCH] staging: vc04_services: vchiq_arm: Fix initialisation check Message-ID: References: <20240613194150.2915202-1-kieran.bingham@ideasonboard.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240613194150.2915202-1-kieran.bingham@ideasonboard.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240613_125847_512684_C67A6E07 X-CRM114-Status: GOOD ( 18.78 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Jun 13, 2024 at 08:41:45PM +0100, Kieran Bingham wrote: > --- > .../staging/vc04_services/interface/vchiq_arm/vchiq_arm.c | 4 ++-- > .../staging/vc04_services/interface/vchiq_arm/vchiq_core.h | 5 +++++ > .../staging/vc04_services/interface/vchiq_arm/vchiq_dev.c | 7 ++++++- > 3 files changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index 54467be8c371..67d853f5f2a0 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -804,7 +804,7 @@ int vchiq_initialise(struct vchiq_state *state, struct vchiq_instance **instance > * block forever. > */ > for (i = 0; i < VCHIQ_INIT_RETRIES; i++) { > - if (state) > + if (vchiq_remote_initialised(state)) > break; > usleep_range(500, 600); > } :/ In the original code, this would either break on the first iteration or fail. The diff looked like this: for (i = 0; i < VCHIQ_INIT_RETRIES; i++) { - state = vchiq_get_state(); if (state) break; I feel bad for not spotting this. A static checker which looked at diffs could have made this work, but all of our tools look at a momement in time instead of looking at the change over time. regards, dan carpenter