From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 85163C2D0A3 for ; Fri, 30 Oct 2020 00:18:49 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 042B320756 for ; Fri, 30 Oct 2020 00:18:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="KHDrjmzM"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="JymtVPNW" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 042B320756 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Type:Cc: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: MIME-Version:References:In-Reply-To:Date:To:From:Subject:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=y2Tac7sXDMrHhmkeHZdOPsMrKk16SwyzwdkU8kzg/sI=; b=KHDrjmzMKnOI1JcPwcHTwizpC 7mnfCJD8fW0oqCsF4gFb9PlsVTjV7VHlAyL1PaxxgTdCGihTVxHveLEnBBJ6256ipYjv3FzFdcTHK vVrhcV8qXFKZbO7P4toAbOJIWsTIsYa/diDCitl2AUxopbiRsIwPi+rizCCHQQfqIZlvFADHTa47h DguVRziXcjWjDhs8v5qJ4CoMIqNobpFzxLZ5icwpFd4J3iaFRYEBC+ZsY+ZRGSIe8i76KQp29t9B9 MzeA/N4DabGtzG2dApatv2jLX2tNc7+5ArOYvrva+1jN1SbbT+kAko/mUjdDY+OHMiptA9VT6Azs4 1jrVRJWpQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYI7Y-0003fV-U5; Fri, 30 Oct 2020 00:18:20 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kYI7W-0003f3-TC for linux-arm-kernel@lists.infradead.org; Fri, 30 Oct 2020 00:18:19 +0000 Received: by mail-wm1-x343.google.com with SMTP id a72so1388271wme.5 for ; Thu, 29 Oct 2020 17:18:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version; bh=yC8QOupSauHZavYsUjUVIqNfcGL6GE/jTv0R5N5Kzrw=; b=JymtVPNWgjhIwuT1y0WAJ41BB8mPF4egN1VSvUe0LMgYx/f4LcMSHRbfsVjb5pk+E3 lgucZS28GuXHkijFk8r8Lq+igbcwxzU1lkubWGPZg0S9cwA5PxXSHQq10jVKTXWVj82t vFvINmpUyz5E4ftOf5nCq8Sk5sNg+UB1ZbWHCZqLDCYC3FScqTNaG3UgFP9w6NgvkDtr v1f84SUNVrU7lVu5UYSwB9OmzRVrKvRjkz4aHEqa3yRSMDCryZjV8OUeklSe5w/GV4Wn x1o1/58YBEC34VjEdOPMhRjtoxrR1aXhLQ7UIeYpd88vJKi3l5gBWiwuRO8P/dJH1Pch KPOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version; bh=yC8QOupSauHZavYsUjUVIqNfcGL6GE/jTv0R5N5Kzrw=; b=s7l3swsV4taIX3P/hoHhdomfLnptaY7YqbfK0NUBHJL+LtDVCmLQAVW3NWvBdmrCb1 RJuy8pjEgTiXtXrSwEeGVAVoZYYRKUAEm7iqn0ItMXRC/oz1UB6wWqTt8ly+MdQUkjs1 iW+3pTJ8D7CB+e0qGJvZEzd/OfxtecIcadG4x0z88y61jQ7fS5PPlxwHnm4/uVhOyISy 7C9lQHHLD85c7aEq3AeJgFDFQEF23CyaAw2LtUD+dXB8DpoFlzr6ikGwimr2Raod50zN enX2HcURftVeCUsf+XtyoMsZSwr/2xrNGKXlYDE8ssEOYidXXmVyig3qyCBtuUe3hDnz fBfA== X-Gm-Message-State: AOAM531d6Fge9lIxymsNMAOIY0kpNPyAj1cDbGz1zepSq37i2rrNfZif 50tFZR9Abuhg0vADVaVqplfZdR5Iqj9ZRnv0 X-Google-Smtp-Source: ABdhPJwgKMCrAquaodl4ujMqMmBlJ8PPkq/k9YuJxGF7NDykjIPCbtKhkY958Xab0vbO9F+VjASaFA== X-Received: by 2002:a1c:7d0f:: with SMTP id y15mr1846810wmc.84.1604017097335; Thu, 29 Oct 2020 17:18:17 -0700 (PDT) Received: from matteo-xps-15-9560.lan ([2a01:4b00:a40c:9900::14e]) by smtp.gmail.com with ESMTPSA id l16sm7957315wrx.5.2020.10.29.17.18.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Oct 2020 17:18:16 -0700 (PDT) Message-ID: Subject: Re: [PATCH 3/5] ARM: dts: sun8i: s3: Add dtsi for the Elimo Impetus SoM From: Matteo Scordino To: Paul Kocialkowski Date: Fri, 30 Oct 2020 00:18:14 +0000 In-Reply-To: <20201029100936.GC460689@aptenodytes> References: <20201029022000.601913-1-matteo.scordino@gmail.com> <20201029022000.601913-4-matteo.scordino@gmail.com> <20201029100936.GC460689@aptenodytes> User-Agent: Evolution 3.36.4-2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201029_201819_071479_BC803808 X-CRM114-Status: GOOD ( 31.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: wens@csie.org, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, mripard@kernel.org, linux-kernel@vger.kernel.org Content-Type: multipart/mixed; boundary="===============0834998722546723382==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============0834998722546723382== Content-Type: multipart/signed; micalg="pgp-sha512"; protocol="application/pgp-signature"; boundary="=-kiWXrusefHO84ILaiCsr" --=-kiWXrusefHO84ILaiCsr Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello Paul, Thanks for reviewing!=20 It seems from the comments in [PATCH 4/5] that the consensus would be to= =20 drop allwinner,sun8i-s3 and keep sochip,s3 (I guess due to the fact that the S3 is distributed by Sochip). And yes, you're right that it makes sense to add allwinner,sun8i-v3 at=20 the end.=20 So I guess I will resubmit with: compatible =3D "elimo,impetus", "sochip,s3", "allwinner,sun8i-v3"; Regarding adding allwinner,sun8i-v3 to sunxi.c: I agree, but I would hear Icenowy thinks (I think she added allwinner,sun8i-v3 in a patch last month). --=20 Matteo Scordino On Thu, 2020-10-29 at 11:09 +0100, Paul Kocialkowski wrote: > Hi, >=20 > On Thu 29 Oct 20, 02:19, Matteo Scordino wrote: > > The Elimo Engineering Impetus is an Open Source Hardware System-on-Modu= le > > based on the SoChip S3 SoC. > >=20 > > It is meant for integration into carrier boards or, more generally, > > larger designs, and uses an M2 connector to facilitate that. > >=20 > > Interfaces on the M.2/NGFF 42mm connector: > > WiFi IEEE 802. 11abgn (on-module Realtek) > > Bluetooth 4.2/BLE (on-module Realtek) > > RGB LCD Interface (on-module connector) > > MIPI Camera Interface (on-module connector) > > IEEE 802. 3u Ethernet MAC (external connecto) > > USB2.0 (Host, Device, OTG) (external connector) > > Audio Line In/Out (external connector) > >=20 > > Signed-off-by: Matteo Scordino > > --- > > arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi | 51 +++++++++++++++++++ > > 1 file changed, 51 insertions(+) > > create mode 100644 arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi > >=20 > > diff --git a/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi > > b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi > > new file mode 100644 > > index 000000000000..3550125cf334 > > --- /dev/null > > +++ b/arch/arm/boot/dts/sun8i-s3-elimo-impetus.dtsi > > @@ -0,0 +1,51 @@ > > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > > +/* > > + * Copyright (C) 2020 Matteo Scordino > > + */ > > + > > +/dts-v1/; > > +#include "sun8i-v3.dtsi" > > +#include "sunxi-common-regulators.dtsi" > > + > > +/ { > > + model =3D "Elimo Impetus SoM"; > > + compatible =3D "elimo,impetus", "sochip,s3", "allwinner,sun8i-s3"; >=20 > I'm wondering what to do about the SoC compatibles here: > - Do we really need the "sochip,s3" compatible, as it seems redundant wit= h > "allwinner,sun8i-s3"? > - Could we add a "allwinner,sun8i-v3" compatible at the end since there i= s no > functional difference between the two? >=20 > Another thing is that we should probably add "allwinner,sun8i-v3" to > mach-sunxi/sunxi.c so that it's matched by the DT_MACHINE_START. >=20 > If that seems agreeable, I can craft a patch for the latter. >=20 > What do you think? >=20 > The rest of the dt looks good to me :) >=20 > Cheers, >=20 > Paul >=20 > > + > > + aliases { > > + serial0 =3D &uart0; > > + serial1 =3D &uart1; > > + }; > > + > > + chosen { > > + stdout-path =3D "serial0:115200n8"; > > + }; > > +}; > > + > > +&mmc0 { > > + broken-cd; > > + bus-width =3D <4>; > > + vmmc-supply =3D <®_vcc3v3>; > > + status =3D "okay"; > > +}; > > + > > +&uart0 { > > + pinctrl-0 =3D <&uart0_pb_pins>; > > + pinctrl-names =3D "default"; > > + status =3D "okay"; > > +}; > > + > > +&uart1 { > > + pinctrl-0 =3D <&uart1_pg_pins>; > > + pinctrl-names =3D "default"; > > + status =3D "okay"; > > +}; > > + > > +&usb_otg { > > + dr_mode =3D "otg"; > > + status =3D "okay"; > > +}; > > + > > +&usbphy { > > + usb0_id_det-gpio =3D <&pio 5 6 GPIO_ACTIVE_HIGH>; > > + status =3D "okay"; > > +}; > > --=20 > > 2.20.1 > >=20 > >=20 > > _______________________________________________ > > linux-arm-kernel mailing list > > linux-arm-kernel@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --=-kiWXrusefHO84ILaiCsr Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEzO0zAuXCENUlBKYqFH4A68XNhRoFAl+bW8YACgkQFH4A68XN hRoSqxAAh0cTVYjKJnytXIOwRXEQ1aWO3NEz+LQQ9FEmI/IKErcNU8uzz12ka4Jx aETeHBWgDqvcKBqhhQmEGZkFlhP45IuwcvgzIxiX8eBhpFFVu1oKIARFM9UsZqp5 rgymMVmHJVX95e4gaXm41rxok5fADlKmuG6aJnFxxRJnF6nEqi3G9aXPbDEBWwn6 x0r5IsHOieNxhxTmyUEEWhOjQmIyHd6Xt2MqtzAOG43WP/7xUC1cS4vVJgvjfIhC 4CHbtriucglnWs33i7G9xJRBYqnppnT3r3Lb5MzwZzD3rxS8uylxM4BSnE4nUfFS Vo6VVq8ZkxUOqdV1r3zd5nV6ApuKl/VukC6rHXRIiiSLhDyritz2mkCKF8CHShl2 3/edfB0V5SXsuYQcKIMRGQgtWMwoL9goXwE8J41PCV4o3eQMKmi4+ZCtD3LlYVzz WNM9BHSkNXyfku/hAAOxcFKrSZOM34sQxMIFIzFwh87J0BcNV96vKMUy81fe/eYt DzKMaGI0vvpJLr0dWf5KYntq8Qm6RrO3pEpXMiD/LbchgKZsCR/1nolJKUj4yxzO GCaYARpMVa4nxwOmcJrTRvoIdPBRZIal0RNrB5ccyit9DQan1r2Uf2V2pnGXuj9r CdgVVRhqgUcs9Uvu1kNBfMVk9TvratsiYVXkK/0oCk/UBjVZDtc= =orG8 -----END PGP SIGNATURE----- --=-kiWXrusefHO84ILaiCsr-- --===============0834998722546723382== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============0834998722546723382==--