From: suzuki.poulose@arm.com (Suzuki K Poulose)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] coresight: etf: Release CLAIM tag after disabling the HW
Date: Tue, 6 Nov 2018 09:27:38 +0000 [thread overview]
Message-ID: <a44849f6-c918-8613-db8d-fc32226b5342@arm.com> (raw)
In-Reply-To: <1541456790-28282-3-git-send-email-mathieu.poirier@linaro.org>
On 05/11/2018 22:26, Mathieu Poirier wrote:
> This patch rectifies the sequence of events in function
> tmc_etb_disable_hw() by disabling the HW first and then releasing the
> CLAIM tag. Otherwise we could be corrupting the configuration done by an
> external agent that would have claimed the device after we have released
> it.
>
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> ---
> drivers/hwtracing/coresight/coresight-tmc-etf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hwtracing/coresight/coresight-tmc-etf.c b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> index 5864ac55e275..a5f053f2db2c 100644
> --- a/drivers/hwtracing/coresight/coresight-tmc-etf.c
> +++ b/drivers/hwtracing/coresight/coresight-tmc-etf.c
> @@ -86,8 +86,8 @@ static void __tmc_etb_disable_hw(struct tmc_drvdata *drvdata)
>
> static void tmc_etb_disable_hw(struct tmc_drvdata *drvdata)
> {
> - coresight_disclaim_device(drvdata->base);
> __tmc_etb_disable_hw(drvdata);
> + coresight_disclaim_device(drvdata->base);
> }
>
Well spotted.
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
next prev parent reply other threads:[~2018-11-06 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-05 22:26 [PATCH 0/3] coresight: Fix miscellaneous problems with CLAIM tags Mathieu Poirier
2018-11-05 22:26 ` [PATCH 1/3] coresight: etb10: Add support for CLAIM tag Mathieu Poirier
2018-11-06 9:21 ` Suzuki K Poulose
2018-11-05 22:26 ` [PATCH 2/3] coresight: etf: Release CLAIM tag after disabling the HW Mathieu Poirier
2018-11-06 9:27 ` Suzuki K Poulose [this message]
2018-11-05 22:26 ` [PATCH 3/3] coresight: etm3x: Release CLAIM tag when operated from perf Mathieu Poirier
2018-11-07 3:23 ` leo.yan at linaro.org
2018-11-08 9:49 ` Suzuki K Poulose
2018-11-08 17:10 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a44849f6-c918-8613-db8d-fc32226b5342@arm.com \
--to=suzuki.poulose@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).