From: Krzysztof Kozlowski <krzk@kernel.org>
To: Animesh Agarwal <animeshagarwal28@gmail.com>
Cc: Vinod Koul <vkoul@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dmaengine@vger.kernel.org, devicetree@vger.kernel.org,
imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] dt-bindings: dma: fsl,imx-dma: Convert to dtschema
Date: Fri, 31 May 2024 12:19:40 +0200 [thread overview]
Message-ID: <a472e8ba-bf54-4a62-9b05-ea265a83ef1b@kernel.org> (raw)
In-Reply-To: <20240531090458.99744-1-animeshagarwal28@gmail.com>
On 31/05/2024 11:04, Animesh Agarwal wrote:
> Convert the fsl i.MX DMA controller bindings to DT schema.
>
> Signed-off-by: Animesh Agarwal <animeshagarwal28@gmail.com>
> ---
> .../devicetree/bindings/dma/fsl,imx-dma.yaml | 56 +++++++++++++++++++
Thank you for your patch. There is something to discuss/improve.
> + "#dma-cells":
> + const: 1
> +
> + dma-channels:
> + maximum: 16
maximum or const?
deprecated: true
> +
> + dma-requests:
> + description: Number of DMA requests supported.
deprecated: true
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - "#dma-cells"
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + dma-controller@10001000 {
> + compatible = "fsl,imx27-dma";
> + reg = <0x10001000 0x1000>;
> + interrupts = <32 33>;
> + #dma-cells = <1>;
> + dma-channels = <16>;
and drop it from here
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2024-05-31 10:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-31 9:04 [PATCH v2] dt-bindings: dma: fsl,imx-dma: Convert to dtschema Animesh Agarwal
2024-05-31 10:19 ` Krzysztof Kozlowski [this message]
2024-05-31 11:13 ` Animesh Agarwal
2024-06-04 19:57 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a472e8ba-bf54-4a62-9b05-ea265a83ef1b@kernel.org \
--to=krzk@kernel.org \
--cc=animeshagarwal28@gmail.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=imx@lists.linux.dev \
--cc=kernel@pengutronix.de \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).