From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B687BC31E4C for ; Thu, 13 Jun 2019 16:20:20 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 69E4221721 for ; Thu, 13 Jun 2019 16:20:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="akKr74RF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 69E4221721 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender:Content-Type: Content-Transfer-Encoding:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DTtkDuRngTXrKVlI5F5EB1BI0Hj/aFHtd9wRBqWLu1E=; b=akKr74RFtPd4Rn4Mv6C8nXGaZ wd6aWanSCFyIQ+az+UlR+Of18f/ef5EfWGGw9AFue1CEgzx9AluB6w6TQEsR/Re3QLWf72KzE58Am gZmWhfPFJPp6hXcYUbnjc1svrbrnlrmNiw1IIj57urhSgfjj7KC1OTqnDSWk3xB/geiAoUPkDQIFc E5ygJxE3jVVACLaIMWth23diLhgvAgksSp2JkT4PmhsJAllHlAJU0vX4tohJofm+5de9/aAKrreCk Pe6J3r1g6G5CXfki3/o2Y65hBy4Knn1+h2ZT5GNCIKl1axMtAAzlewSI+C8nfTvZ5AQEOg3sa5/8d hq/hOiVSw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbSSR-0007ov-62; Thu, 13 Jun 2019 16:20:11 +0000 Received: from foss.arm.com ([217.140.110.172]) by bombadil.infradead.org with esmtp (Exim 4.92 #3 (Red Hat Linux)) id 1hbSRe-0006A9-H3 for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2019 16:19:24 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 42C033EF; Thu, 13 Jun 2019 09:19:22 -0700 (PDT) Received: from [10.1.196.50] (e108454-lin.cambridge.arm.com [10.1.196.50]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 082763F694; Thu, 13 Jun 2019 09:19:20 -0700 (PDT) Subject: Re: [RFC PATCH v2 1/8] arm64/fpsimd: Update documentation of do_sve_acc To: linux-arm-kernel@lists.infradead.org References: <20190613161656.20765-1-julien.grall@arm.com> <20190613161656.20765-2-julien.grall@arm.com> From: Julien Grall Message-ID: Date: Thu, 13 Jun 2019 17:19:19 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190613161656.20765-2-julien.grall@arm.com> Content-Language: en-US X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190613_091922_735113_9FCDD6BA X-CRM114-Status: GOOD ( 19.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , Anton.Kirilov@arm.com, catalin.marinas@arm.com, will.deacon@arm.com, oleg@redhat.com, zhang.lei@jp.fujitsu.com, alex.bennee@linaro.org, Dave.Martin@arm.com, Daniel.Kiss@arm.com Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hmmm... I just realized that I missed some comments from Marc Rutland on this patch and the next one. I will address them in the next version. Sorry for the inconvenience. Cheers, On 13/06/2019 17:16, Julien Grall wrote: > TIF_SVE is cleared by fpsimd_restore_current_state() not > task_fpsimd_load(). Update the documentation of do_sve_acc to reflect > this behavior. > > Signed-off-by: Julien Grall > > --- > Changes in v2: > - Fix typo in the commit message > --- > arch/arm64/kernel/fpsimd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c > index a38bf74bcca8..92f418e4f989 100644 > --- a/arch/arm64/kernel/fpsimd.c > +++ b/arch/arm64/kernel/fpsimd.c > @@ -853,7 +853,7 @@ void fpsimd_release_task(struct task_struct *dead_task) > * the SVE access trap will be disabled the next time this task > * reaches ret_to_user. > * > - * TIF_SVE should be clear on entry: otherwise, task_fpsimd_load() > + * TIF_SVE should be clear on entry: otherwise, fpsimd_restore_current_state() > * would have disabled the SVE access trap for userspace during > * ret_to_user, making an SVE access trap impossible in that case. > */ > -- Julien Grall _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel