From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F32C9C433EF for ; Tue, 31 May 2022 11:49:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tNQo1mrcaFOpsCYf4L2xlc0MJwY2AUoRdda7BLa1p9I=; b=rZ3nQcADGpZo5a rZxXb2sLxXFe8koP4zDlAN5fdd0CU9UXLm4qp1VqxtG0f68EkIGLncR2LYxMUXdpaxMu6ilF64Q3O Ydg3jLu5zUKH2kNA12m41MaQ3Ojb/jNd7AG0+SBU8+UNNQM1uGJnAjgZ8i/WoG+FXlvvShwQ6uF3Q LcXQ3jEu8hBhziBBf1iDXR6v/VgM+FOG3dlzPOCYgK1gBzmQupnQLiXrp3GleUO7dgHuzu9XqAm5W DNoYZbt+esYydXyvUtfby9etk3DHNZ8fxLkxvyDzwOrsmBcQnC4sflPAwkwhLGgoSj7w9SGPVqTAS XcTL6UmwKiNEk2P+ebjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw0Mm-00Aa3v-Od; Tue, 31 May 2022 11:48:52 +0000 Received: from mail-ej1-x630.google.com ([2a00:1450:4864:20::630]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nw0Mj-00Aa1w-Hr for linux-arm-kernel@lists.infradead.org; Tue, 31 May 2022 11:48:50 +0000 Received: by mail-ej1-x630.google.com with SMTP id wh22so26119915ejb.7 for ; Tue, 31 May 2022 04:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=7bhfywGiVfr9SKmJyu/pt4AMdz2eCKoqLhGa9Sh6I0M=; b=gSo7aWDWhBewdtRYI6AhSZGPymEo/Hi7nqlGWSdSvP2WjCmWEIQ3dxM8zVn7wsiwBJ f+utlV9IOq45T06qm0yXgSdPV6+0jHV7GxpoedmB2ryz5kWVoatw9I1bcvyhKFBLbA6N Me7wv18JM2w/Dk7Q7sGIv4N9/DlnraPh0z4RFgtr9vdWsP/KlHpCQTaPyRtOdlPJJiHb w+trMybFM2hrW6X5QUXniCFfJ8rld+V4gwBX7f/TGdkfXKvGnFSuvBAjV3qp4q5qeHYJ 4gNDfkijE5fRVqIKGGbrCICCmFtsrY537+Ra28E5TbZeITlrWordgRlbyIGzk6K3KP6q MSCw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=7bhfywGiVfr9SKmJyu/pt4AMdz2eCKoqLhGa9Sh6I0M=; b=3hvrCPHofhEXJSUpw01BJX64BgQylbaKtXpwkntzB1aNSs8NiaX0yKkWJSl0k53gmW 3ENsUHDs19j6bjwHgcoxT6wErA/tLuxT94akYRFBJZqH6SAq6xYnUsfD3CV5lufv4izF CASs4K1iNSmxqYTeXPWesvpaiOBsyP08gFBzbZlxpFkYFwbnnD31/l2+RlN45FnpuOJK 08SfdAFggQlDU1Q96Ssie+lsuiPGgDlFm+KrD0HASx0IHpCb/6AZq0dhklGsUzxlO9yx j7UQo/Hz/ojRgEc4GNH/Zn0xjlP5OegClsRH2Es9D4YvHZrWRl1NCxuB1SsDmn/hxUhn WMrA== X-Gm-Message-State: AOAM532rxKw0WmbWqAHZFyfvC8zZSWw/o90DvGotAwspQXDxJ5K5WQ7b 3X8BWoV4md48PBd6Wm9yzYSYAny6DxTzmBXR X-Google-Smtp-Source: ABdhPJwcNLd9LnCiYZOXV8MwmtT3ra4raRUTYvS0GEN/xsJdOBcdPNqdR+hvE0rsqf7imJzUMUb6HQ== X-Received: by 2002:a17:907:2d06:b0:6fe:af0f:2fab with SMTP id gs6-20020a1709072d0600b006feaf0f2fabmr45791538ejc.324.1653997725953; Tue, 31 May 2022 04:48:45 -0700 (PDT) Received: from [192.168.0.179] (xdsl-188-155-176-92.adslplus.ch. [188.155.176.92]) by smtp.gmail.com with ESMTPSA id e6-20020a170906844600b006fee13caaeasm4878148ejy.190.2022.05.31.04.48.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 04:48:45 -0700 (PDT) Message-ID: Date: Tue, 31 May 2022 13:48:44 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v2 1/2] dt-bindings: net: Add ICSSG Ethernet Driver bindings Content-Language: en-US To: Puranjay Mohan , linux-kernel@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, krzysztof.kozlowski+dt@linaro.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, nm@ti.com, ssantosh@kernel.org, s-anna@ti.com, linux-arm-kernel@lists.infradead.org, rogerq@kernel.org, grygorii.strashko@ti.com, vigneshr@ti.com, kishon@ti.com, robh+dt@kernel.org, afd@ti.com, andrew@lunn.ch References: <20220531095108.21757-1-p-mohan@ti.com> <20220531095108.21757-2-p-mohan@ti.com> <4ccba38a-ccde-83cd-195b-77db7a64477c@linaro.org> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220531_044849_640455_0E839E83 X-CRM114-Status: GOOD ( 14.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 31/05/2022 13:27, Puranjay Mohan wrote: >>> +examples: >>> + - | >>> + >>> + /* Example k3-am654 base board SR2.0, dual-emac */ >>> + pruss2_eth: pruss2_eth { >>> + compatible = "ti,am654-icssg-prueth"; >> >> Again missed Rob's comment. > > One of Rob's comment was to make the indentation as 4 which I have done. I clearly do not see indentation of 4, but there is 8 instead. Let's count: + pruss2_eth: pruss2_eth { + compatible = "ti,am654-icssg-prueth"; 12345678^ It's 8... > > The second comment was about 'ti,prus'. > > So, ti,prus , firmware-name, and ti,pruss-gp-mux-sel are a part of > remoteproc/ti,pru-consumer.yaml which I have included with > > allOf: > - $ref: /schemas/remoteproc/ti,pru-consumer.yaml# > > So, I thought it is not required to add them again. > > I will add it in next version, if that is how it should be done. I was referring to the indentation. Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel