From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E12CFC433EF for ; Mon, 14 Mar 2022 10:19:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/f6P6UGtaOfF6ece3A7HuOEHlQYztsOPmUGJS8MNyY8=; b=EIKhEeneMc6cgk opXp8bYMP2FLyl2sdDaxvnz3Rm2/DXSFlHAxL5nUers5EPCXtRDEJqjLtFHRXELXUqla3XcBYsqcj IB/QhB+xfN7hlMeZWhZO+2LB0I3pwdDN9pl56anV1Td5LiCTfcBZAtVan5LXcZK+s24vdAohAAYYP +AD5SCGhFduMHDAxoPX/817zIgQpOKevabV5hhr8KUu5lShuPVonPfyx2twLWSVvbV3D4kJOeWe86 lx/0MQsca+O0Tor+CN55P9OsW4iI0kyDCp9NciKDaoqeaZ1IqywXCz7HQOsyLNFbkTuHON3WPLBKb XHZRohlc2huKx96tpyWg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nThmE-004uCD-LT; Mon, 14 Mar 2022 10:18:10 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nThmB-004uBJ-Fg; Mon, 14 Mar 2022 10:18:08 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: kholk11) with ESMTPSA id 503631F43E42 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1647253086; bh=nQGCEaQV4SSt7P7Vs4H6IutV6PQurOMGF3CTakySQ4Y=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=dZPSbnMF4ru8XqiTI61+q3Z0UEJ7yUYvUGIdlnPn8gD/ZAKNSSa9xQKI6cEe39jCT yEn5aSAbkzH4PgPoFNVjWXMx09Knhf/u9WT41z1wMPWXxjAl4e34+gi2RL4gFrD4ZF sm5PKK1jQRFrwxhYg95pzkz9pL9aQgrB/SAjl1aAfSA7ClNhLIOX0G2TNkoHbmfr5s hckhD84BpWv2LmD71gMNYe8wiqVfNke5nffD8VZHRQIGarIxuTViBB3NTIBi+8iTt2 aFhq4s1Rrx2Iby/cyGUWO9kkNZaaRVmFoMBdHRzILvvqZNzd5njH38XEpiJU3I0H9V jiA5EFb9NLzHQ== Message-ID: Date: Mon, 14 Mar 2022 11:18:02 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [v3 19/19] ASoC: mediatek: mt6358: add missing EXPORT_SYMBOLs Content-Language: en-US To: Jiaxin Yu , broonie@kernel.org, robh+dt@kernel.org Cc: aaronyu@google.com, matthias.bgg@gmail.com, trevor.wu@mediatek.com, tzungbi@google.com, julianbraha@gmail.com, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, Project_Global_Chrome_Upstream_Group@mediatek.com References: <20220313151023.21229-1-jiaxin.yu@mediatek.com> <20220313151023.21229-20-jiaxin.yu@mediatek.com> From: AngeloGioacchino Del Regno In-Reply-To: <20220313151023.21229-20-jiaxin.yu@mediatek.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220314_031807_720975_CF752677 X-CRM114-Status: GOOD ( 14.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Il 13/03/22 16:10, Jiaxin Yu ha scritto: > This fixes the following build errors when mt6358 is configured as module: > >>> ERROR: modpost: "mt6358_set_mtkaif_protocol" >>> [sound/soc/mediatek/mt8186/mt8186-mt6366-rt1019-rt5682s.ko] undefined! >>> ERROR: modpost: "mt6358_set_mtkaif_protocol" >>> [sound/soc/mediatek/mt8186/mt8186-mt6366-da7219-max98357.ko] undefined! > > Signed-off-by: Jiaxin Yu Hello Jiaxin, Can you please add a Fixes tag to this patch and send it separately from the MT8186 series? After adding the Fixes tag: Reviewed-by: AngeloGioacchino Del Regno Thanks, Angelo > --- > sound/soc/codecs/mt6358.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/sound/soc/codecs/mt6358.c b/sound/soc/codecs/mt6358.c > index 1fdd2f8cf877..61f2a7632fd4 100644 > --- a/sound/soc/codecs/mt6358.c > +++ b/sound/soc/codecs/mt6358.c > @@ -107,6 +107,7 @@ int mt6358_set_mtkaif_protocol(struct snd_soc_component *cmpnt, > priv->mtkaif_protocol = mtkaif_protocol; > return 0; > } > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_protocol); > > static void playback_gpio_set(struct mt6358_priv *priv) > { > @@ -273,6 +274,7 @@ int mt6358_mtkaif_calibration_enable(struct snd_soc_component *cmpnt) > 1 << RG_AUD_PAD_TOP_DAT_MISO_LOOPBACK_SFT); > return 0; > } > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_enable); > > int mt6358_mtkaif_calibration_disable(struct snd_soc_component *cmpnt) > { > @@ -296,6 +298,7 @@ int mt6358_mtkaif_calibration_disable(struct snd_soc_component *cmpnt) > capture_gpio_reset(priv); > return 0; > } > +EXPORT_SYMBOL_GPL(mt6358_mtkaif_calibration_disable); > > int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component *cmpnt, > int phase_1, int phase_2) > @@ -310,6 +313,7 @@ int mt6358_set_mtkaif_calibration_phase(struct snd_soc_component *cmpnt, > phase_2 << RG_AUD_PAD_TOP_PHASE_MODE2_SFT); > return 0; > } > +EXPORT_SYMBOL_GPL(mt6358_set_mtkaif_calibration_phase); > > /* dl pga gain */ > enum { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel